From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] soc: imx: gpc: fix imx6sl gpc power domain regression
Date: Mon, 20 Mar 2017 10:26:14 +0100 [thread overview]
Message-ID: <1490001974.2895.11.camel@pengutronix.de> (raw)
In-Reply-To: <1489990547-1510-5-git-send-email-aisheng.dong@nxp.com>
Am Montag, den 20.03.2017, 14:15 +0800 schrieb Dong Aisheng:
> Commit 721cabf6c660 ("soc: imx: move PGC handling to a new GPC driver")
> broke the MX6SL GPC power domain support.
> It always got the following error:
> [ 1.248364] imx-gpc 20dc000.gpc: could not find pgc DT node
> This patch adds back the legecy support.
This patch removes a safeguard against abusing the old binding for new
SoCs. Please leave this check in place and instead loosen the check to
also allow the old i.MX6SL binding.
>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Fixes: 721cabf6c660 ("soc: imx: move PGC handling to a new GPC driver")
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
> drivers/soc/imx/gpc.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index ba6e7ab..c1d0e67 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -385,12 +385,6 @@ static int imx_gpc_probe(struct platform_device *pdev)
> }
>
> if (!pgc_node) {
> - /* old DT layout is only supported for mx6q aka 2 domains */
> - if (of_id_data->num_domains != 2) {
> - dev_err(&pdev->dev, "could not find pgc DT node\n");
> - return -ENODEV;
> - }
> -
> ret = imx_gpc_old_dt_init(&pdev->dev, regmap);
> if (ret)
> return ret;
next prev parent reply other threads:[~2017-03-20 9:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 6:15 [PATCH 0/8] soc: imx: gpc: fixes and clean up Dong Aisheng
2017-03-20 6:15 ` [PATCH 1/8] soc: imx: gpc: fix gpc clk get error handling Dong Aisheng
2017-03-20 8:05 ` Shawn Guo
2017-03-22 18:33 ` Dong Aisheng
2017-03-22 6:38 ` Shawn Guo
2017-03-20 6:15 ` [PATCH 2/8] soc: imx: gpc: fix the wrong using of regmap cache Dong Aisheng
2017-03-20 9:38 ` Lucas Stach
2017-03-22 18:53 ` Dong Aisheng
2017-03-22 8:43 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 3/8] soc: imx: gpc: fix domain_index sanity check issue Dong Aisheng
2017-03-20 9:40 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 4/8] soc: imx: gpc: fix imx6sl gpc power domain regression Dong Aisheng
2017-03-20 9:26 ` Lucas Stach [this message]
2017-03-22 19:23 ` Dong Aisheng
2017-03-22 8:46 ` Lucas Stach
2017-03-23 0:47 ` Dong Aisheng
2017-03-20 6:15 ` [PATCH 5/8] soc: imx: gpc: fix comment when power up domain Dong Aisheng
2017-03-20 9:41 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 6/8] soc: imx: gpc: keep PGC_X_CTRL name align with reference manual Dong Aisheng
2017-03-20 9:42 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 7/8] dt-bindings: imx-gpc: correct the DOMAIN_INDEX using Dong Aisheng
2017-03-20 9:43 ` Lucas Stach
2017-03-20 6:15 ` [PATCH 8/8] soc: imx: gpc: remove unnecessary readable_reg callback Dong Aisheng
2017-03-20 9:43 ` Lucas Stach
2017-03-22 19:25 ` Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490001974.2895.11.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).