From: rick.chang@mediatek.com (Rick Chang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] [media] vcodec: mediatek: mark pm functions as __maybe_unused
Date: Tue, 21 Mar 2017 09:46:29 +0800 [thread overview]
Message-ID: <1490060789.27725.9.camel@mtksdaap41> (raw)
In-Reply-To: <20170320094812.1365229-2-arnd@arndb.de>
On Mon, 2017-03-20 at 10:47 +0100, Arnd Bergmann wrote:
> When CONFIG_PM is disabled, we get a couple of unused functions:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:927:13: error: 'mtk_jpeg_clk_off' defined but not used [-Werror=unused-function]
> static void mtk_jpeg_clk_off(struct mtk_jpeg_dev *jpeg)
> ^~~~~~~~~~~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:916:13: error: 'mtk_jpeg_clk_on' defined but not used [-Werror=unused-function]
> static void mtk_jpeg_clk_on(struct mtk_jpeg_dev *jpeg)
>
> Rather than adding more error-prone #ifdefs around those, this patch
> removes the existing #ifdef checks and marks the PM functions as __maybe_unused
> to let gcc do the right thing.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Acked-by: Rick Chang <rick.chang@mediatek.com>
next prev parent reply other threads:[~2017-03-21 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:47 [PATCH 1/2] [media] vcodec: mediatek: add missing linux/slab.h include Arnd Bergmann
2017-03-20 9:47 ` [PATCH 2/2] [media] vcodec: mediatek: mark pm functions as __maybe_unused Arnd Bergmann
2017-03-21 1:46 ` Rick Chang [this message]
2017-03-21 1:22 ` [PATCH 1/2] [media] vcodec: mediatek: add missing linux/slab.h include Rick Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490060789.27725.9.camel@mtksdaap41 \
--to=rick.chang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox