From: dwmw2@infradead.org (David Woodhouse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v33 00/14] add kdump support
Date: Tue, 21 Mar 2017 09:42:23 +0000 [thread overview]
Message-ID: <1490089343.5036.92.camel@infradead.org> (raw)
In-Reply-To: <20170321073452.GA17298@linaro.org>
On Tue, 2017-03-21 at 16:34 +0900, AKASHI Takahiro wrote:
> Yes, it is intentional. I removed 'offline' code in my v14 (2016/3/4).
> As you assumed, I'd expect 'online' status of all CPUs to be kept
> unchanged in the core dump.
I wonder if it would be better to take a *copy* of it and put it back
after we're done taking the CPUs down? As things stand, we now have
*three* different methods of taking down all the CPUs... and *none* of
them allow a platform to override it with an NMI-based or STONITH-based
method, which seems like something of an oversight.
> If you can agree, I would like to modify this disputed warning code to:
>?
> + BUG_ON(!in_kexec_crash && (stuck_cpus || (num_online_cpus() > 1)));
> + WARN(in_kexec_crash && (stuck_cpus || smp_crash_stop_failed()),
> + "Some CPUs may be stale, kdump will be unreliable.\n");
That works; thanks.
FWIW I'm currently blaming my platform's firmware for my sporadic
crash-on-CPU#1 failures. If your testing includes crashes on non-boot
CPUs (perhaps using the sysrq hack I posted) and it reliably passes for
you, then let's ignore that for now.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4938 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170321/3266da88/attachment-0001.bin>
next prev parent reply other threads:[~2017-03-21 9:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 9:56 [PATCH v33 00/14] add kdump support AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 01/14] memblock: add memblock_clear_nomap() AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 02/14] memblock: add memblock_cap_memory_range() AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 03/14] arm64: limit memory regions based on DT property, usable-memory-range AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 04/14] arm64: kdump: reserve memory for crash dump kernel AKASHI Takahiro
2017-03-17 10:46 ` David Woodhouse
2017-03-17 11:31 ` AKASHI Takahiro
2017-03-17 11:32 ` David Woodhouse
2017-03-15 9:59 ` [PATCH v33 05/14] arm64: mm: allow for unmapping part of kernel mapping AKASHI Takahiro
2017-03-21 10:35 ` James Morse
2017-03-23 11:43 ` AKASHI Takahiro
2017-03-24 10:57 ` Ard Biesheuvel
2017-03-27 13:49 ` AKASHI Takahiro
2017-03-21 11:16 ` Ard Biesheuvel
2017-03-23 10:56 ` AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 06/14] arm64: kdump: protect crash dump kernel memory AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 07/14] arm64: hibernate: preserve kdump image around hibernation AKASHI Takahiro
2017-03-21 18:25 ` James Morse
2017-03-23 11:29 ` AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 08/14] arm64: kdump: implement machine_crash_shutdown() AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 09/14] arm64: kdump: add VMCOREINFO's for user-space tools AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 10/14] arm64: kdump: provide /proc/vmcore file AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 11/14] arm64: kdump: enable kdump in defconfig AKASHI Takahiro
2017-03-15 9:59 ` [PATCH v33 12/14] Documentation: kdump: describe arm64 port AKASHI Takahiro
2017-03-15 10:00 ` [PATCH v33 13/14] Documentation: dt: chosen properties for arm64 kdump AKASHI Takahiro
2017-03-15 10:01 ` [PATCH v33 14/14] efi/libstub/arm*: Set default address and size cells values for an empty dtb AKASHI Takahiro
2017-03-15 11:41 ` [PATCH v33 00/14] add kdump support David Woodhouse
2017-03-16 0:23 ` AKASHI Takahiro
2017-03-16 10:29 ` David Woodhouse
2017-03-17 11:43 ` David Woodhouse
2017-03-17 14:02 ` David Woodhouse
2017-03-17 15:04 ` Mark Rutland
2017-03-17 15:33 ` Mark Rutland
2017-03-17 15:47 ` David Woodhouse
2017-03-17 16:24 ` Mark Rutland
2017-03-17 16:59 ` Marc Zyngier
2017-03-17 17:10 ` Marc Zyngier
2017-03-17 20:03 ` David Woodhouse
2017-03-21 7:34 ` AKASHI Takahiro
2017-03-21 9:42 ` David Woodhouse [this message]
2017-03-20 12:42 ` Pratyush Anand
2017-03-22 16:55 ` Goel, Sameer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490089343.5036.92.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).