From: aisheng.dong@nxp.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] soc: imx: gpc: fix domain_index sanity check issue
Date: Thu, 23 Mar 2017 12:53:20 +0800 [thread overview]
Message-ID: <1490244805-3921-4-git-send-email-aisheng.dong@nxp.com> (raw)
In-Reply-To: <1490244805-3921-1-git-send-email-aisheng.dong@nxp.com>
ARRAY_SIZE(imx_gpc_domains) represents all power domains supported
by different SoCs. Driver should use SoC specific of_id_data->num_domains
instead to do power domain index sanity check.
e.g. MX6Q supports two power domains while MX6SL supports three.
Cc: Shawn Guo <shawnguo@kernel.org>
Fixes: 721cabf6c660 ("soc: imx: move PGC handling to a new GPC driver")
Acked-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
drivers/soc/imx/gpc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index 7e6a672..ba6e7ab 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -413,7 +413,7 @@ static int imx_gpc_probe(struct platform_device *pdev)
of_node_put(np);
return ret;
}
- if (domain_index >= ARRAY_SIZE(imx_gpc_domains))
+ if (domain_index >= of_id_data->num_domains)
continue;
domain = &imx_gpc_domains[domain_index];
--
2.7.4
next prev parent reply other threads:[~2017-03-23 4:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 4:53 [PATCH v2 0/8] soc: imx: gpc: fixes and clean up Dong Aisheng
2017-03-23 4:53 ` [PATCH v2 1/8] soc: imx: gpc: fix gpc clk get error handling Dong Aisheng
2017-03-23 4:53 ` [PATCH v2 2/8] soc: imx: gpc: fix the wrong using of regmap cache Dong Aisheng
2017-03-23 4:53 ` Dong Aisheng [this message]
2017-03-23 4:53 ` [PATCH v2 4/8] soc: imx: gpc: fix imx6sl gpc power domain regression Dong Aisheng
2017-03-22 13:31 ` Lucas Stach
2017-03-23 4:53 ` [PATCH v2 5/8] soc: imx: gpc: fix comment when power up domain Dong Aisheng
2017-03-23 4:53 ` [PATCH v2 6/8] soc: imx: gpc: keep PGC_X_CTRL name align with reference manual Dong Aisheng
2017-03-23 4:53 ` [PATCH v2 7/8] dt-bindings: imx-gpc: correct the DOMAIN_INDEX using Dong Aisheng
2017-03-23 4:53 ` [PATCH v2 8/8] soc: imx: gpc: remove unnecessary readable_reg callback Dong Aisheng
2017-03-24 5:49 ` [PATCH v2 0/8] soc: imx: gpc: fixes and clean up Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490244805-3921-4-git-send-email-aisheng.dong@nxp.com \
--to=aisheng.dong@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).