* [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input
@ 2017-04-03 9:55 Geert Uytterhoeven
2017-04-03 10:35 ` Simon Horman
2017-04-04 10:05 ` Laurent Pinchart
0 siblings, 2 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-04-03 9:55 UTC (permalink / raw)
To: linux-arm-kernel
The X2 crystal oscillator on the Koelsch development board provides a
74.25 MHz clock, not a 148.5 MHz clock.
Fixes: cd21cb46e14aae3a ("ARM: shmobile: koelsch: Add DU external pixel clocks to DT")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Confirmed by schematics, user manual, and physical inspection of 2
Koelsch instances (my scope has not enough bandwidth to measure the
actual frequency).
Probably this was copied from r8a7790-lager.dts, as Lager does have two
identical crystal oscillators X2 and X13.
Note that X2 is socketed, so it can be changed.
---
arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts
index 59beb8402a36007b..001e6116c47c7c3b 100644
--- a/arch/arm/boot/dts/r8a7791-koelsch.dts
+++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
@@ -292,7 +292,7 @@
x2_clk: x2-clock {
compatible = "fixed-clock";
#clock-cells = <0>;
- clock-frequency = <148500000>;
+ clock-frequency = <74250000>;
};
x13_clk: x13-clock {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input
2017-04-03 9:55 [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input Geert Uytterhoeven
@ 2017-04-03 10:35 ` Simon Horman
2017-04-04 10:05 ` Laurent Pinchart
1 sibling, 0 replies; 5+ messages in thread
From: Simon Horman @ 2017-04-03 10:35 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 03, 2017 at 11:55:19AM +0200, Geert Uytterhoeven wrote:
> The X2 crystal oscillator on the Koelsch development board provides a
> 74.25 MHz clock, not a 148.5 MHz clock.
>
> Fixes: cd21cb46e14aae3a ("ARM: shmobile: koelsch: Add DU external pixel clocks to DT")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Confirmed by schematics, user manual, and physical inspection of 2
> Koelsch instances (my scope has not enough bandwidth to measure the
> actual frequency).
>
> Probably this was copied from r8a7790-lager.dts, as Lager does have two
> identical crystal oscillators X2 and X13.
>
> Note that X2 is socketed, so it can be changed.
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input
2017-04-03 9:55 [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input Geert Uytterhoeven
2017-04-03 10:35 ` Simon Horman
@ 2017-04-04 10:05 ` Laurent Pinchart
2017-04-04 10:31 ` Geert Uytterhoeven
1 sibling, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2017-04-04 10:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
Thank you for the patch.
On Monday 03 Apr 2017 11:55:19 Geert Uytterhoeven wrote:
> The X2 crystal oscillator on the Koelsch development board provides a
> 74.25 MHz clock, not a 148.5 MHz clock.
>
> Fixes: cd21cb46e14aae3a ("ARM: shmobile: koelsch: Add DU external pixel
> clocks to DT") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Confirmed by schematics, user manual, and physical inspection of 2
> Koelsch instances (my scope has not enough bandwidth to measure the
> actual frequency).
Stupid question, have you tested the corresponding (HDMI) DU output ? If so,
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Probably this was copied from r8a7790-lager.dts, as Lager does have two
> identical crystal oscillators X2 and X13.
>
> Note that X2 is socketed, so it can be changed.
> ---
> arch/arm/boot/dts/r8a7791-koelsch.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> b/arch/arm/boot/dts/r8a7791-koelsch.dts index
> 59beb8402a36007b..001e6116c47c7c3b 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -292,7 +292,7 @@
> x2_clk: x2-clock {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> - clock-frequency = <148500000>;
> + clock-frequency = <74250000>;
> };
>
> x13_clk: x13-clock {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input
2017-04-04 10:05 ` Laurent Pinchart
@ 2017-04-04 10:31 ` Geert Uytterhoeven
2017-04-04 11:10 ` Niklas Söderlund
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2017-04-04 10:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi Laurent,
On Tue, Apr 4, 2017 at 12:05 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Monday 03 Apr 2017 11:55:19 Geert Uytterhoeven wrote:
>> The X2 crystal oscillator on the Koelsch development board provides a
>> 74.25 MHz clock, not a 148.5 MHz clock.
>>
>> Fixes: cd21cb46e14aae3a ("ARM: shmobile: koelsch: Add DU external pixel
>> clocks to DT") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> Confirmed by schematics, user manual, and physical inspection of 2
>> Koelsch instances (my scope has not enough bandwidth to measure the
>> actual frequency).
>
> Stupid question, have you tested the corresponding (HDMI) DU output ? If so,
No I haven't.
Niklas, can you please fire up your display? Thanks!
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input
2017-04-04 10:31 ` Geert Uytterhoeven
@ 2017-04-04 11:10 ` Niklas Söderlund
0 siblings, 0 replies; 5+ messages in thread
From: Niklas Söderlund @ 2017-04-04 11:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Geert,
On 2017-04-04 12:31:39 +0200, Geert Uytterhoeven wrote:
> Hi Laurent,
>
> On Tue, Apr 4, 2017 at 12:05 PM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
> > On Monday 03 Apr 2017 11:55:19 Geert Uytterhoeven wrote:
> >> The X2 crystal oscillator on the Koelsch development board provides a
> >> 74.25 MHz clock, not a 148.5 MHz clock.
> >>
> >> Fixes: cd21cb46e14aae3a ("ARM: shmobile: koelsch: Add DU external pixel
> >> clocks to DT") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> ---
> >> Confirmed by schematics, user manual, and physical inspection of 2
> >> Koelsch instances (my scope has not enough bandwidth to measure the
> >> actual frequency).
> >
> > Stupid question, have you tested the corresponding (HDMI) DU output ? If so,
>
> No I haven't.
>
> Niklas, can you please fire up your display? Thanks!
Console during boot works and
modetest -M rcar-du -s 46:1920x1080-60Hz
modetest -M rcar-du -s 46:1280x720-60Hz
modetest -M rcar-du -s 46:720x480-60Hz
Produce stable test patterns.
Tested-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>
>
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks ;-)
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas S?derlund
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-04 11:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-03 9:55 [PATCH] ARM: dts: koelsch: Correct clock frequency of X2 DU clock input Geert Uytterhoeven
2017-04-03 10:35 ` Simon Horman
2017-04-04 10:05 ` Laurent Pinchart
2017-04-04 10:31 ` Geert Uytterhoeven
2017-04-04 11:10 ` Niklas Söderlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).