From: dwmw2@infradead.org (David Woodhouse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel
Date: Thu, 13 Apr 2017 13:15:54 +0100 [thread overview]
Message-ID: <1492085754.20068.2.camel@infradead.org> (raw)
In-Reply-To: <20170404092604.GB14898@arm.com>
On Tue, 2017-04-04 at 10:26 +0100, Will Deacon wrote:
> ?A
> patch making arm64 consistent could be discussed separately, otherwise kdump
> becomes the pedantic ISO guy trying to lead by example, but really everybody
> ignores him because it's completely inconsequential and they also know he
> went 35 versions without giving a monkey's.
I still don't see the logic there for *wanting* kdump to be wrong.
Sure, kdump getting it right doesn't necessarily make a big difference
in?itself.
But given that the error has been pointed out, what is the motivation
for *wanting* the error to remain in the kdump code, instead of just
fixing it? "Consistency" isn't an answer because we are *already*
inconsistent ? some code gets it right, and other code doesn't.
We should converge towards *correctness* rather than deliberately
adding more incorrect code.
I've used my 'i' key more times just in?typing this email than it would
have taken to just fix the problem the first time it was pointed out.
> David, since you seem to be the most outraged, fancy sending a patch? ;)
Coming up. In two parts ? user-visible messages, followed by cosmetic
and less relevant stuff.
--
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4938 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170413/3273313d/attachment.bin>
next prev parent reply other threads:[~2017-04-13 12:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 6:48 [PATCH v34 00/14] arm64: add kdump support AKASHI Takahiro
2017-03-28 6:50 ` [PATCH v34 01/14] memblock: add memblock_clear_nomap() AKASHI Takahiro
2017-03-28 9:47 ` Ard Biesheuvel
2017-03-28 6:50 ` [PATCH v34 02/14] memblock: add memblock_cap_memory_range() AKASHI Takahiro
2017-03-28 9:48 ` Ard Biesheuvel
2017-03-28 6:51 ` [PATCH v34 03/14] arm64: limit memory regions based on DT property, usable-memory-range AKASHI Takahiro
2017-03-28 9:50 ` Ard Biesheuvel
2017-03-28 6:51 ` [PATCH v34 04/14] arm64: kdump: reserve memory for crash dump kernel AKASHI Takahiro
2017-03-28 9:52 ` Ard Biesheuvel
2017-04-03 8:18 ` David Woodhouse
2017-04-04 5:41 ` AKASHI Takahiro
2017-04-04 6:14 ` David Woodhouse
2017-04-04 7:35 ` AKASHI Takahiro
2017-04-04 7:39 ` Ard Biesheuvel
2017-04-04 7:44 ` David Woodhouse
2017-04-04 9:26 ` Will Deacon
2017-04-13 12:15 ` David Woodhouse [this message]
2017-04-13 12:17 ` [PATCH 1/2] arm64: Fix power-of-ten vs. power-of-two prefixes in user-visible messages David Woodhouse
2017-04-19 9:29 ` Geert Uytterhoeven
2017-04-13 12:18 ` [PATCH 2/2] arm64: Fix power-of-ten vs. power-of-two prefixes in comments etc David Woodhouse
2017-04-16 23:12 ` Simon Horman
2017-04-17 11:54 ` Geert Uytterhoeven
2017-04-18 14:13 ` Catalin Marinas
2017-04-19 14:25 ` Olof Johansson
2017-03-28 6:51 ` [PATCH v34 05/14] arm64: mm: add set_memory_valid() AKASHI Takahiro
2017-03-28 9:54 ` Ard Biesheuvel
2017-03-28 6:51 ` [PATCH v34 06/14] arm64: kdump: protect crash dump kernel memory AKASHI Takahiro
2017-03-28 10:07 ` Ard Biesheuvel
2017-03-28 11:07 ` AKASHI Takahiro
2017-03-28 14:05 ` Ard Biesheuvel
2017-03-30 9:56 ` AKASHI Takahiro
2017-03-30 13:58 ` Ard Biesheuvel
2017-04-03 2:28 ` AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 07/14] arm64: hibernate: preserve kdump image around hibernation AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 08/14] arm64: kdump: implement machine_crash_shutdown() AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 09/14] arm64: kdump: add VMCOREINFO's for user-space tools AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 10/14] arm64: kdump: provide /proc/vmcore file AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 11/14] arm64: kdump: enable kdump in defconfig AKASHI Takahiro
2017-03-28 6:51 ` [PATCH v34 12/14] Documentation: kdump: describe arm64 port AKASHI Takahiro
2017-03-28 6:52 ` [PATCH v34 13/14] Documentation: dt: chosen properties for arm64 kdump AKASHI Takahiro
2017-03-28 6:53 ` [PATCH v34 14/14] efi/libstub/arm*: Set default address and size cells values for an empty dtb AKASHI Takahiro
2017-03-28 10:08 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492085754.20068.2.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).