linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: eric.auger@redhat.com (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 01/22] KVM: arm/arm64: Add ITS save/restore API documentation
Date: Fri, 14 Apr 2017 12:15:13 +0200	[thread overview]
Message-ID: <1492164934-988-2-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1492164934-988-1-git-send-email-eric.auger@redhat.com>

Add description for how to access ITS registers and how to save/restore
ITS tables into/from memory.

Signed-off-by: Eric Auger <eric.auger@redhat.com>

---
v4 -> v5:
- take into account Christoffer's comments
- pending table save on GICV3 side now

v3 -> v4:
- take into account Peter's comments:
  - typos
  - KVM_DEV_ARM_VGIC_GRP_ITS_TABLES kvm_device_attr = 0
  - add a validity bit in DTE
  - document all fields in CTE and ITE
  - document ABI revision
- take into account Andre's comments:
  - document restrictions about GITS_CREADR writing and GITS_IIDR
  - document -EBUSY error if one or more VCPUS are runnning
  - document 64b registers only can be accessed with 64b access
- itt_addr field matches bits [51:8] of the itt_addr

v1 -> v2:
- DTE and ITE now are 8 bytes
- DTE and ITE now indexed by deviceid/eventid
- use ITE name instead of ITTE
- mentions ITT_addr matches bits [51:8] of the actual address
- mentions LE layout
---
 Documentation/virtual/kvm/devices/arm-vgic-its.txt | 99 ++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/Documentation/virtual/kvm/devices/arm-vgic-its.txt b/Documentation/virtual/kvm/devices/arm-vgic-its.txt
index 6081a5b..b5f010d 100644
--- a/Documentation/virtual/kvm/devices/arm-vgic-its.txt
+++ b/Documentation/virtual/kvm/devices/arm-vgic-its.txt
@@ -32,7 +32,106 @@ Groups:
     KVM_DEV_ARM_VGIC_CTRL_INIT
       request the initialization of the ITS, no additional parameter in
       kvm_device_attr.addr.
+
+    KVM_DEV_ARM_ITS_SAVE_TABLES
+      save the ITS table data into guest RAM, at the location provisioned
+      by the guest in corresponding registers/table entries.
+
+      The layout of the tables in guest memory defines an ABI. The entries
+      are laid out in little endian format as described in the last paragraph.
+
+    KVM_DEV_ARM_ITS_RESTORE_TABLES
+      restore the ITS tables from guest RAM to ITS internal structures.
+
+      The GICV3 must be restored before the ITS and all ITS registers but
+      the GITS_CTLR must be restored before restoring the ITS tables.
+
+      The GITS_IIDR read-only register must also be restored before
+      the table restore as the IIDR revision field encodes the ABI revision.
+
   Errors:
     -ENXIO:  ITS not properly configured as required prior to setting
              this attribute
     -ENOMEM: Memory shortage when allocating ITS internal data
+    -EINVAL: Inconsistent restored data
+    -EFAULT: Invalid guest ram access
+    -EBUSY:  One or more VCPUS are running
+
+  KVM_DEV_ARM_VGIC_GRP_ITS_REGS
+  Attributes:
+      The attr field of kvm_device_attr encodes the offset of the
+      ITS register, relative to the ITS control frame base address
+      (ITS_base).
+
+      kvm_device_attr.addr points to a __u64 value whatever the width
+      of the addressed register (32/64 bits). 64 bit registers can only
+      be accessed with full length.
+
+      Writes to read-only registers are ignored by the kernel except for:
+      - GITS_READR. It needs to be restored otherwise commands in the queue
+        will be re-executed after restoring CWRITER. GITS_READR must be restored
+        before restoring the GITS_CTLR which is likely to enable the ITS.
+        Also it needs to be restored after GITS_CBASER since a write to
+        GITS_CBASER resets GITS_CREADR.
+      - GITS_IIDR. Its Revision field encodes the table layout ABI revision.
+        In the future we might implement direct injection of virtual LPIS.
+        This will require an upgrade of the table layout and an evolution of
+        the ABI. GITS_IIDR must be restored before the table restoration.
+
+      For other registers, getting or setting a register has the same
+      effect as reading/writing the register on real hardware.
+  Errors:
+    -ENXIO: Offset does not correspond to any supported register
+    -EFAULT: Invalid user pointer for attr->addr
+    -EINVAL: Offset is not 64-bit aligned
+    -EBUSY: one or more VCPUS are running
+
+ ITS Table ABI REV0:
+ -------------------
+
+ Revision 0 of the ABI only supports physical LPIs.
+
+ The device table and ITT are indexed by the deviceid and eventid,
+ respectively. The collection table is not indexed by collectionid:
+ CTE are written in the table in the order of collection creation. All
+ entries are 8 bytes.
+
+ Device Table Entry (DTE):
+
+ bits:     | 63| 62 ... 49 | 48 ... 5 | 4 ... 0 |
+ values:   | V |   next    | ITT_addr |  Size   |
+
+ where;
+ - V indicates whether the entry is valid. If not, other fields
+   are not meaningful.
+ - next: equals to 0 if this entry is the last one; otherwise it
+   corresponds to the deviceid offset to the next DTE, capped by
+   2^14 -1.
+ - ITT_addr matches bits [51:8] of the ITT address (256B aligned).
+ - Size specifies the supported number of bits for the deviceid,
+   minus one
+
+ Collection Table Entry (CTE):
+
+ bits:     | 63| 62 ..  52  | 51 ... 16 | 15  ...   0 |
+ values:   | V |    RES0    |  RDBase   |    ICID     |
+
+ where:
+ - V indicates whether the entry is valid. If not, other fields are
+   not meaningful.
+ - RES0: reserved field with Should-Be-Zero-or-Preserved behavior.
+ - RDBase is the PE number (GICR_TYPER.Processor_Number semantic),
+ - ICID is the collection ID
+
+ Interrupt Translation Entry (ITE):
+
+ bits:     | 63 ... 48 | 47 ... 16 | 15 ... 0 |
+ values:   |    next   |   pINTID  |  ICID    |
+
+ where:
+ - next: equals to 0 if this entry is the last one; otherwise it corresponds
+   to the eventid offset to the next ITE capped by 2^16 -1.
+ - pINTID is the physical LPI ID; if zero, it means the entry is not valid
+   and other fields are not meaningful.
+ - ICID is the collection ID
+
-- 
2.5.5

  reply	other threads:[~2017-04-14 10:15 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 10:15 [PATCH v5 00/22] vITS save/restore Eric Auger
2017-04-14 10:15 ` Eric Auger [this message]
2017-04-25 10:38   ` [PATCH v5 01/22] KVM: arm/arm64: Add ITS save/restore API documentation Peter Maydell
2017-04-26 12:31   ` Christoffer Dall
2017-04-26 15:48     ` Auger Eric
2017-04-27  8:57       ` Christoffer Dall
2017-04-27  9:33         ` Auger Eric
2017-04-27 11:02           ` Christoffer Dall
2017-04-27 12:51             ` Auger Eric
2017-04-27 14:45               ` Christoffer Dall
2017-04-27 15:29                 ` Auger Eric
2017-04-27 16:23                   ` Marc Zyngier
2017-04-27 17:14                     ` Auger Eric
2017-04-27 17:27                       ` Christoffer Dall
2017-04-27 16:38                   ` Christoffer Dall
2017-04-27 17:27                     ` Auger Eric
2017-04-27 17:54                       ` Christoffer Dall
2017-04-27 19:27                         ` Auger Eric
2017-05-04  7:00                 ` Auger Eric
2017-05-04  7:40                   ` Marc Zyngier
2017-05-04  7:54                     ` Auger Eric
2017-05-04  7:46                   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 02/22] KVM: arm/arm64: Add GICV3 pending table save " Eric Auger
2017-04-25 10:43   ` Peter Maydell
2017-04-26  8:26     ` Auger Eric
2017-04-26  8:44       ` Peter Maydell
2017-04-26  8:48         ` Dr. David Alan Gilbert
2017-04-26  9:57           ` Auger Eric
2017-04-26 13:00             ` Christoffer Dall
2017-04-26 13:01               ` Peter Maydell
2017-04-26 13:14                 ` Christoffer Dall
2017-04-26 13:26                   ` Peter Maydell
2017-04-26 14:47                     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 03/22] KVM: arm/arm64: vgic-its: rename itte into ite Eric Auger
2017-04-26 11:21   ` Prakash B
2017-04-27  9:05   ` Christoffer Dall
2017-04-27  9:20     ` Andre Przywara
2017-04-27  9:40       ` Auger Eric
2017-04-27 11:09         ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 04/22] arm/arm64: vgic: turn vgic_find_mmio_region into public Eric Auger
2017-04-26 11:22   ` Prakash B
2017-04-27  9:07   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 05/22] KVM: arm64: vgic-its: KVM_DEV_ARM_VGIC_GRP_ITS_REGS group Eric Auger
2017-04-26 11:23   ` Prakash B
2017-04-27  9:12   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 06/22] KVM: arm/arm64: vgic: expose (un)lock_all_vcpus Eric Auger
2017-04-26 11:23   ` Prakash B
2017-04-27  9:18   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 07/22] KVM: arm64: vgic-its: Implement vgic_its_has_attr_regs and attr_regs_access Eric Auger
2017-04-26 11:24   ` Prakash B
2017-04-27 11:00   ` Christoffer Dall
2017-04-27 12:22     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 08/22] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_creadr Eric Auger
2017-04-26 11:24   ` Prakash B
2017-04-27 11:27   ` Christoffer Dall
2017-04-27 12:53     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 09/22] KVM: arm64: vgic-its: Introduce migration ABI infrastructure Eric Auger
2017-04-26 11:27   ` Prakash B
2017-04-27 13:14   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 10/22] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_iidr Eric Auger
2017-04-26 11:27   ` Prakash B
2017-04-27 14:57   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 11/22] KVM: arm64: vgic-its: Interpret MAPD Size field and check related errors Eric Auger
2017-04-26 11:28   ` Prakash B
2017-04-27 16:25   ` Christoffer Dall
2017-04-27 17:15     ` Auger Eric
2017-04-27 17:28       ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 12/22] KVM: arm64: vgic-its: Interpret MAPD ITT_addr field Eric Auger
2017-04-26 11:29   ` Prakash B
2017-04-27 16:43   ` Christoffer Dall
2017-04-27 17:44     ` Auger Eric
2017-04-27 18:09       ` Christoffer Dall
2017-04-27 19:18         ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 13/22] KVM: arm64: vgic-its: Check the device id matches TYPER DEVBITS range Eric Auger
2017-04-26 11:29   ` Prakash B
2017-04-27 16:48   ` Christoffer Dall
2017-04-27 17:24     ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 14/22] KVM: arm64: vgic-its: KVM_DEV_ARM_ITS_SAVE/RESTORE_TABLES Eric Auger
2017-04-26 11:31   ` Prakash B
2017-04-27 17:24   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 15/22] KVM: arm64: vgic-its: vgic_its_alloc_ite/device Eric Auger
2017-04-26 11:31   ` Prakash B
2017-04-27 17:31   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 16/22] KVM: arm64: vgic-its: Add infrastructure for table lookup Eric Auger
2017-04-26 11:32   ` Prakash B
2017-04-27 18:06   ` Christoffer Dall
2017-04-27 19:24     ` Auger Eric
2017-04-28  9:47       ` Christoffer Dall
2017-04-30 19:33   ` Christoffer Dall
2017-05-03 13:40     ` Auger Eric
2017-05-03 14:38       ` Christoffer Dall
2017-04-30 19:35   ` Christoffer Dall
2017-05-03  6:53     ` Auger Eric
2017-05-03  8:01       ` Christoffer Dall
2017-05-03 10:22         ` Auger Eric
2017-04-30 20:13   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 17/22] KVM: arm64: vgic-its: Collection table save/restore Eric Auger
2017-04-26 11:33   ` Prakash B
2017-04-28 10:44   ` Christoffer Dall
2017-04-28 11:05     ` Auger Eric
2017-04-28 17:42       ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 18/22] KVM: arm64: vgic-its: vgic_its_check_id returns the entry's GPA Eric Auger
2017-04-26 11:33   ` Prakash B
2017-05-02  8:29   ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 19/22] KVM: arm64: vgic-its: ITT save and restore Eric Auger
2017-04-26 11:34   ` Prakash B
2017-04-30 20:14   ` Christoffer Dall
2017-05-03 16:08     ` Auger Eric
2017-05-03 16:37       ` Christoffer Dall
2017-05-03 21:55         ` Auger Eric
2017-05-04  7:31           ` Christoffer Dall
2017-05-04  7:40             ` Auger Eric
2017-05-04  8:23               ` Christoffer Dall
2017-05-04  8:44                 ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 20/22] KVM: arm64: vgic-its: Device table save/restore Eric Auger
2017-04-26 11:34   ` Prakash B
2017-04-30 20:55   ` Christoffer Dall
2017-05-03 14:07     ` Auger Eric
2017-05-03 15:29       ` Christoffer Dall
2017-05-03 21:38         ` Auger Eric
2017-04-14 10:15 ` [PATCH v5 21/22] KVM: arm64: vgic-its: Fix pending table sync Eric Auger
2017-04-26 11:35   ` Prakash B
2017-04-30 21:10   ` Christoffer Dall
2017-05-03 22:20     ` Auger Eric
2017-05-04  7:32       ` Christoffer Dall
2017-04-14 10:15 ` [PATCH v5 22/22] KVM: arm64: vgic-v3: KVM_DEV_ARM_VGIC_SAVE_PENDING_TABLES Eric Auger
2017-04-26 11:35   ` Prakash B
2017-04-30 21:32   ` Christoffer Dall
2017-05-03 22:22     ` Auger Eric
2017-04-26 11:38 ` [PATCH v5 00/22] vITS save/restore Prakash B
2017-04-26 13:02   ` Christoffer Dall
2017-04-27  6:55   ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492164934-988-2-git-send-email-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).