From mboxrd@z Thu Jan 1 00:00:00 1970 From: andriy.shevchenko@linux.intel.com (Andy Shevchenko) Date: Tue, 18 Apr 2017 10:54:47 +0300 Subject: [PATCH] i2c: designware: do not show SDA hold time warning when not needed In-Reply-To: <1492203192-28025-1-git-send-email-thomas.petazzoni@free-electrons.com> References: <1492203192-28025-1-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <1492502087.24567.47.camel@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2017-04-14 at 22:53 +0200, Thomas Petazzoni wrote: > When the I2C controller IP block has a revision too old to be able to > configure the SDA hold time, the driver currently displays a > warning. However, it does so unconditionally, even if no SDA hold time > has been configured through the Device Tree. This causes useless > warnings when running the system, so only show the warning if a SDA > hold time was specified. As far as I understand the warning it would be better to keep it in either way, though you may shift it to debug level. Wolfram, Jarkko, thoughts? > > Signed-off-by: Thomas Petazzoni > --- > ?drivers/i2c/busses/i2c-designware-core.c | 5 +++-- > ?1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-designware-core.c > b/drivers/i2c/busses/i2c-designware-core.c > index 7a3faa5..7f9da6e 100644 > --- a/drivers/i2c/busses/i2c-designware-core.c > +++ b/drivers/i2c/busses/i2c-designware-core.c > @@ -436,8 +436,9 @@ int i2c_dw_init(struct dw_i2c_dev *dev) > ? dev->sda_hold_time |= 1 << > DW_IC_SDA_HOLD_RX_SHIFT; > ? dw_writel(dev, dev->sda_hold_time, DW_IC_SDA_HOLD); > ? } else { > - dev_warn(dev->dev, > - "Hardware too old to adjust SDA hold > time.\n"); > + if (dev->sda_hold_time) > + dev_warn(dev->dev, > + ?"Hardware too old to adjust SDA hold > time.\n"); > ? } > ? > ? /* Configure Tx/Rx FIFO threshold levels */ -- Andy Shevchenko Intel Finland Oy