From: rf@opensource.wolfsonmicro.com (Richard Fitzgerald)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] regulator: arizona-micsupp: Make arizona_micsupp independent of struct arizona
Date: Tue, 18 Apr 2017 11:43:50 +0100 [thread overview]
Message-ID: <1492512234-19210-5-git-send-email-rf@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1492512234-19210-1-git-send-email-rf@opensource.wolfsonmicro.com>
In preparation for supporting Madera codecs, remove the dependency on
struct arizona in the regulator callbacks and struct arizona_micsupp.
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
drivers/regulator/arizona-micsupp.c | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/arizona-micsupp.c b/drivers/regulator/arizona-micsupp.c
index 5f8b5a7..db4fecf 100644
--- a/drivers/regulator/arizona-micsupp.c
+++ b/drivers/regulator/arizona-micsupp.c
@@ -34,7 +34,10 @@
struct arizona_micsupp {
struct regulator_dev *regulator;
- struct arizona *arizona;
+ struct regmap *regmap;
+ struct snd_soc_dapm_context **dapm;
+ unsigned int enable_reg;
+ struct device *dev;
struct regulator_consumer_supply supply;
struct regulator_init_data init_data;
@@ -46,21 +49,22 @@ static void arizona_micsupp_check_cp(struct work_struct *work)
{
struct arizona_micsupp *micsupp =
container_of(work, struct arizona_micsupp, check_cp_work);
- struct snd_soc_dapm_context *dapm = micsupp->arizona->dapm;
- struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
- struct arizona *arizona = micsupp->arizona;
- struct regmap *regmap = arizona->regmap;
- unsigned int reg;
+ struct snd_soc_dapm_context *dapm = *micsupp->dapm;
+ struct snd_soc_component *component;
+ unsigned int val;
int ret;
- ret = regmap_read(regmap, ARIZONA_MIC_CHARGE_PUMP_1, ®);
+ ret = regmap_read(micsupp->regmap, micsupp->enable_reg, &val);
if (ret != 0) {
- dev_err(arizona->dev, "Failed to read CP state: %d\n", ret);
+ dev_err(micsupp->dev,
+ "Failed to read CP state: %d\n", ret);
return;
}
if (dapm) {
- if ((reg & (ARIZONA_CPMIC_ENA | ARIZONA_CPMIC_BYPASS)) ==
+ component = snd_soc_dapm_to_component(dapm);
+
+ if ((val & (ARIZONA_CPMIC_ENA | ARIZONA_CPMIC_BYPASS)) ==
ARIZONA_CPMIC_ENA)
snd_soc_component_force_enable_pin(component,
"MICSUPP");
@@ -240,7 +244,9 @@ static int arizona_micsupp_probe(struct platform_device *pdev)
if (!micsupp)
return -ENOMEM;
- micsupp->arizona = arizona;
+ micsupp->regmap = arizona->regmap;
+ micsupp->dapm = &arizona->dapm;
+ micsupp->dev = arizona->dev;
INIT_WORK(&micsupp->check_cp_work, arizona_micsupp_check_cp);
/*
@@ -263,6 +269,7 @@ static int arizona_micsupp_probe(struct platform_device *pdev)
micsupp->init_data.consumer_supplies = &micsupp->supply;
micsupp->supply.supply = "MICVDD";
micsupp->supply.dev_name = dev_name(arizona->dev);
+ micsupp->enable_reg = desc->enable_reg;
config.dev = arizona->dev;
config.driver_data = micsupp;
--
1.9.1
next prev parent reply other threads:[~2017-04-18 10:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 10:43 [PATCH 0/7] regulator: arizona: Prepare for sharing with Madera codecs Richard Fitzgerald
2017-04-18 10:43 ` Richard Fitzgerald
2017-04-18 10:43 ` [PATCH 1/7] regulator: arizona: Split KConfig options for LDO1 and MICSUPP regulators Richard Fitzgerald
2017-04-25 15:46 ` Applied "regulator: arizona: Split KConfig options for LDO1 and MICSUPP regulators" to the regulator tree Mark Brown
2017-04-18 10:43 ` [PATCH 2/7] regulator: arizona-micsupp: Move pdata into a separate structure Richard Fitzgerald
2017-04-24 11:50 ` Lee Jones
2017-04-25 15:46 ` Applied "regulator: arizona-micsupp: Move pdata into a separate structure" to the regulator tree Mark Brown
2017-04-18 10:43 ` Richard Fitzgerald [this message]
2017-04-25 15:46 ` Applied "regulator: arizona-micsupp: Make arizona_micsupp independent of struct arizona" " Mark Brown
2017-04-18 10:43 ` [PATCH 4/7] regulator: arizona-micsupp: Factor out generic initialization Richard Fitzgerald
2017-04-25 15:46 ` Applied "regulator: arizona-micsupp: Factor out generic initialization" to the regulator tree Mark Brown
2017-04-18 10:43 ` [PATCH 5/7] regulator: arizona-ldo1: Move pdata into a separate structure Richard Fitzgerald
2017-04-18 14:52 ` Krzysztof Kozlowski
2017-04-24 11:50 ` Lee Jones
2017-04-25 15:46 ` Applied "regulator: arizona-ldo1: Move pdata into a separate structure" to the regulator tree Mark Brown
2017-04-18 10:43 ` [PATCH 6/7] regulator: arizona-ldo1: Make arizona_ldo1 independent of struct arizona Richard Fitzgerald
2017-04-25 15:46 ` Applied "regulator: arizona-ldo1: Make arizona_ldo1 independent of struct arizona" to the regulator tree Mark Brown
2017-04-18 10:43 ` [PATCH 7/7] regulator: arizona-ldo1: Factor out generic initialization Richard Fitzgerald
2017-04-25 15:45 ` Applied "regulator: arizona-ldo1: Factor out generic initialization" to the regulator tree Mark Brown
2017-04-18 19:49 ` [PATCH 0/7] regulator: arizona: Prepare for sharing with Madera codecs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492512234-19210-5-git-send-email-rf@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).