linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bart.VanAssche@sandisk.com (Bart Van Assche)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix rd_size declaration
Date: Tue, 18 Apr 2017 14:07:53 +0000	[thread overview]
Message-ID: <1492524472.2628.3.camel@sandisk.com> (raw)
In-Reply-To: <20170418073526.GA6056@linux-x5ow.site>

On Tue, 2017-04-18 at 09:35 +0200, Johannes Thumshirn wrote:
> On Mon, Apr 17, 2017 at 04:10:03PM -0700, Bart Van Assche wrote:
> > The global variable 'rd_size' is declared as 'int' in source file
> > arch/arm/kernel/atags_parse.c and as 'unsigned long' in
> > drivers/block/brd.c. Fix this inconsistency.
> > 
> > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> > Cc: Russell King <linux@armlinux.org.uk>
> > Cc: Jens Axboe <axboe@kernel.dk>
> > Cc: Jan Kara <jack@suse.cz>
> > Cc: <yanaijie@huawei.com>
> > Cc: <zhaohongjiang@huawei.com>
> > Cc: <miaoxie@huawei.com>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-block at vger.kernel.org
> > ---
> > diff --git a/include/linux/brd.h b/include/linux/brd.h
> > new file mode 100644
> > index 000000000000..dbb0f92fefc8
> > --- /dev/null
> > +++ b/include/linux/brd.h
> > @@ -0,0 +1 @@
> > +extern unsigned long rd_size;
> 
> Small nit, can you add an include guard here as well?

Hello Johannes,

Thanks for the review. But are you aware that with the current content an
include guard is overkill because it is safe to evaluate the "extern unsigned
long rd_size" declaration multiple times?

Bart.

  reply	other threads:[~2017-04-18 14:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 23:10 [PATCH] ARM: Fix rd_size declaration Bart Van Assche
2017-04-18  7:35 ` Johannes Thumshirn
2017-04-18 14:07   ` Bart Van Assche [this message]
2017-04-18 14:10     ` Johannes Thumshirn
2017-04-26 20:51 ` Bart Van Assche
2017-05-03 19:25   ` Russell King - ARM Linux
2017-05-03 19:38     ` Bart Van Assche
  -- strict thread matches above, loose matches on Subject: below --
2017-05-03 19:46 Bart Van Assche
2017-05-03 19:48 ` Bart Van Assche
2017-06-21 20:26 ` Bart Van Assche
2017-06-26  9:38   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492524472.2628.3.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).