From: ryder.lee@mediatek.com (Ryder Lee)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: mediatek: add I2C dependency for CS42XX8
Date: Fri, 21 Apr 2017 10:10:38 +0800 [thread overview]
Message-ID: <1492740638.23218.0.camel@mtkswgap22> (raw)
In-Reply-To: <20170420081541.658178-1-arnd@arndb.de>
On Thu, 2017-04-20 at 10:15 +0200, Arnd Bergmann wrote:
> We should not select drivers that depend on I2C when that is disabled,
> as it results in a build error:
>
> warning: (SND_SOC_MT2701_WM8960) selects SND_SOC_WM8960 which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && I2C)
> sound/soc/codecs/wm8960.c:1469:1: error: data definition has no type or storage class [-Werror]
> sound/soc/codecs/wm8960.c:1469:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
>
> Fixes: 8625c1dbd876 ("ASoC: mediatek: Add mt2701-wm8960 machine driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/mediatek/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
> index c6f39040f71f..5c68797f36c4 100644
> --- a/sound/soc/mediatek/Kconfig
> +++ b/sound/soc/mediatek/Kconfig
> @@ -24,7 +24,7 @@ config SND_SOC_MT2701_CS42448
>
> config SND_SOC_MT2701_WM8960
> tristate "ASoc Audio driver for MT2701 with WM8960 codec"
> - depends on SND_SOC_MT2701
> + depends on SND_SOC_MT2701 && I2C
> select SND_SOC_WM8960
> help
> This adds ASoC driver for Mediatek MT2701 boards
Acked-by: Ryder Lee <ryder.lee@mediatek.com>
Thanks
next prev parent reply other threads:[~2017-04-21 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 8:15 [PATCH] ASoC: mediatek: add I2C dependency for CS42XX8 Arnd Bergmann
2017-04-21 2:10 ` Ryder Lee [this message]
2017-04-21 17:28 ` Applied "ASoC: mediatek: add I2C dependency for CS42XX8" to the asoc tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2017-02-21 22:00 [PATCH] ASoC: mediatek: add I2C dependency for CS42XX8 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492740638.23218.0.camel@mtkswgap22 \
--to=ryder.lee@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).