linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] clk: samsung: fix several typos to fix boot on s3c2410
Date: Mon, 23 Jun 2014 23:16:33 +0200	[thread overview]
Message-ID: <1492854.pz7FvnzIM4@diego> (raw)
In-Reply-To: <1403555350-14895-1-git-send-email-anarsoul@gmail.com>

Am Montag, 23. Juni 2014, 23:29:09 schrieb Vasily Khoruzhick:
> There's a several typos in a driver: 2410 instead of S3C2410
> and wrong argument to ARRAY_SIZE(). They prevent s3c2410
> from properly booting.
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

Thanks for catching these.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

> ---
>  drivers/clk/samsung/clk-s3c2410.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-s3c2410.c
> b/drivers/clk/samsung/clk-s3c2410.c index ba07168..bd9a873 100644
> --- a/drivers/clk/samsung/clk-s3c2410.c
> +++ b/drivers/clk/samsung/clk-s3c2410.c
> @@ -378,7 +378,7 @@ void __init s3c2410_common_clk_init(struct device_node
> *np, unsigned long xti_f, if (!np)
>  		s3c2410_common_clk_register_fixed_ext(ctx, xti_f);
> 
> -	if (current_soc == 2410) {
> +	if (current_soc == S3C2410) {
>  		if (_get_rate("xti") == 12 * MHZ) {
>  			s3c2410_plls[mpll].rate_table = pll_s3c2410_12mhz_tbl;
>  			s3c2410_plls[upll].rate_table = pll_s3c2410_12mhz_tbl;
> @@ -432,7 +432,7 @@ void __init s3c2410_common_clk_init(struct device_node
> *np, unsigned long xti_f, samsung_clk_register_fixed_factor(ctx,
> s3c2410_ffactor,
>  				ARRAY_SIZE(s3c2410_ffactor));
>  		samsung_clk_register_alias(ctx, s3c2410_aliases,
> -			ARRAY_SIZE(s3c2410_common_aliases));
> +			ARRAY_SIZE(s3c2410_aliases));
>  		break;
>  	case S3C2440:
>  		samsung_clk_register_mux(ctx, s3c2440_muxes,

  parent reply	other threads:[~2014-06-23 21:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 20:29 [PATCH 1/2] clk: samsung: fix several typos to fix boot on s3c2410 Vasily Khoruzhick
2014-06-23 20:29 ` [PATCH 2/2] clk: samsung: add more aliases for s3c24xx Vasily Khoruzhick
2014-06-23 21:24   ` Heiko Stübner
2014-06-30 13:50   ` Tomasz Figa
2014-06-23 21:16 ` Heiko Stübner [this message]
2014-06-25 11:26 ` [PATCH 1/2] clk: samsung: fix several typos to fix boot on s3c2410 Tomasz Figa
2014-06-30 13:49 ` Tomasz Figa
2014-06-30 14:02   ` Vasily Khoruzhick
2014-06-30 14:07     ` Tomasz Figa
2014-06-30 14:16       ` Vasily Khoruzhick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492854.pz7FvnzIM4@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).