From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: imx6: zii: Add i210 PCIe interface to the device tree
Date: Mon, 24 Apr 2017 10:47:22 +0200 [thread overview]
Message-ID: <1493023642.2891.2.camel@pengutronix.de> (raw)
In-Reply-To: <1492321507-7174-1-git-send-email-cphealy@gmail.com>
Am Samstag, den 15.04.2017, 22:45 -0700 schrieb Chris Healy:
> The board has an Intel i210 Ethernet controller on its PCIe bus. Add a
> device tree node for this.
I wold prefer a better description on why we need this node, as PCIe is
an enumerable bus. Do you need this node to attach a MAC address or
something?
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
>
> This patch is against for-next of Shawn Guo's tree.
>
> Since v1, this version fixes the spacing by using git send-email instead of gmail
> to send the patch.
>
> Thanks,
>
> Chris Healy
> ---
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 5d94b5e..8375c43 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -572,6 +572,18 @@
> pinctrl-0 = <&pinctrl_pcie>;
> reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
> status = "okay";
> +
> + host at 0 {
> + #address-cells = <3>;
> + #size-cells = <2>;
> + reg = <0 0 0 0 0>;
> + device_type = "pci";
> +
> + i210: i210 at 0 {
> + reg = <0 0 0 0 0>;
> + device_type = "pci";
device_type = "pci" is only valid for bridges on the bus, not for
endpoint devices. Please remove.
> + };
> + };
> };
>
> &usdhc2 {
Regards,
Lucas
next prev parent reply other threads:[~2017-04-24 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 5:45 [PATCH v2] arm: imx6: zii: Add i210 PCIe interface to the device tree Chris Healy
2017-04-24 8:47 ` Lucas Stach [this message]
2017-04-24 14:10 ` Andrew Lunn
2017-04-24 14:45 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493023642.2891.2.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).