linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: leonard.crestez@nxp.com (Leonard Crestez)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RFC] ARM: dts: imx6sx-sdb: Drop OPP hackery
Date: Tue, 25 Apr 2017 22:39:54 +0300	[thread overview]
Message-ID: <1493149194.20997.3.camel@nxp.com> (raw)
In-Reply-To: <a75000d6-aa53-92e3-c43a-58b49f18ff7e@denx.de>

On Tue, 2017-04-25 at 21:30 +0200, Marek Vasut wrote:
> On 04/25/2017 06:42 PM, Marek Vasut wrote:
> > The imx6sx-sdb has one power supply that drives both VDDARM_IN
> > and VDDSOC_IN, which is the sw1a regulator on the PFUZE PMIC.
> > Connect both inputs to the sw1a regulator on the PMIC and drop
> > the OPP hackery which is no longer needed as the power framework
> > will take care of the regulator configuration as needed.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> 
> +CC Leonard

Tested-by: Leonard Crestez <leonard.crestez@nxp.com>

The OPP hack only applies to LDO bypass mode and that is not in
upstream. When LDOs are enabled the effect is to use higher voltages
than necessary for no good reason.

Setting these higher voltages can make some boards (for example Rev B)
fail to boot with ugly semi-random crashes reminiscent of memory
corruption. These failures happen the first time the lowest idle state
is used. This patch fixes those crashes.

It's not clear exactly why the crashes happen. Perhaps waking up from
idle draws more power than is available? I don't think it matters.

I sent a very similar patch a few minutes after this one:

http://lists.infradead.org/pipermail/linux-arm-kernel/2017-April/503241
.html

> > @@ -145,3 +128,11 @@
> >  		reg = <1>;
> >  	};
> >  };
> > +
> > +&reg_arm {
> > +	vin-supply = <&sw1a_reg>;
> > +};
> > +
> > +&reg_soc {
> > +	vin-supply = <&sw1a_reg>;
> > +};

This is also good, it will result in lower voltages will result in
lower voltages on VDD_ARM_SOC_IN rather than a fixed 1375 mV.

-- 
Regards,
Leonard

  reply	other threads:[~2017-04-25 19:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 16:42 [PATCH] [RFC] ARM: dts: imx6sx-sdb: Drop OPP hackery Marek Vasut
2017-04-25 19:30 ` Marek Vasut
2017-04-25 19:39   ` Leonard Crestez [this message]
2017-05-03 13:32     ` Leonard Crestez
2017-05-03 14:27       ` Henri Roosen
2017-05-03 16:07 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493149194.20997.3.camel@nxp.com \
    --to=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).