From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] reset: sti: Use devm_kcalloc() in syscfg_reset_controller_register()
Date: Wed, 26 Apr 2017 11:19:51 +0200 [thread overview]
Message-ID: <1493198391.3653.4.camel@pengutronix.de> (raw)
In-Reply-To: <e10a20a2-cfea-5b42-db3a-41b6eb08d7e4@users.sourceforge.net>
On Wed, 2017-04-26 at 10:05 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 26 Apr 2017 09:50:34 +0200
>
> * A multiplication for the size determination of a memory allocation
> indicated that an array data structure should be processed.
> Thus use the corresponding function "devm_kcalloc".
>
> * Replace the specification of a data structure by a pointer dereference
> to make the corresponding size determination a bit safer according to
> the Linux coding style convention.
>
> * Delete the local variable "size" which became unnecessary with
> this refactoring.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/reset/sti/reset-syscfg.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/reset/sti/reset-syscfg.c b/drivers/reset/sti/reset-syscfg.c
> index 9bd57a5eee72..7e0f2aa55ba7 100644
> --- a/drivers/reset/sti/reset-syscfg.c
> +++ b/drivers/reset/sti/reset-syscfg.c
> @@ -145,16 +145,14 @@ static int syscfg_reset_controller_register(struct device *dev,
> const struct syscfg_reset_controller_data *data)
> {
> struct syscfg_reset_controller *rc;
> - size_t size;
> int i, err;
>
> rc = devm_kzalloc(dev, sizeof(*rc), GFP_KERNEL);
> if (!rc)
> return -ENOMEM;
>
> - size = sizeof(struct syscfg_reset_channel) * data->nr_channels;
> -
> - rc->channels = devm_kzalloc(dev, size, GFP_KERNEL);
> + rc->channels = devm_kcalloc(dev, data->nr_channels,
> + sizeof(*rc->channels), GFP_KERNEL);
> if (!rc->channels)
> return -ENOMEM;
>
Thank you, I have applied this to the reset/next branch. The same change
could be made in the ti-syscon reset driver.
regards
Philipp
next prev parent reply other threads:[~2017-04-26 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 8:05 [PATCH] reset: sti: Use devm_kcalloc() in syscfg_reset_controller_register() SF Markus Elfring
2017-04-26 9:19 ` Philipp Zabel [this message]
2017-04-26 11:00 ` reset: Use devm_kcalloc() in ti_syscon_reset_probe()? SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493198391.3653.4.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).