public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled
@ 2017-05-15 16:33 Guenter Roeck
  2017-05-15 17:25 ` Fabio Estevam
  0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2017-05-15 16:33 UTC (permalink / raw)
  To: linux-arm-kernel

Selecting PM_GENERIC_DOMAINS without PM results in the following build
errors, seen when building sparc32:allmodconfig.

drivers/base/power/domain.c: In function 'genpd_queue_power_off_work':
drivers/base/power/domain.c:279:13: error: 'pm_wq' undeclared
drivers/base/power/domain.c: In function 'genpd_dev_pm_qos_notifier':
drivers/base/power/domain.c:462:25: error:
	'struct dev_pm_info' has no member named 'ignore_children'
drivers/base/power/domain.c: In function 'rtpm_status_str':
drivers/base/power/domain.c:2207:16: error:
	'struct dev_pm_info' has no member named 'runtime_error'
drivers/base/power/domain.c:2209:21: error:
	'struct dev_pm_info' has no member named 'disable_depth'
drivers/base/power/domain.c:2211:21: error:
	'struct dev_pm_info' has no member named 'runtime_status'
drivers/base/power/domain.c:2212:31: error:
	'struct dev_pm_info' has no member named 'runtime_status'

Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/soc/imx/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 357a5d8f8da0..9c1c75f282c2 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -2,7 +2,7 @@ menu "i.MX SoC drivers"
 
 config IMX7_PM_DOMAINS
 	bool "i.MX7 PM domains"
-	select PM_GENERIC_DOMAINS
+	select PM_GENERIC_DOMAINS if PM
 	depends on SOC_IMX7D || (COMPILE_TEST && OF)
 	default y if SOC_IMX7D
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled
  2017-05-15 16:33 [PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled Guenter Roeck
@ 2017-05-15 17:25 ` Fabio Estevam
  0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2017-05-15 17:25 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Guenter,

On Mon, May 15, 2017 at 1:33 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> Selecting PM_GENERIC_DOMAINS without PM results in the following build
> errors, seen when building sparc32:allmodconfig.
>
> drivers/base/power/domain.c: In function 'genpd_queue_power_off_work':
> drivers/base/power/domain.c:279:13: error: 'pm_wq' undeclared
> drivers/base/power/domain.c: In function 'genpd_dev_pm_qos_notifier':
> drivers/base/power/domain.c:462:25: error:
>         'struct dev_pm_info' has no member named 'ignore_children'
> drivers/base/power/domain.c: In function 'rtpm_status_str':
> drivers/base/power/domain.c:2207:16: error:
>         'struct dev_pm_info' has no member named 'runtime_error'
> drivers/base/power/domain.c:2209:21: error:
>         'struct dev_pm_info' has no member named 'disable_depth'
> drivers/base/power/domain.c:2211:21: error:
>         'struct dev_pm_info' has no member named 'runtime_status'
> drivers/base/power/domain.c:2212:31: error:
>         'struct dev_pm_info' has no member named 'runtime_status'
>
> Fixes: 03aa12629fc4 ("soc: imx: Add GPCv2 power gating driver")
> Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

This patch from Arnd should fix it:
https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/commit/?h=imx/fixes&id=e23c7f7d57831fdae444be9d507e67716ab601d4

This one should land in linux-next tomorrow.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-15 17:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-15 16:33 [PATCH] soc: imx: Select PM_GENERIC_DOMAINS only if PM is enabled Guenter Roeck
2017-05-15 17:25 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox