public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake
Date: Mon, 22 May 2017 14:07:16 +0800	[thread overview]
Message-ID: <1495433236.20811.13.camel@mtksdaap41> (raw)
In-Reply-To: <1490084823-3968-1-git-send-email-nickey.yang@rock-chips.com>

Hi, Nickey:

Sorry for the late reply. I've applied this patch to my branch
mediatek-drm-fixes-4.12-rc1.

Regards,
CK

On Tue, 2017-03-21 at 16:27 +0800, Nickey Yang wrote:
> mtk_hdmi_setup_vendor_specific_infoframe will return before handle
> mtk_hdmi_hw_send_info_frame.Because hdmi_vendor_infoframe_pack
> returns the number of bytes packed into the binary buffer or
> a negative error code on failure.
> So correct it.
> 
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index c262512..b43aa29 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1062,7 +1062,7 @@ static int mtk_hdmi_setup_vendor_specific_infoframe(struct mtk_hdmi *hdmi,
>  	}
>  
>  	err = hdmi_vendor_infoframe_pack(&frame, buffer, sizeof(buffer));
> -	if (err) {
> +	if (err < 0) {
>  		dev_err(hdmi->dev, "Failed to pack vendor infoframe: %zd\n",
>  			err);
>  		return err;

      reply	other threads:[~2017-05-22  6:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  8:27 [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake Nickey Yang
2017-05-22  6:07 ` CK Hu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495433236.20811.13.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox