* [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake
@ 2017-03-21 8:27 Nickey Yang
2017-05-22 6:07 ` CK Hu
0 siblings, 1 reply; 2+ messages in thread
From: Nickey Yang @ 2017-03-21 8:27 UTC (permalink / raw)
To: linux-arm-kernel
mtk_hdmi_setup_vendor_specific_infoframe will return before handle
mtk_hdmi_hw_send_info_frame.Because hdmi_vendor_infoframe_pack
returns the number of bytes packed into the binary buffer or
a negative error code on failure.
So correct it.
Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
---
drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
index c262512..b43aa29 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
@@ -1062,7 +1062,7 @@ static int mtk_hdmi_setup_vendor_specific_infoframe(struct mtk_hdmi *hdmi,
}
err = hdmi_vendor_infoframe_pack(&frame, buffer, sizeof(buffer));
- if (err) {
+ if (err < 0) {
dev_err(hdmi->dev, "Failed to pack vendor infoframe: %zd\n",
err);
return err;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake
2017-03-21 8:27 [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake Nickey Yang
@ 2017-05-22 6:07 ` CK Hu
0 siblings, 0 replies; 2+ messages in thread
From: CK Hu @ 2017-05-22 6:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi, Nickey:
Sorry for the late reply. I've applied this patch to my branch
mediatek-drm-fixes-4.12-rc1.
Regards,
CK
On Tue, 2017-03-21 at 16:27 +0800, Nickey Yang wrote:
> mtk_hdmi_setup_vendor_specific_infoframe will return before handle
> mtk_hdmi_hw_send_info_frame.Because hdmi_vendor_infoframe_pack
> returns the number of bytes packed into the binary buffer or
> a negative error code on failure.
> So correct it.
>
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index c262512..b43aa29 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1062,7 +1062,7 @@ static int mtk_hdmi_setup_vendor_specific_infoframe(struct mtk_hdmi *hdmi,
> }
>
> err = hdmi_vendor_infoframe_pack(&frame, buffer, sizeof(buffer));
> - if (err) {
> + if (err < 0) {
> dev_err(hdmi->dev, "Failed to pack vendor infoframe: %zd\n",
> err);
> return err;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-22 6:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-21 8:27 [PATCH] drm/mediatek: fix mtk_hdmi_setup_vendor_specific_infoframe mistake Nickey Yang
2017-05-22 6:07 ` CK Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox