From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v3 2/4] arm64: fpsimd: Consistently use __this_cpu_ ops where appropriate
Date: Thu, 25 May 2017 19:24:59 +0100 [thread overview]
Message-ID: <1495736721-20985-3-git-send-email-Dave.Martin@arm.com> (raw)
In-Reply-To: <1495736721-20985-1-git-send-email-Dave.Martin@arm.com>
__this_cpu_ ops are not used consistently with regard to this_cpu_
ops in a couple of places in fpsimd.c.
Since preemption is explicitly disabled in
fpsimd_restore_current_state() and fpsimd_update_current_state(),
this patch converts this_cpu_ ops in those functions to __this_cpu_
ops. This doesn't save cost on arm64, but benefits from additional
assertions in the core code.
Signed-off-by: Dave Martin <Dave.Martin@arm.com>
---
arch/arm64/kernel/fpsimd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
index 06da8ea..d7e5f8a 100644
--- a/arch/arm64/kernel/fpsimd.c
+++ b/arch/arm64/kernel/fpsimd.c
@@ -194,7 +194,7 @@ void fpsimd_restore_current_state(void)
struct fpsimd_state *st = ¤t->thread.fpsimd_state;
fpsimd_load_state(st);
- this_cpu_write(fpsimd_last_state, st);
+ __this_cpu_write(fpsimd_last_state, st);
st->cpu = smp_processor_id();
}
preempt_enable();
@@ -214,7 +214,7 @@ void fpsimd_update_current_state(struct fpsimd_state *state)
if (test_and_clear_thread_flag(TIF_FOREIGN_FPSTATE)) {
struct fpsimd_state *st = ¤t->thread.fpsimd_state;
- this_cpu_write(fpsimd_last_state, st);
+ __this_cpu_write(fpsimd_last_state, st);
st->cpu = smp_processor_id();
}
preempt_enable();
--
2.1.4
next prev parent reply other threads:[~2017-05-25 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 18:24 [RFC PATCH v3 0/4] Simplify kernel-mode NEON Dave Martin
2017-05-25 18:24 ` [RFC PATCH v3 1/4] arm64: neon: Add missing header guard in <asm/neon.h> Dave Martin
2017-05-31 11:41 ` Ard Biesheuvel
2017-05-25 18:24 ` Dave Martin [this message]
2017-05-31 11:43 ` [RFC PATCH v3 2/4] arm64: fpsimd: Consistently use __this_cpu_ ops where appropriate Ard Biesheuvel
2017-05-25 18:25 ` [RFC PATCH v3 3/4] arm64: neon: Remove support for nested or hardirq kernel-mode NEON Dave Martin
2017-05-31 11:51 ` Ard Biesheuvel
2017-05-25 18:25 ` [RFC PATCH v3 4/4] arm64: neon: Add backwards compatibility kernel_neon_begin_partial() Dave Martin
2017-05-30 18:02 ` [RFC PATCH v3 0/4] Simplify kernel-mode NEON Dave Martin
2017-05-31 8:41 ` Ard Biesheuvel
2017-05-31 10:08 ` Dave Martin
2017-05-31 11:07 ` Ard Biesheuvel
2017-05-31 11:33 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1495736721-20985-3-git-send-email-Dave.Martin@arm.com \
--to=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).