public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: leilk.liu@mediatek.com (lei liu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] spi: mediatek: support adjust register define
Date: Thu, 8 Jun 2017 09:41:03 +0800	[thread overview]
Message-ID: <1496886063.30249.1.camel@mhfsdcap03> (raw)
In-Reply-To: <20170606185730.mrvgvp4hynftwahx@sirena.org.uk>

On Tue, 2017-06-06 at 19:57 +0100, Mark Brown wrote:
> On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote:
> 
> > +	/* some IC design adjust register define */
> > +	bool adjust_reg;
> 
> Can we have a name that's more specific to the particular quirk please?
> The current name will get confusing if some future chip also needs
> slightly different register settings.
> 
thanks for your suggestion, I'll fix it.

> Otherwise this looks good.

  reply	other threads:[~2017-06-08  1:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02  7:18 [PATCH 0/3] add mt7622 spi support Leilk Liu
2017-06-02  7:18 ` [PATCH 1/3] dt-bindings: spi: mediatek: Add bindings for mediatek MT7622 soc platform Leilk Liu
2017-06-06 18:57   ` Mark Brown
2017-06-06 19:07   ` Applied "spi: mediatek: Add bindings for mediatek MT7622 soc platform" to the spi tree Mark Brown
2017-06-02  7:18 ` [PATCH 2/3] spi: mediatek: support adjust register define Leilk Liu
2017-06-06 18:57   ` Mark Brown
2017-06-08  1:41     ` lei liu [this message]
2017-06-02  7:18 ` [PATCH 3/3] spi: mediatek: add compatible support for mt7622 IC Leilk Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496886063.30249.1.camel@mhfsdcap03 \
    --to=leilk.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox