From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.zabel@pengutronix.de (Philipp Zabel) Date: Fri, 09 Jun 2017 10:22:42 +0200 Subject: [PATCH 3/3] arm: dts: mt2701: Add display subsystem related nodes for MT2701 In-Reply-To: References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-4-git-send-email-erin.lo@mediatek.com> Message-ID: <1496996562.2343.3.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Matthias, On Fri, 2017-06-09 at 10:14 +0200, Matthias Brugger wrote: > > On 01/06/17 08:08, Erin Lo wrote: > > From: YT Shen > > > > This patch adds the device nodes for the DISP function blocks for MT2701 > > > > Signed-off-by: YT Shen > > Signed-off-by: Erin Lo > > --- > > arch/arm/boot/dts/mt2701.dtsi | 84 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 84 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > > index 4f110d5..e20b65c 100644 > > --- a/arch/arm/boot/dts/mt2701.dtsi > > +++ b/arch/arm/boot/dts/mt2701.dtsi > > @@ -17,6 +17,7 @@ > > #include > > #include > > #include > > +#include > > #include "skeleton64.dtsi" > > #include "mt2701-pinfunc.h" > > > > @@ -24,6 +25,11 @@ > > compatible = "mediatek,mt2701"; > > interrupt-parent = <&sysirq>; > > > > + aliases { > > + rdma0 = &rdma0; > > + rdma1 = &rdma1; > > + }; > > + > > I know we have this alias in mt8173.dtsi, but I don't understand what > they are for. Do you know? The mtk_disp_rdma platform driver uses mtk_ddp_comp_get_id() to identify the specific RDMA instance, which calls of_alias_get_id(). The core code needs to know which RDMA is which to correctly set up the display data paths. regards Philipp