From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622
Date: Tue, 20 Jun 2017 22:21:17 +0800 [thread overview]
Message-ID: <1497968477.27946.5.camel@mtkswgap22> (raw)
In-Reply-To: <20170620034009.GD17764@gondor.apana.org.au>
Hi Herbert,
thanks for effort reviewing on those patches.
By the way, also loop in Torsten
Could you kindly guide me how to determine appropriate
rng->ops.quality value used by the driver?
There is less clues since the value is not being set in
most drivers. But good value decided would allow feeding
fresh entropy data with the hwrng so i would like add it
in the next patch.
I have tested with rngtest on mtk-cir and the result is got as
the below log shown. If the rngtest always gives the result for
success rate over 99.8%, can I set the rng->ops.quality 998?
rngtest: starting FIPS tests...
rngtest: bits received from input: 20000032
rngtest: FIPS 140-2 successes: 998
rngtest: FIPS 140-2 failures: 2
rngtest: FIPS 140-2(2001-10-10) Monobit: 1
rngtest: FIPS 140-2(2001-10-10) Poker: 0
rngtest: FIPS 140-2(2001-10-10) Runs: 1
rngtest: FIPS 140-2(2001-10-10) Long run: 0
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=715.902; avg=3846.234;
max=3906250.000)Kibits/s
rngtest: FIPS tests speed: (min=35.453; avg=37.862; max=38.300)Mibits/s
rngtest: Program run time: 5591758 microseconds
rngtest: starting FIPS tests...
rngtest: bits received from input: 20000032
rngtest: FIPS 140-2 successes: 1000
rngtest: FIPS 140-2 failures: 0
rngtest: FIPS 140-2(2001-10-10) Monobit: 0
rngtest: FIPS 140-2(2001-10-10) Poker: 0
rngtest: FIPS 140-2(2001-10-10) Runs: 0
rngtest: FIPS 140-2(2001-10-10) Long run: 0
rngtest: FIPS 140-2(2001-10-10) Continuous run: 0
rngtest: input channel speed: (min=715.588; avg=4424.787;
max=4882812.500)Kibits/s
rngtest: FIPS tests speed: (min=35.785; avg=37.859; max=38.223)Mibits/s
rngtest: Program run time: 4947950 microseconds
On Tue, 2017-06-20 at 11:40 +0800, Herbert Xu wrote:
> On Mon, Jun 12, 2017 at 11:56:53PM +0800, sean.wang at mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> >
> > Changes since v1:
> > - update the bindings with the specific "mediatek,mt7622-rng"
> > instead of the generic one as "mediatek,generic-rng"
> >
> > The series add support of hardware RNG on MediaTek MT7622 and
> > , runtime PM support and add me as the maintainer for the existing
> > and following chipset.
> >
> > Sean Wang (3):
> > dt-bindings: rng: add MediaTek MT7622 Hardware Random Generator
> > bindings
> > hwrng: mtk - add runtime PM support
> > MAINTAINERS: add entry for MediaTek Random Number Generator
>
> All applied. Thanks.
next prev parent reply other threads:[~2017-06-20 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 15:56 [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622 sean.wang at mediatek.com
2017-06-12 15:56 ` [PATCH v2 1/3] dt-bindings: rng: add MediaTek MT7622 Hardware Random Generator bindings sean.wang at mediatek.com
2017-06-13 9:39 ` Matthias Brugger
2017-06-18 14:04 ` Rob Herring
2017-06-12 15:56 ` [PATCH v2 2/3] hwrng: mtk - add runtime PM support sean.wang at mediatek.com
2017-06-12 15:56 ` [PATCH v2 3/3] MAINTAINERS: add entry for MediaTek Random Number Generator sean.wang at mediatek.com
2017-06-20 3:40 ` [PATCH v2 0/3] add support of hardware random generator on MediaTek MT7622 Herbert Xu
2017-06-20 14:21 ` Sean Wang [this message]
2017-06-20 14:59 ` Torsten Duwe
2017-06-20 16:08 ` Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497968477.27946.5.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).