* [PATCH v2 0/2] drm: constify drm_encoder_helper_funcs structures
@ 2017-06-21 6:31 Bhumika Goyal
2017-06-21 6:31 ` [PATCH v2 2/2] drm/sun4i: add const to " Bhumika Goyal
2017-06-21 6:31 ` [PATCH v2 1/2] drm/rockchip: " Bhumika Goyal
0 siblings, 2 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-06-21 6:31 UTC (permalink / raw)
To: linux-arm-kernel
Add const to drm_encoder_helper_funcs structures.
Changes in v2 -
* Let the line exceed over 80 characters while adding const
in analogix_dp-rockchip.c file.
Bhumika Goyal (2):
drm/rockchip: add const to drm_encoder_helper_funcs structures
drm/sun4i: add const to drm_encoder_helper_funcs structures
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 2/2] drm/sun4i: add const to drm_encoder_helper_funcs structures
2017-06-21 6:31 [PATCH v2 0/2] drm: constify drm_encoder_helper_funcs structures Bhumika Goyal
@ 2017-06-21 6:31 ` Bhumika Goyal
2017-06-21 6:31 ` [PATCH v2 1/2] drm/rockchip: " Bhumika Goyal
1 sibling, 0 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-06-21 6:31 UTC (permalink / raw)
To: linux-arm-kernel
Add const to drm_encoder_helper_funcs structures as they are only passed
as an argument to the function drm_encoder_helper_add and this argument
is of type const. So, add const to these structures.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
Changes in v2 -
* No change
drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 +-
drivers/gpu/drm/sun4i/sun4i_tv.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c
index 422b191..67847d2 100644
--- a/drivers/gpu/drm/sun4i/sun4i_rgb.c
+++ b/drivers/gpu/drm/sun4i/sun4i_rgb.c
@@ -181,7 +181,7 @@ static void sun4i_rgb_encoder_mode_set(struct drm_encoder *encoder,
clk_set_phase(tcon->dclk, 120);
}
-static struct drm_encoder_helper_funcs sun4i_rgb_enc_helper_funcs = {
+static const struct drm_encoder_helper_funcs sun4i_rgb_enc_helper_funcs = {
.atomic_check = sun4i_rgb_atomic_check,
.mode_set = sun4i_rgb_encoder_mode_set,
.disable = sun4i_rgb_encoder_disable,
diff --git a/drivers/gpu/drm/sun4i/sun4i_tv.c b/drivers/gpu/drm/sun4i/sun4i_tv.c
index 338b9e5..b20f97a 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tv.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tv.c
@@ -488,7 +488,7 @@ static void sun4i_tv_mode_set(struct drm_encoder *encoder,
regmap_write(tv->regs, SUN4I_TVE_SLAVE_REG, 0);
}
-static struct drm_encoder_helper_funcs sun4i_tv_helper_funcs = {
+static const struct drm_encoder_helper_funcs sun4i_tv_helper_funcs = {
.atomic_check = sun4i_tv_atomic_check,
.disable = sun4i_tv_disable,
.enable = sun4i_tv_enable,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures
2017-06-21 6:31 [PATCH v2 0/2] drm: constify drm_encoder_helper_funcs structures Bhumika Goyal
2017-06-21 6:31 ` [PATCH v2 2/2] drm/sun4i: add const to " Bhumika Goyal
@ 2017-06-21 6:31 ` Bhumika Goyal
2017-06-21 6:36 ` Mark yao
1 sibling, 1 reply; 4+ messages in thread
From: Bhumika Goyal @ 2017-06-21 6:31 UTC (permalink / raw)
To: linux-arm-kernel
Add const to drm_encoder_helper_funcs structures as they are only passed
as an argument to the function drm_encoder_helper_add and this argument
is of type const. So, add const to these structures.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
Changes in v2 -
* Let the line exceed over 80 characters while adding const.
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +-
drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 9606121..b64cadc 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -252,7 +252,7 @@ rockchip_dp_drm_encoder_atomic_check(struct drm_encoder *encoder,
return 0;
}
-static struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = {
+static const struct drm_encoder_helper_funcs rockchip_dp_encoder_helper_funcs = {
.mode_fixup = rockchip_dp_drm_encoder_mode_fixup,
.mode_set = rockchip_dp_drm_encoder_mode_set,
.enable = rockchip_dp_drm_encoder_enable,
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
index 7d9b75e..4ab9fad 100644
--- a/drivers/gpu/drm/rockchip/inno_hdmi.c
+++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
@@ -530,7 +530,7 @@ inno_hdmi_encoder_atomic_check(struct drm_encoder *encoder,
return 0;
}
-static struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = {
+static const struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = {
.enable = inno_hdmi_encoder_enable,
.disable = inno_hdmi_encoder_disable,
.mode_fixup = inno_hdmi_encoder_mode_fixup,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] drm/rockchip: add const to drm_encoder_helper_funcs structures
2017-06-21 6:31 ` [PATCH v2 1/2] drm/rockchip: " Bhumika Goyal
@ 2017-06-21 6:36 ` Mark yao
0 siblings, 0 replies; 4+ messages in thread
From: Mark yao @ 2017-06-21 6:36 UTC (permalink / raw)
To: linux-arm-kernel
On 2017?06?21? 14:31, Bhumika Goyal wrote:
> Add const to drm_encoder_helper_funcs structures as they are only passed
> as an argument to the function drm_encoder_helper_add and this argument
> is of type const. So, add const to these structures.
>
> Signed-off-by: Bhumika Goyal<bhumirks@gmail.com>
> ---
> Changes in v2 -
> * Let the line exceed over 80 characters while adding const.
Acked-by: Mark Yao <mark.yao@rock-chips.com>
Thanks
--
?ark Yao
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-21 6:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-21 6:31 [PATCH v2 0/2] drm: constify drm_encoder_helper_funcs structures Bhumika Goyal
2017-06-21 6:31 ` [PATCH v2 2/2] drm/sun4i: add const to " Bhumika Goyal
2017-06-21 6:31 ` [PATCH v2 1/2] drm/rockchip: " Bhumika Goyal
2017-06-21 6:36 ` Mark yao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).