linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] arm64: Coredump fixes
Date: Wed, 21 Jun 2017 15:55:37 +0100	[thread overview]
Message-ID: <1498057010-12028-1-git-send-email-Dave.Martin@arm.com> (raw)

We have a few bugs affecting coredumps on arm64, namely:

 * VFP regs missing for compat
 * dumped FPSIMD/VFP regs and user RW TLS reg may be stale

It appears that these bugs were all introduced in the original arm64
ptrace implementation in v3.6: 478fcb2cdb23 ("arm64: Debugging
support").

Judging by the amount of noise people have(n't) been making about these,
they're not likely to be critical for anyone, but the patches apply back
to v4.9 without conflicts so it may be worth Cc-ing stable for those.
I've not done that yet to avoid the patches being pulled prematurely.

I have simple backports back to v3.6 if anyone cares, but I won't post
them unless someone shouts -- they may just cause unnecessary churn.

Basic testing has been done, on v4.12-rc* only, with a simple userspace
test and manual parsing of the resulting coredumps.  Other revisions
have only been build-tested.

I haven't checked for similar bugs in arch/arm.  Casual inspection
suggests that the required flushing is already in place there.

Dave Martin (3):
  arm64: compat: Fix VFP register dumping in coredumps
  arm64: ptrace: Flush FPSIMD regs back to thread_struct before reading
  arm64: ptrace: Flush user-RW TLS reg to thread_struct before reading

 arch/arm64/include/asm/processor.h |  3 +++
 arch/arm64/kernel/process.c        |  8 ++++++--
 arch/arm64/kernel/ptrace.c         | 22 ++++++++++++++++++----
 3 files changed, 27 insertions(+), 6 deletions(-)

-- 
2.1.4

             reply	other threads:[~2017-06-21 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 14:55 Dave Martin [this message]
2017-06-21 15:00 ` [PATCH 1/3] arm64: ptrace: Fix VFP register dumping in compat coredumps Dave Martin
2017-06-21 15:23   ` Mark Rutland
2017-06-21 16:05     ` Dave Martin
2017-06-21 15:00 ` [PATCH 2/3] arm64: ptrace: Flush FPSIMD regs back to thread_struct before reading Dave Martin
2017-06-21 15:00 ` [PATCH 3/3] arm64: ptrace: Flush user-RW TLS reg " Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498057010-12028-1-git-send-email-Dave.Martin@arm.com \
    --to=dave.martin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).