From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the codebase
Date: Tue, 27 Jun 2017 05:21:30 -0700 [thread overview]
Message-ID: <1498566090.24295.59.camel@perches.com> (raw)
In-Reply-To: <20170627120626.GA21666@home>
On Tue, 2017-06-27 at 15:06 +0300, Roman Storozhenko wrote:
> On Tue, Jun 27, 2017 at 12:01:25PM +0200, Paolo Bonzini wrote:
> > On 27/06/2017 11:54, Roman Storozhenko wrote:
> > > Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> > > ---
> > > virt/kvm/arm/arm.c | 2 +-
> > > virt/kvm/coalesced_mmio.c | 2 +-
> > > virt/kvm/eventfd.c | 10 ++++++----
> > > virt/kvm/irqchip.c | 7 ++++---
> > > virt/kvm/kvm_main.c | 16 ++++++++--------
> > > 5 files changed, 20 insertions(+), 17 deletions(-)
> >
> > This change is pointless. Contributors to KVM should know what
> > "unsigned" means.
>
> Paolo, thanks that you mentioned this. But I have a question - is this just
> useless or this is an error?
(Not Paulo and my 2c) Neither really.
> I saw many places in the codebase where 'unsigned int' is used. That why I
> decided to make the codebase more standartized from the style point of
> view.
In virt/kvm, there are 16 lines with unsigned, 160 with unsigned int
<shrug>, Both statements are correct, yes, it's kinda pointless,
and, yes, it does standardize the declarations.
It's entirely up the the maintainers (Paulo and Radim) to apply
or reject this style-only trivial patch. The compiler doesn't care.
next prev parent reply other threads:[~2017-06-27 12:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 9:54 [PATCH] KVM: Replaces 'unsigned' with 'unsigned int' in the codebase Roman Storozhenko
2017-06-27 10:01 ` Paolo Bonzini
2017-06-27 12:06 ` Roman Storozhenko
2017-06-27 12:21 ` Joe Perches [this message]
2017-06-27 13:31 ` Roman Storozhenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498566090.24295.59.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox