* [PATCH 1/9] dt-bindings: sram: Document renesas,smp-sram
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-10 1:08 ` Rob Herring
2017-07-04 15:41 ` [PATCH 2/9] ARM: shmobile: rcar-gen2: Obtain jump stub region from DT Geert Uytterhoeven
` (8 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Document reserved SRAM for the SMP jump stub on Renesas R-Car Gen2 and
RZ/G1 SoCs.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../devicetree/bindings/sram/renesas,smp-sram.txt | 27 ++++++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sram/renesas,smp-sram.txt
diff --git a/Documentation/devicetree/bindings/sram/renesas,smp-sram.txt b/Documentation/devicetree/bindings/sram/renesas,smp-sram.txt
new file mode 100644
index 0000000000000000..712d05e3e15eeb65
--- /dev/null
+++ b/Documentation/devicetree/bindings/sram/renesas,smp-sram.txt
@@ -0,0 +1,27 @@
+* Renesas SMP SRAM
+
+Renesas R-Car Gen2 and RZ/G1 SoCs need a small piece of SRAM for the jump stub
+for secondary CPU bringup and CPU hotplug.
+This memory is reserved by adding a child node to a "mmio-sram" node, cfr.
+Documentation/devicetree/bindings/sram/sram.txt.
+
+Required child node properties:
+ - compatible: Must be "renesas,smp-sram",
+ - reg: Address and length of the reserved SRAM.
+ The full physical (bus) address must be aligned to a 256 KiB boundary.
+
+
+Example:
+
+ icram1: sram at e63c0000 {
+ compatible = "mmio-sram";
+ reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 2/9] ARM: shmobile: rcar-gen2: Obtain jump stub region from DT
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 1/9] dt-bindings: sram: Document renesas,smp-sram Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 3/9] ARM: dts: r8a7743: Reserve SRAM for the SMP jump stub Geert Uytterhoeven
` (7 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Add support for obtaining from DT the SRAM region to store the jump stub
for CPU core bringup, according to the renesas,smp-sram DT bindings.
If no region is specified in DT, the code falls back to hardcoded ICRAM1
as before, to maintain backwards compatibility.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/mach-shmobile/pm-rcar-gen2.c | 33 ++++++++++++++++++++++++++++++---
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-shmobile/pm-rcar-gen2.c b/arch/arm/mach-shmobile/pm-rcar-gen2.c
index 0178da7ace82dcbd..e5f215c8b218100a 100644
--- a/arch/arm/mach-shmobile/pm-rcar-gen2.c
+++ b/arch/arm/mach-shmobile/pm-rcar-gen2.c
@@ -11,7 +11,9 @@
*/
#include <linux/kernel.h>
+#include <linux/ioport.h>
#include <linux/of.h>
+#include <linux/of_address.h>
#include <linux/smp.h>
#include <linux/soc/renesas/rcar-sysc.h>
#include <asm/io.h>
@@ -69,8 +71,9 @@ void __init rcar_gen2_pm_init(void)
struct device_node *np, *cpus;
bool has_a7 = false;
bool has_a15 = false;
- phys_addr_t boot_vector_addr = ICRAM1;
+ struct resource res;
u32 syscier = 0;
+ int error;
if (once++)
return;
@@ -91,14 +94,38 @@ void __init rcar_gen2_pm_init(void)
else if (of_machine_is_compatible("renesas,r8a7791"))
syscier = 0x00111003;
+ np = of_find_compatible_node(NULL, NULL, "renesas,smp-sram");
+ if (!np) {
+ /* No smp-sram in DT, fall back to hardcoded address */
+ res = (struct resource)DEFINE_RES_MEM(ICRAM1,
+ shmobile_boot_size);
+ goto map;
+ }
+
+ error = of_address_to_resource(np, 0, &res);
+ if (error) {
+ pr_err("Failed to get smp-sram address: %d\n", error);
+ return;
+ }
+
+map:
/* RAM for jump stub, because BAR requires 256KB aligned address */
- p = ioremap_nocache(boot_vector_addr, shmobile_boot_size);
+ if (res.start & (256 * 1024 - 1) ||
+ resource_size(&res) < shmobile_boot_size) {
+ pr_err("Invalid smp-sram region\n");
+ return;
+ }
+
+ p = ioremap(res.start, resource_size(&res));
+ if (!p)
+ return;
+
memcpy_toio(p, shmobile_boot_vector, shmobile_boot_size);
iounmap(p);
/* setup reset vectors */
p = ioremap_nocache(RST, 0x63);
- bar = phys_to_sbar(boot_vector_addr);
+ bar = phys_to_sbar(res.start);
if (has_a15) {
writel_relaxed(bar, p + CA15BAR);
writel_relaxed(bar | SBAR_BAREN, p + CA15BAR);
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 3/9] ARM: dts: r8a7743: Reserve SRAM for the SMP jump stub
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 1/9] dt-bindings: sram: Document renesas,smp-sram Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 2/9] ARM: shmobile: rcar-gen2: Obtain jump stub region from DT Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 4/9] ARM: dts: r8a7745: " Geert Uytterhoeven
` (6 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Reserve SRAM for the jump stub for CPU core bringup.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7743.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index b8ce935f6fb196fe..4d59e498fb45fe15 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -481,6 +481,14 @@
icram1: sram at e63c0000 {
compatible = "mmio-sram";
reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
};
ether: ethernet at ee700000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 4/9] ARM: dts: r8a7745: Reserve SRAM for the SMP jump stub
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
` (2 preceding siblings ...)
2017-07-04 15:41 ` [PATCH 3/9] ARM: dts: r8a7743: Reserve SRAM for the SMP jump stub Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 5/9] ARM: dts: r8a7790: " Geert Uytterhoeven
` (5 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Reserve SRAM for the jump stub for CPU core bringup.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7745.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi
index 88cf92bcd2f9b4fc..354534cdc5889cbc 100644
--- a/arch/arm/boot/dts/r8a7745.dtsi
+++ b/arch/arm/boot/dts/r8a7745.dtsi
@@ -481,6 +481,14 @@
icram1: sram at e63c0000 {
compatible = "mmio-sram";
reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
};
ether: ethernet at ee700000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 5/9] ARM: dts: r8a7790: Reserve SRAM for the SMP jump stub
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
` (3 preceding siblings ...)
2017-07-04 15:41 ` [PATCH 4/9] ARM: dts: r8a7745: " Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 6/9] ARM: dts: r8a7791: " Geert Uytterhoeven
` (4 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Reserve SRAM for the jump stub for CPU core bringup.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 4ee34995573cf505..ff986df23b62135f 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -838,6 +838,14 @@
icram1: sram at e63c0000 {
compatible = "mmio-sram";
reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
};
ether: ethernet at ee700000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 6/9] ARM: dts: r8a7791: Reserve SRAM for the SMP jump stub
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
` (4 preceding siblings ...)
2017-07-04 15:41 ` [PATCH 5/9] ARM: dts: r8a7790: " Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 7/9] ARM: dts: r8a7792: " Geert Uytterhoeven
` (3 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Reserve SRAM for the jump stub for CPU core bringup.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7791.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index f4748a9cb0375e4d..e135da440eed7b94 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -898,6 +898,14 @@
icram1: sram at e63c0000 {
compatible = "mmio-sram";
reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
};
ether: ethernet at ee700000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 7/9] ARM: dts: r8a7792: Reserve SRAM for the SMP jump stub
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
` (5 preceding siblings ...)
2017-07-04 15:41 ` [PATCH 6/9] ARM: dts: r8a7791: " Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 8/9] ARM: dts: r8a7793: " Geert Uytterhoeven
` (2 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Reserve SRAM for the jump stub for CPU core bringup.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7792.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7792.dtsi b/arch/arm/boot/dts/r8a7792.dtsi
index 136a86ac64974adb..2623f39bed2b73bb 100644
--- a/arch/arm/boot/dts/r8a7792.dtsi
+++ b/arch/arm/boot/dts/r8a7792.dtsi
@@ -473,6 +473,14 @@
icram1: sram at e63c0000 {
compatible = "mmio-sram";
reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
};
sdhi0: sd at ee100000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 8/9] ARM: dts: r8a7793: Reserve SRAM for the SMP jump stub
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
` (6 preceding siblings ...)
2017-07-04 15:41 ` [PATCH 7/9] ARM: dts: r8a7792: " Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 15:41 ` [PATCH 9/9] ARM: dts: r8a7794: " Geert Uytterhoeven
2017-07-04 16:44 ` [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Reserve SRAM for the jump stub for CPU core bringup.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7793.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index bc6a44272f555215..497716b6fbe24164 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -856,6 +856,14 @@
icram1: sram at e63c0000 {
compatible = "mmio-sram";
reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
};
ether: ethernet at ee700000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 9/9] ARM: dts: r8a7794: Reserve SRAM for the SMP jump stub
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
` (7 preceding siblings ...)
2017-07-04 15:41 ` [PATCH 8/9] ARM: dts: r8a7793: " Geert Uytterhoeven
@ 2017-07-04 15:41 ` Geert Uytterhoeven
2017-07-04 16:44 ` [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
9 siblings, 0 replies; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 15:41 UTC (permalink / raw)
To: linux-arm-kernel
Reserve SRAM for the jump stub for CPU core bringup.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r8a7794.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index 78973cee7185ffe6..f32b458e93285adc 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -596,6 +596,14 @@
icram1: sram at e63c0000 {
compatible = "mmio-sram";
reg = <0 0xe63c0000 0 0x1000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0 0xe63c0000 0x1000>;
+
+ smp-sram at 0 {
+ compatible = "renesas,smp-sram";
+ reg = <0 0x10>;
+ };
};
ether: ethernet at ee700000 {
--
2.7.4
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT
2017-07-04 15:41 [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
` (8 preceding siblings ...)
2017-07-04 15:41 ` [PATCH 9/9] ARM: dts: r8a7794: " Geert Uytterhoeven
@ 2017-07-04 16:44 ` Geert Uytterhoeven
2017-07-10 8:39 ` Simon Horman
9 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 16:44 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 4, 2017 at 5:41 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> The R-Car Gen2 platform code for CPU core bringup needs to copy a jump
> stub to on-SoC SRAM. Currently it uses a hardcoded address pointing to
> ICRAM1.
>
> This patch series adds support to specify this region from DT. It
> consists of 3 parts:
> - DT binding documentation for reserving SRAM for the jump stub,
> - A platform code update to retrieve the information from DT, if
> present (of course backwards-compatibility with old DTBs is
> preserved),
> - DT updates to reserve an SRAM region in DT on all R-Car Gen2 and
> RZ/G1 SoCs.
>
> The DT patches in this series depend on "[PATCH 0/7] ARM: dts: renesas:
> Add Inter Connect RAM".
>
> Note that the current jump stub in Linux is 12 bytes long. The patches
> reserve 16 bytes of SRAM. Should this be increased? The mapping
> granularity is PAGE_SIZE anyway.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (9):
> dt-bindings: sram: Document renesas,smp-sram
> ARM: shmobile: rcar-gen2: Obtain jump stub region from DT
> ARM: dts: r8a7743: Reserve SRAM for the SMP jump stub
> ARM: dts: r8a7745: Reserve SRAM for the SMP jump stub
> ARM: dts: r8a7790: Reserve SRAM for the SMP jump stub
> ARM: dts: r8a7791: Reserve SRAM for the SMP jump stub
> ARM: dts: r8a7792: Reserve SRAM for the SMP jump stub
> ARM: dts: r8a7793: Reserve SRAM for the SMP jump stub
> ARM: dts: r8a7794: Reserve SRAM for the SMP jump stub
Forgot to mention: this has been tested on r8a7790/lager, r8a7791/koelsch,
r8a7792/blanche, r8a7793/gose, and r8a7794/alt (r8a7794 needs an
unrelated fix to enable SMP).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT
2017-07-04 16:44 ` [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT Geert Uytterhoeven
@ 2017-07-10 8:39 ` Simon Horman
2017-07-10 8:44 ` Geert Uytterhoeven
0 siblings, 1 reply; 15+ messages in thread
From: Simon Horman @ 2017-07-10 8:39 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 04, 2017 at 06:44:48PM +0200, Geert Uytterhoeven wrote:
> On Tue, Jul 4, 2017 at 5:41 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > The R-Car Gen2 platform code for CPU core bringup needs to copy a jump
> > stub to on-SoC SRAM. Currently it uses a hardcoded address pointing to
> > ICRAM1.
> >
> > This patch series adds support to specify this region from DT. It
> > consists of 3 parts:
> > - DT binding documentation for reserving SRAM for the jump stub,
> > - A platform code update to retrieve the information from DT, if
> > present (of course backwards-compatibility with old DTBs is
> > preserved),
> > - DT updates to reserve an SRAM region in DT on all R-Car Gen2 and
> > RZ/G1 SoCs.
> >
> > The DT patches in this series depend on "[PATCH 0/7] ARM: dts: renesas:
> > Add Inter Connect RAM".
> >
> > Note that the current jump stub in Linux is 12 bytes long. The patches
> > reserve 16 bytes of SRAM. Should this be increased? The mapping
> > granularity is PAGE_SIZE anyway.
> >
> > Thanks for your comments!
> >
> > Geert Uytterhoeven (9):
> > dt-bindings: sram: Document renesas,smp-sram
> > ARM: shmobile: rcar-gen2: Obtain jump stub region from DT
> > ARM: dts: r8a7743: Reserve SRAM for the SMP jump stub
> > ARM: dts: r8a7745: Reserve SRAM for the SMP jump stub
> > ARM: dts: r8a7790: Reserve SRAM for the SMP jump stub
> > ARM: dts: r8a7791: Reserve SRAM for the SMP jump stub
> > ARM: dts: r8a7792: Reserve SRAM for the SMP jump stub
> > ARM: dts: r8a7793: Reserve SRAM for the SMP jump stub
> > ARM: dts: r8a7794: Reserve SRAM for the SMP jump stub
>
> Forgot to mention: this has been tested on r8a7790/lager, r8a7791/koelsch,
> r8a7792/blanche, r8a7793/gose, and r8a7794/alt (r8a7794 needs an
> unrelated fix to enable SMP).
Geert, these seem nice and clean to me.
Are they ready to be applied?
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT
2017-07-10 8:39 ` Simon Horman
@ 2017-07-10 8:44 ` Geert Uytterhoeven
2017-07-10 9:31 ` Simon Horman
0 siblings, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2017-07-10 8:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Mon, Jul 10, 2017 at 10:39 AM, Simon Horman <horms@verge.net.au> wrote:
> On Tue, Jul 04, 2017 at 06:44:48PM +0200, Geert Uytterhoeven wrote:
>> On Tue, Jul 4, 2017 at 5:41 PM, Geert Uytterhoeven
>> <geert+renesas@glider.be> wrote:
>> > The R-Car Gen2 platform code for CPU core bringup needs to copy a jump
>> > stub to on-SoC SRAM. Currently it uses a hardcoded address pointing to
>> > ICRAM1.
>> >
>> > This patch series adds support to specify this region from DT. It
>> > consists of 3 parts:
>> > - DT binding documentation for reserving SRAM for the jump stub,
>> > - A platform code update to retrieve the information from DT, if
>> > present (of course backwards-compatibility with old DTBs is
>> > preserved),
>> > - DT updates to reserve an SRAM region in DT on all R-Car Gen2 and
>> > RZ/G1 SoCs.
>> >
>> > The DT patches in this series depend on "[PATCH 0/7] ARM: dts: renesas:
>> > Add Inter Connect RAM".
>> >
>> > Note that the current jump stub in Linux is 12 bytes long. The patches
>> > reserve 16 bytes of SRAM. Should this be increased? The mapping
>> > granularity is PAGE_SIZE anyway.
>> >
>> > Thanks for your comments!
>> >
>> > Geert Uytterhoeven (9):
>> > dt-bindings: sram: Document renesas,smp-sram
>> > ARM: shmobile: rcar-gen2: Obtain jump stub region from DT
>> > ARM: dts: r8a7743: Reserve SRAM for the SMP jump stub
>> > ARM: dts: r8a7745: Reserve SRAM for the SMP jump stub
>> > ARM: dts: r8a7790: Reserve SRAM for the SMP jump stub
>> > ARM: dts: r8a7791: Reserve SRAM for the SMP jump stub
>> > ARM: dts: r8a7792: Reserve SRAM for the SMP jump stub
>> > ARM: dts: r8a7793: Reserve SRAM for the SMP jump stub
>> > ARM: dts: r8a7794: Reserve SRAM for the SMP jump stub
>>
>> Forgot to mention: this has been tested on r8a7790/lager, r8a7791/koelsch,
>> r8a7792/blanche, r8a7793/gose, and r8a7794/alt (r8a7794 needs an
>> unrelated fix to enable SMP).
>
> Geert, these seem nice and clean to me.
> Are they ready to be applied?
Now the binding has been Acked by Rob, I think they are.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread* [PATCH 0/9] ARM: renesas: Use SMP jump stub SRAM region from DT
2017-07-10 8:44 ` Geert Uytterhoeven
@ 2017-07-10 9:31 ` Simon Horman
0 siblings, 0 replies; 15+ messages in thread
From: Simon Horman @ 2017-07-10 9:31 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 10, 2017 at 10:44:47AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Mon, Jul 10, 2017 at 10:39 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Jul 04, 2017 at 06:44:48PM +0200, Geert Uytterhoeven wrote:
> >> On Tue, Jul 4, 2017 at 5:41 PM, Geert Uytterhoeven
> >> <geert+renesas@glider.be> wrote:
> >> > The R-Car Gen2 platform code for CPU core bringup needs to copy a jump
> >> > stub to on-SoC SRAM. Currently it uses a hardcoded address pointing to
> >> > ICRAM1.
> >> >
> >> > This patch series adds support to specify this region from DT. It
> >> > consists of 3 parts:
> >> > - DT binding documentation for reserving SRAM for the jump stub,
> >> > - A platform code update to retrieve the information from DT, if
> >> > present (of course backwards-compatibility with old DTBs is
> >> > preserved),
> >> > - DT updates to reserve an SRAM region in DT on all R-Car Gen2 and
> >> > RZ/G1 SoCs.
> >> >
> >> > The DT patches in this series depend on "[PATCH 0/7] ARM: dts: renesas:
> >> > Add Inter Connect RAM".
> >> >
> >> > Note that the current jump stub in Linux is 12 bytes long. The patches
> >> > reserve 16 bytes of SRAM. Should this be increased? The mapping
> >> > granularity is PAGE_SIZE anyway.
> >> >
> >> > Thanks for your comments!
> >> >
> >> > Geert Uytterhoeven (9):
> >> > dt-bindings: sram: Document renesas,smp-sram
> >> > ARM: shmobile: rcar-gen2: Obtain jump stub region from DT
> >> > ARM: dts: r8a7743: Reserve SRAM for the SMP jump stub
> >> > ARM: dts: r8a7745: Reserve SRAM for the SMP jump stub
> >> > ARM: dts: r8a7790: Reserve SRAM for the SMP jump stub
> >> > ARM: dts: r8a7791: Reserve SRAM for the SMP jump stub
> >> > ARM: dts: r8a7792: Reserve SRAM for the SMP jump stub
> >> > ARM: dts: r8a7793: Reserve SRAM for the SMP jump stub
> >> > ARM: dts: r8a7794: Reserve SRAM for the SMP jump stub
> >>
> >> Forgot to mention: this has been tested on r8a7790/lager, r8a7791/koelsch,
> >> r8a7792/blanche, r8a7793/gose, and r8a7794/alt (r8a7794 needs an
> >> unrelated fix to enable SMP).
> >
> > Geert, these seem nice and clean to me.
> > Are they ready to be applied?
>
> Now the binding has been Acked by Rob, I think they are.
> Thanks!
Thanks, all patches accepted for v4.14.
^ permalink raw reply [flat|nested] 15+ messages in thread