From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA534CA5500 for ; Wed, 13 Sep 2023 07:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oR5kwdZViuoMtTnb+OrKZnZ4L4LgLSuabogbR++Lfzw=; b=bGChZOxZ1RbjUa meVOAz09GaHEbabmhxAjoF8WLO0ekk5lPlYe8o1gmrrXfTDZr55Ptd8MFg/rZHLtUeMFWJ3RV+3eh AtcQSfjrSGq+/EzcCp7+sivsAsCvwVWA3A0dZ5odB72mYjRqVXF6YU/CX5CNf9FWdGzjIfeeJN+tP qwk7ZjXSfNrzDW5/oZqcIY5vnx56gYCUz0bUZS5Snj0mURVT8s7GIuNKbjVYtI1mWPS1W6RQ1k2Ug Y+qW034YY5BqhKIPP/NINLDYwE8WeYVOpLkPV973YW2B7/+/YR9TadrbWvqjkxHZBzRtnGWxdg3kP M1kBfhSn+wEEJ8KMMkuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgJud-004suV-1q; Wed, 13 Sep 2023 07:03:47 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qgJuZ-004stf-1I; Wed, 13 Sep 2023 07:03:45 +0000 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38D6q17L027482; Wed, 13 Sep 2023 07:03:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ziSOaqQRIoG94oZGz0d5r0+7UOw/nEgZ32lMUgWge/E=; b=l1Mm2/Gor3UeT616Kj3wNqUh82gOg4TSYQDva8Q2a6CTViIYYdhbrzuC9UGrBUKAJK5Y qA6fr3JCshsUCAimWB2n1/3f7Xyts2008/ruKvk8vzDL3jTayon0X3Kshvg9nTkmnT3h UZkJoP5+qQul3Mt8O/yEsV7+4MJXxqsFF4PEHQaagoKuC48c3Z5aLcL5144Q/FBRZLXH upRNzbXFML4EGc0RRDTN+btvDpCrnZo0Eu82M+/bRkmgeb3UJG321CJM/JL3bkPB6mYw 7ssWkFHFxV9GlT7L+ClJPWVzRTAVqt4WX/L28bvHcvN05+W1SO7GklEcXUHB6YzBi64O 3Q== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t2y7ts0vg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 07:03:15 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38D73Eg8010732 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Sep 2023 07:03:14 GMT Received: from [10.214.66.81] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Wed, 13 Sep 2023 00:03:02 -0700 Message-ID: <14bf3fca-f031-d000-6fd6-d82f4de9b255@quicinc.com> Date: Wed, 13 Sep 2023 12:32:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [REBASE PATCH v5 08/17] arm64: mm: Add dynamic ramoops region support through command line Content-Language: en-US To: Will Deacon CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <1694429639-21484-1-git-send-email-quic_mojha@quicinc.com> <1694429639-21484-9-git-send-email-quic_mojha@quicinc.com> <20230912101820.GA10884@willie-the-truck> From: Mukesh Ojha In-Reply-To: <20230912101820.GA10884@willie-the-truck> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: GyAbQ0AdteB_VHS7rJh3KcbsPiZrwY1L X-Proofpoint-ORIG-GUID: GyAbQ0AdteB_VHS7rJh3KcbsPiZrwY1L X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_24,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309130058 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230913_000343_480610_B163D34C X-CRM114-Status: GOOD ( 18.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for the response. On 9/12/2023 3:48 PM, Will Deacon wrote: > On Mon, Sep 11, 2023 at 04:23:50PM +0530, Mukesh Ojha wrote: >> The reserved memory region for ramoops is assumed to be at a fixed >> and known location when read from the devicetree. This may not be >> required for something like Qualcomm's minidump which is interested >> in knowing addresses of ramoops region but it does not put hard >> requirement of address being fixed as most of it's SoC does not >> support warm reset and does not use pstorefs at all instead it has >> firmware way of collecting ramoops region if it gets to know the >> address and register it with apss minidump table which is sitting >> in shared memory region in DDR and firmware will have access to >> these table during reset and collects it on crash of SoC. >> >> So, add the support of reserving ramoops region to be dynamically >> allocated early during boot if it is request through command line >> via 'dyn_ramoops_size=' and fill up reserved resource structure and >> export the structure, so that it can be read by ramoops driver. >> >> Signed-off-by: Mukesh Ojha >> --- >> arch/arm64/mm/init.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++ > > Why does this need to be in the arch code? There's absolutely nothing > arm64-specific here. Current clients of this cmdline would be only arm64, and that is the reason of putting this here. I was checking the places where memblock_phys_alloc_range() gets called and found either it is arch/*/ and drivers/of/of_reserved_mem.c . Since, this is not related to device tree, did not find a proper place than this, i took the reference of this place from reserve_crashkernel(). Also, not sure how could it be of help to other non-arch64 users at this point. -Mukesh > > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel