From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86BE1C48BF6 for ; Mon, 4 Mar 2024 02:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qH5wkkoXFfI+avKjqKoNI+OnT0BbZ0ZCzmW0HR3dE4g=; b=J/v9GNUw25r9MD zdsQsjHvaCSKsyuqghbmlu77AG1SEIzAiiLikfllfYLckUxJy9F3Ep61Mv1ePzRtgRU2W2Ue3WraX D8e2mu5BLXXhTj5I/jaksfip6w64ePiJ+qWMZ/z4m5I92BgQ72BkPOJeteQCx5cArfE7H0i3RrEo/ 6NTYmiePvLgCuA+oAOEjcJebWos4zTAqv+MjDJRpex3Y4TohPKAWvcj88aqP/nGxeZMGgsXQ9oeIc 6lDRjEXI8AFLt1MuOgevcneAWtkFQvA9ANVXO9BC1dbhPa7ey6LUJEfpB7fIUwuzN3DahDOdfQAOY fOGOHshrQgObOIjLH41w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgxeH-00000007G5Z-1Ghh; Mon, 04 Mar 2024 02:01:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rgxeE-00000007G19-2wE5; Mon, 04 Mar 2024 02:01:48 +0000 X-UUID: 1d6238a8d9cb11eebd831584b064e983-20240303 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=N4iq/lY8IL0QxCGPGeWsnGWr2I1h3Wvq9gIt8mWQFHU=; b=MQY4Y/0VZV1e3qPkivr63iYP+480Eq6/34nU85CFkwg/caHZs2M8Vm1KgEdV/jK4KVSnk118KwLVZEky3C1xKf4UtFKNuDE393Izf1wruIwC0uA3dtTF924hQzBfNZ/JSmMFHQQXh4ccbUoQz7GwA9fvMOhC5a0NF2FPkJ8QZ9s=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:03ca0e45-9468-4c52-aebc-5f65c3be8d2b,IP:0,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6f543d0,CLOUDID:92939084-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_ULN,TF_CID_SPAM_SNR X-UUID: 1d6238a8d9cb11eebd831584b064e983-20240303 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1226967860; Sun, 03 Mar 2024 19:01:28 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by MTKMBS14N1.mediatek.inc (172.21.101.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 4 Mar 2024 10:00:52 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 4 Mar 2024 10:00:52 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=coPfzeRb0/tFHIUNvR2djFVIKCIfXNubUoBj8AEoABZ9QbwcUWKJVfmOgA2r3va+MGs4XDi7l6Nlwu4ZcQSXAx0FB9GcPJZyfx123NLqcHePoIz3yNUP8fnLYUsNocPQkSupwJaeKIonh9oqM7kZB6bnYlilP+1nuuejuYqZrtEWvlStfj5LU2skn/yKZkfyaJlk0CImKQ3Q6Ofx09ic1qM//gf0L6cHqsQ83276pJcVY608ZjcFpkF2tOTjK1iyzScntI10g7mFFEjtNmecTcDRp+MbbgueWmntCNhaLGLiuHghayLF1V463y9vHXp5JYoULVTTmJs+ZeKEnnr/4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4iq/lY8IL0QxCGPGeWsnGWr2I1h3Wvq9gIt8mWQFHU=; b=LA/IewBkXdSMMlbtkSWwtfru3FyYj/HXM04lS/Lkoz1QZXW4/NPUqil4qEdZ2NE+gX0ox8ddSIW2tm15S0q2kVt+Tkc4fc0z7aEaAIrs+DLt34FM+e+wLDlPKT93AwYDMjVMGFI015S8bKotQPOtO2vBLcBpTojDshWvKZG0VUkaz0gKos1D3T2CHWV6aGNkQh7AGF1ivQOBy5rRv1598EGWWWggfIATgn5/vrE3gTCFaSrafuTTV8U9f4Nx24/orUyok3keNVVmd9BnqdRM0J+CwIOQKzxF5E/eHgwRW90R1loYY77W4fFFvBxbH/cSINAfT/wpBCggPX6ndIdzjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4iq/lY8IL0QxCGPGeWsnGWr2I1h3Wvq9gIt8mWQFHU=; b=M93tufB3x1NPMfo2DF2Sg+8si3ANjvEoZIIcRsd8ZzH7fPoWmGn3Hd1zv8gpKKI/a3F2nFXfoOQqu1nldJld11IDscSUsCXOqvgTrrlcQ09jbUKplNrqV9reG2dYkcVjVzPp14hIqkq6bjKcheS3riIsMLhrAh4gF5cmMj8DYxk= Received: from SEZPR03MB7947.apcprd03.prod.outlook.com (2603:1096:101:187::6) by TYZPR03MB7710.apcprd03.prod.outlook.com (2603:1096:400:3ca::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Mon, 4 Mar 2024 02:00:49 +0000 Received: from SEZPR03MB7947.apcprd03.prod.outlook.com ([fe80::e4f9:968e:f97:59ab]) by SEZPR03MB7947.apcprd03.prod.outlook.com ([fe80::e4f9:968e:f97:59ab%7]) with mapi id 15.20.7339.035; Mon, 4 Mar 2024 02:00:49 +0000 From: =?utf-8?B?SXJ1aSBXYW5nICjnjovnkZ4p?= To: "sebastian.fricke@collabora.com" CC: "linux-kernel@vger.kernel.org" , =?utf-8?B?TG9uZ2ZlaSBXYW5nICjnjovpvpnpo54p?= , =?utf-8?B?VGlmZmFueSBMaW4gKOael+aFp+ePiik=?= , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?utf-8?B?TWFvZ3VhbmcgTWVuZyAo5a2f5q+b5bm/KQ==?= , "mchehab@kernel.org" , "nicolas.dufresne@collabora.com" , =?utf-8?B?WXVuZmVpIERvbmcgKOiRo+S6kemjnik=?= , Project_Global_Chrome_Upstream_Group , "hverkuil-cisco@xs4all.nl" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH v2] media: mediatek: vcodec: Handle VP9 superframe bitstream with 8 sub-frames Thread-Topic: [PATCH v2] media: mediatek: vcodec: Handle VP9 superframe bitstream with 8 sub-frames Thread-Index: AQHaarvgeM7Dv/Xo60GhVwrxh2nPCbEjAKIAgAPZcoA= Date: Mon, 4 Mar 2024 02:00:49 +0000 Message-ID: <14c9dea999efc16f2f1753a9524f558cf066a244.camel@mediatek.com> References: <20240229030249.3404-1-irui.wang@mediatek.com> <20240301151344.o7khwhbasnncw2cc@basti-XPS-13-9310> In-Reply-To: <20240301151344.o7khwhbasnncw2cc@basti-XPS-13-9310> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR03MB7947:EE_|TYZPR03MB7710:EE_ x-ms-office365-filtering-correlation-id: 76da7dab-a397-4fcd-0d6d-08dc3beee9dd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OPFGNjKOUs1pQnspHYdbKRVjRzBuBIfOmT4Gps3Cuw/h6VY9d2VJCNs7X3PJ2lxeYLjcwp7GytWvLtNjh96835mmutDheRLQH7Ex7XbkSVr9/FcXa0v9lhvhGMPTMwhGdhlYX3WvThR5dvUHHV0eKA1vxIRN+TCo+V6nUChubBeP4OWz2Xxi7O65DCmLvdEWzTglXfiih8DwtIR66p3MfLpZdVZB6T+gx9gCYgfwx0uFJ5DmYU034MVT3Xz0qk5HvOvZh/OwMc0g3AXMZq3DdB2sHJYzuXn3Mzqfkf1MuKkZk+QCedHA/nlDGxgjSR/KKGvMHyYlpCc0a09pU/SA7975Xit3+C7X0heJ8k4Wn+YGAcoWxiRT8AGPfi+1Pmu9vsbjJ5Xng6OqKDEhvMHtl99DzspZXTuNsB47hin/X4mDk0mWVXwD1xXUdrHNPt/W05VXzbIYdrreBWrNhl1UVrUSVpAHsOdJ0tvdro+Klebnd2VJTKVHX5p/PuvwBxToF/MFbrf0xZ9WszEwxWX3+4rIYYvKL2/4gtkYeWve9a1VGwHY5ZKVkEJsme7gwm41zYN3Cv/JWq0UHUumf2MEvfZ+r7iIUDoJaKgYX3VOVvrDoQmmgSQT9tQdpHXdzgrWJlKN4usNFsEjhEXWNH35LxC01Qrs0eETjIRTq6xPfoN5Q2cDf7/jA4ykc12iBO0UGMvXzKHkXGbhrflsSr7Tnm5uemwI+Wvdr13Vf5NhAgA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR03MB7947.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b3pxclQ4eFRseGZha2o2eC9xN28vb0ZWeEEzcUFJUkk5SlpCYStLUFZUUnFZ?= =?utf-8?B?NDl0c25YUDR1NUd2T0lQNENhZERGc2hEZTU5WDBnVk5KY0xmK252elR3NldY?= =?utf-8?B?L3crVGRkWjRibE0zZDUxZW1UeFhlb2FobE5HOVZRSitzQ251SWpMcW55SmhO?= =?utf-8?B?OXgxMDNSRDllRHlTeVRVbTlBU1psRlp6UVlKQ21ZWlo4REZ4VTh2UWNhUm5W?= =?utf-8?B?RnRqcFdJY0t0V3JoUEdnQ2FLam5yc3lWTGcwRHR4YVpPcDkvOCs3dU42Yytq?= =?utf-8?B?UWN2eHZBcjJUZFVraEpXOFRRVkdZZ3VDay80S1dCeWJ0UEdSZ1pHdnVIYWdP?= =?utf-8?B?eWJXbWxtbGs0L2ZPTFhKSlZsR29OV2J3cmRQOHlJOUllZmplZGZNWThzdHJL?= =?utf-8?B?OVZrYkpxRTRaQ2JRZjVVOGFCcjBuV2orRHFURWZFMHhRcERQRStxOVBuNFIx?= =?utf-8?B?NXJrTis3YllFQ1MvbFdjUGtXYk5CNjhBTzZKNlBmcWhTdWt1ay9YeDMwNDdH?= =?utf-8?B?NXRkOElQb283cEEvd0t5Kzc4Nld3OVFMOTRUSDZwajJvamh2dEg1OUhqR1lr?= =?utf-8?B?dk9wVWVqc0tKSm9za0NBWWZjdTZVMzArd2FkRDJmd0NMMUNaZjRDYXBOSFhm?= =?utf-8?B?ZFcyNmx5Y0FnY2JWZ3craXZxYlRTRkoxUVJtRnFBRVJwVy8yS1FGd3BWTTI0?= =?utf-8?B?OUVzRW1jWnJlZlp0bFdIaUFieWw2UzZCb2VuS0pxeVZQYWhjN0c5TU5ZTUg0?= =?utf-8?B?cFhydUprTXFTZVhmQTRySzVYczhZT2QzRWZRc3l3ZEllSVFSMSt5ck1JLzcz?= =?utf-8?B?TG5oRU9kT2RjN2VNeDFoWWVBY01zcmZSc3FXSFVHbVl1YmZGWVgva1V1ZW14?= =?utf-8?B?SlFLVTRpM2toUHBKaDlta21QRm90TjZId1pFVFBHenQwZUtpUExsNnk3Vk1t?= =?utf-8?B?RFI0UUlrOVRGOVR4S2czd2xoNkdFOG1kcEZON2U5UHVyaWJQempjUThNeHJI?= =?utf-8?B?eDRIRmZpdXZ5V0pDWEhFQmtXVDcvY0NRTmh5OUxPSzlvMzBkZXJCUUQxZStK?= =?utf-8?B?YnRoTytiNXUxWE9BaFRqNk1rUklrYk9PSnQ1ZXhJcVpVTEd1aVRCWWc1c0lM?= =?utf-8?B?cmZ2Q1FuSnpqdk5JMThDZkpOWktUYURKcGpqOU1wQldNbkhyTTZHK29GRjk0?= =?utf-8?B?Ny9CeHNlS1VTWENnUVcvck96em1hQUowZlF6bDdLRGZBTFo3ZjJVQmVWblZY?= =?utf-8?B?ZzhJTGt4M2trQXRlS3FyeTQyM1o0ZVBZbUVQdVhFbmI2azMydDZZa0xKNTUv?= =?utf-8?B?Rlh6UmFIQ1FJeG0xZUMyMHJzUVJwdy9WOVluZTVJQklvNUZ4Y1l0ZTlOQjBh?= =?utf-8?B?VXE4Q0ZPbWJ5OFJ1MTF6U1FGejhvdlY5dXdCeC9CT2Y4ZElQbDFOazBMRzhh?= =?utf-8?B?VU9kZVhpd25nK01sVUZNdXhYQ1MyVFlxVllTbFl0cjZFTTlTeEZuT3NjYXU4?= =?utf-8?B?cXBxS0xUV251RlJqSGdvWWJNZ2JPRFUvc3U5Rnh2NzNnbmZTYnJaQXVFWStI?= =?utf-8?B?YjFkNk5iT3Z1d0lGWWtJRy9wSSs5eE10dTlocGw4SXc1bTIwYmQwRURBaVZI?= =?utf-8?B?VWxuY3RtcGdpbkdFdVk2YXFyUDRVem0rR21pQyt3S3FIVlE4dUdxZk0ydlZh?= =?utf-8?B?Vm1kSVEyWVI4emM3eDc1Tm0rMisrSzM2REhSWkJGd0pDNnNvcEYvOU1RNzNs?= =?utf-8?B?T2lOUG9Fd1RodnkwbHg0NFcrTGdtb0JuMm1ZM0swSHRrczNMQkloUWtOZlVm?= =?utf-8?B?RGtqczFkemlXeHpsS2o1dnN2eUNMdjl3dkV4aFNUMzRWTzBObnFBc2t0dktJ?= =?utf-8?B?VGc0eTlMeVo0ZCtsbG45cUIvbTJBdFV0V0ppcmpldFQyWWE3UlJ2aHRHOXhV?= =?utf-8?B?U2VkTEZBMXRKbVVOMSthVmMyRUU4cmsxMWFDU3NCMFZZVUFQdXpqdmt6Tnpr?= =?utf-8?B?dVJnbEwwT0VVdisyTytKSy9VYjVYa2VxRStQajAzaWVVUG45cW8xdmhMeHll?= =?utf-8?B?MTJzZzBpV3luVjVGUGdPRnV2c1ZKMUM4T01aazNQN3hYcjJGdXdtSmtBZkF1?= =?utf-8?B?U1R2VC9OUlJ6bi9KSiswSVlHQWNkTVllOTh1UnNOMERWM09UR3IvK1BwcHFX?= =?utf-8?B?Tmc9PQ==?= Content-ID: <16CA559DE01676459637A041A7D78792@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR03MB7947.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76da7dab-a397-4fcd-0d6d-08dc3beee9dd X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2024 02:00:49.1385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AXpmvSh5f3sgpZ6njM2qXQ8NRvvd7HngT40oOMoEwrwVKF9TwkqYyXrrsc4iQUzjIcAxty3GOjkiRrgMsQ/lcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB7710 X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--17.449700-8.000000 X-TMASE-MatchedRID: gIwa0kWWszLUL3YCMmnG4qwOh3D3JSTGQ2+afbhb/Sq5Alb2pliJYKgF 8LHYfOYGQpy1XVcFhh6zLCnUz3MHYy4UUq9htJ32JrUxoq6hvw8L8TGleseLPKuZoybwHAwkYqk wmiKYFxtgc1NQL93aukhGhVq1hSzQX+AaUzfp3hOG/X7YnfJAXJLXhHlWou03tefEfbIMlYv4eY E/JF5KDK4Jhlx7vdJerQtuqHwCYj4Z7Eu9TqPx8MV1CHtMfzqg2yk8ad/lrSDfUZT83lbkEJW3Z GXw3kr5F8u8dQXnFzkSJVWAqoVeTkL9tcyTZdAsgxsfzkNRlfLdB/CxWTRRuyUIayx+Skid X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--17.449700-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 215D548022C08896C7B80EC55F8AFED940A97E7510E9A63484AF723500058F562000:8 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240303_180146_767261_4BA4BB6E X-CRM114-Status: GOOD ( 26.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Sebastian Sir, Thanks for your reviewing. I will reword the commit message according to your suggestion, and send a new patch v3. Thank you very much. Thanks Best Regards On Fri, 2024-03-01 at 16:13 +0100, Sebastian Fricke wrote: > Hey Irui, > > On 29.02.2024 11:02, Irui Wang wrote: > > The VP9 bitstream has 8 sub-frames into one superframe, the > > superframe > > index validate failed when reach 8, modify the index checking so > > that the > > last sub-frame can be decoded normally with stateful vp9 decoder. > > I find this commit message a bit confusing, you say that you couldn't > index the last superframe, but then you say that you modify the index > checking so that you can access the last sub-frame. > > I would reword this section, here is my suggestion: > > The VP9 bitstream uses superframes, which each contain 8 sub-frames, > enable accessing the last superframe by increasing the range of the > index validation as the maximum number of superframes is 8 and not 7. > > The rest looks good as already mentioned by Nicolas. > > Greetings, > Sebastian > > > > > Signed-off-by: Irui Wang > > --- > > changed with v1: > > - add a new define 'VP9_MAX_SUPER_FRAMES_NUM' for superframes. > > --- > > .../mediatek/vcodec/decoder/vdec/vdec_vp9_if.c | 11 ++++++ > > ----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git > > a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_if.c > > b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_if.c > > index 55355fa70090..039082f600c8 100644 > > --- > > a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_if.c > > +++ > > b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_if.c > > @@ -16,6 +16,7 @@ > > #include "../vdec_drv_base.h" > > #include "../vdec_vpu_if.h" > > > > +#define VP9_MAX_SUPER_FRAMES_NUM 8 > > #define VP9_SUPER_FRAME_BS_SZ 64 > > #define MAX_VP9_DPB_SIZE 9 > > > > @@ -133,11 +134,11 @@ struct vp9_sf_ref_fb { > > */ > > struct vdec_vp9_vsi { > > unsigned char sf_bs_buf[VP9_SUPER_FRAME_BS_SZ]; > > - struct vp9_sf_ref_fb sf_ref_fb[VP9_MAX_FRM_BUF_NUM-1]; > > + struct vp9_sf_ref_fb sf_ref_fb[VP9_MAX_SUPER_FRAMES_NUM]; > > int sf_next_ref_fb_idx; > > unsigned int sf_frm_cnt; > > - unsigned int sf_frm_offset[VP9_MAX_FRM_BUF_NUM-1]; > > - unsigned int sf_frm_sz[VP9_MAX_FRM_BUF_NUM-1]; > > + unsigned int sf_frm_offset[VP9_MAX_SUPER_FRAMES_NUM]; > > + unsigned int sf_frm_sz[VP9_MAX_SUPER_FRAMES_NUM]; > > unsigned int sf_frm_idx; > > unsigned int sf_init; > > struct vdec_fb fb; > > @@ -526,7 +527,7 @@ static void vp9_swap_frm_bufs(struct > > vdec_vp9_inst *inst) > > /* if this super frame and it is not last sub-frame, get next > > fb for > > * sub-frame decode > > */ > > - if (vsi->sf_frm_cnt > 0 && vsi->sf_frm_idx != vsi->sf_frm_cnt - > > 1) > > + if (vsi->sf_frm_cnt > 0 && vsi->sf_frm_idx != vsi->sf_frm_cnt) > > vsi->sf_next_ref_fb_idx = vp9_get_sf_ref_fb(inst); > > } > > > > @@ -735,7 +736,7 @@ static void get_free_fb(struct vdec_vp9_inst > > *inst, struct vdec_fb **out_fb) > > > > static int validate_vsi_array_indexes(struct vdec_vp9_inst *inst, > > struct vdec_vp9_vsi *vsi) { > > - if (vsi->sf_frm_idx >= VP9_MAX_FRM_BUF_NUM - 1) { > > + if (vsi->sf_frm_idx > VP9_MAX_SUPER_FRAMES_NUM) { > > mtk_vdec_err(inst->ctx, "Invalid vsi->sf_frm_idx=%u.", > > vsi->sf_frm_idx); > > return -EIO; > > } > > -- > > 2.18.0 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel