From: Markus Elfring <Markus.Elfring@web.de>
To: Miaoqian Lin <linmq006@gmail.com>,
imx@lists.linux.dev, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Richard Zhu" <hongxing.zhu@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Trent Piepho" <tpiepho@impinj.com>
Subject: Re: [PATCH] PCI: imx: fix device node reference leak in imx_pcie_probe
Date: Wed, 3 Sep 2025 19:10:43 +0200 [thread overview]
Message-ID: <14f774db-2f44-49f3-bb02-7d4033675b04@web.de> (raw)
In-Reply-To: <20250903135150.2527259-1-linmq006@gmail.com>
> Add missing of_node_put() after of_parse_phandle() call to properly
> release the device node reference.
How do you think about to increase the application of scope-based resource management?
https://elixir.bootlin.com/linux/v6.17-rc4/source/include/linux/of.h#L138
> Found via static analysis.
Which concrete software tools would be involved for this purpose?
How do you think about to append parentheses to the function name
in the summary phrase?
Regards,
Markus
next prev parent reply other threads:[~2025-09-03 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 13:51 [PATCH] PCI: imx: fix device node reference leak in imx_pcie_probe Miaoqian Lin
2025-09-03 17:10 ` Markus Elfring [this message]
2025-09-03 18:31 ` Frank Li
2025-09-05 8:28 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14f774db-2f44-49f3-bb02-7d4033675b04@web.de \
--to=markus.elfring@web.de \
--cc=bhelgaas@google.com \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kwilczynski@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tpiepho@impinj.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox