From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00C13C433EF for ; Tue, 14 Jun 2022 09:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LZCpWUCDYbc9g/Zk/Ohvx1uoBAkZRwZMKCmde/8ujyY=; b=iCXcwrf8+8LDXu RATnyn4aeKlIVrJm4Y0H67VvJq+DQ+pfCMTV20Wcov4fzHyUq/k660HnJVxA1RpxlXCLYugyivft/ etzKUII7q/4ln3Tt6Tczqk9W05mQCNsuzZ0buKWIuhGzx98P6t21BAFdqFtEf2R5mL+VGhyYvUx0d hswmtC1zbm3ztbDNzboCg9QX1SgqUPnpz5ITkv856cYZz5+j6WDjI43io5YiAnMj/x55MLy+QmkRN QtzI5iV2fbpwZ5LBhyUbdsbSV4vLmUF4AuPZvpYTX7YA85KMnl5npL1857kKVIhlctkhJl1O664o3 VYHQGhQ4Gz/tAPsWbuTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12Tm-008X1e-52; Tue, 14 Jun 2022 09:04:55 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o12Eb-008Odh-9R for linux-arm-kernel@lists.infradead.org; Tue, 14 Jun 2022 08:49:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1655196553; x=1686732553; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=vhtIuIjNOxvlRytlOSuiG+LwyT95x2rnFK4q3EXBOOI=; b=XbRznuP6itWYmBuTbXJsrijIvkURYWFZM9sVq+yE6T8md9yPgnmK5FRH Ut4Mypy6BD7MlMAqDL/Q/sSxgNValruZm9xgfGIpsMf3RFZgVSjsydnD0 GDb0iRyRpvTJRWOwfS0LreyjveHuB9mAK8hkPj6zKJDGoH3UwQndlWT7T NuSGDA5x5qR9jD+gp2U9TJbeHyZH9N2t0ig0kCCWqJrt3hzBfErvpCI3x hcf8MDpWlxkCTuFIdakvbZM+eaXHFyZi6NqJAkq6twyfwqXarsfNWOYqX ZqN38cgSCBv03+shZbUyNyb5J9ocHw9FrT5aECrp+6s4wxThYivKpPwEw A==; X-IronPort-AV: E=Sophos;i="5.91,299,1647327600"; d="scan'208";a="177856035" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 Jun 2022 01:49:10 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 14 Jun 2022 01:49:10 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Tue, 14 Jun 2022 01:49:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S8+TwfE8R4YncnC/zJIglKcZ/hcZrIo1u9Q2jm5YSFa4FSbTiuzwmnjuTg860/BWwE0qOjPaN5hMn4VREursO1IuWgEJ0ZzYcpyHR7QKXYyiAEA9WtU9azgFnVvQYvoXjgRsjtVSa8KNk5qwdGfr45cy0cUtzT/B/esIi4z3GJNQnQ9/o4dWtUDGz2dZQ6JJtFM5R9E58ZEfVRPBPaAHm3EU9u+xskVZ+auiREJEQPbxmlGxvT+ZFFW90z17cs/zNimiJHdd2DPiq3TM7I/Ac4/Mn37rKB5KMBomDMH+eSq4uE29hufxipqDhAkheU7e7L6/ax1VNdGY8mmnhfN9BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vhtIuIjNOxvlRytlOSuiG+LwyT95x2rnFK4q3EXBOOI=; b=kV1JbGgOioKhIu19bXziCTt8knDLE40+tJjxcpHrZPxTZzTMpL64BZN8Fa/JyvCO6N1C9O/6h5DEjXCmz8r085k29h3wBtjak+MnP/+ixi0PCA557eBUPx0Zd/uxJGBShOtvYdL98ip04GatAxz8+L3hJ+2IEpKI6r3prNYX5sw2dzs2vIXOMlUvukyNuU4qMRgeir+zgw9TiPVqglORoicuqALAV1ySWy0BjfIfdrkvjDhJMWlQPliRUZywSWYE33TaBFGyIJCB4gR5UZmlDarYECJLFIolgVKFXpTC6bAxfW4yLDTHERGeZqTZpYpPTSDKVrj8yoXnu5sgfMrBnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhtIuIjNOxvlRytlOSuiG+LwyT95x2rnFK4q3EXBOOI=; b=U7Sn2YTS4d7Qphkjwf5DPdHLh/y/H24g/iuYTxf8ndto6aWfuL+8ajA+5WHMqGOJahU9M+2PnUmzHmIYwUUa/BZN88fdy21M3CRsEJCcXb+UgplDRSply4ZiGC19ejuSo/P2CjU5e2S8yWCqRMKvvpkajRC1HNxYKdqAtWo4fCI= Received: from BN6PR11MB1953.namprd11.prod.outlook.com (2603:10b6:404:105::14) by SJ1PR11MB6276.namprd11.prod.outlook.com (2603:10b6:a03:455::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.20; Tue, 14 Jun 2022 08:49:04 +0000 Received: from BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8]) by BN6PR11MB1953.namprd11.prod.outlook.com ([fe80::5cfe:8088:aa93:fce8%3]) with mapi id 15.20.5332.022; Tue, 14 Jun 2022 08:49:03 +0000 From: To: Subject: Re: [PATCH 07/16] iio: adc: at91-sama5d2_adc: simplify the code in at91_adc_read_info_raw() Thread-Topic: [PATCH 07/16] iio: adc: at91-sama5d2_adc: simplify the code in at91_adc_read_info_raw() Thread-Index: AQHYf8uZj7DB9JQzJEKqTek7NXQEjA== Date: Tue, 14 Jun 2022 08:49:03 +0000 Message-ID: <14fc4d7c-4ce7-e4ed-3e2e-400cbd16c071@microchip.com> References: <20220609083213.1795019-1-claudiu.beznea@microchip.com> <20220609083213.1795019-8-claudiu.beznea@microchip.com> <20220611185403.3eaf9b65@jic23-huawei> In-Reply-To: <20220611185403.3eaf9b65@jic23-huawei> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35411821-2c31-4410-0054-08da4de2bc08 x-ms-traffictypediagnostic: SJ1PR11MB6276:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KF3aSVKci4fE0ZqZNZBh5KxtK9tmdOeYkZCeCcD4lFOuKZvEHynIYtrcf2tWZMVHc6rElx8jAyls7F06jpatEN3tRJLYyuBQsKENfmeVkRnyj5T8diOgVKBK9SB8Ow7FNLbpgBkT7hb9Raoo+eXjbRgnJwRXheHz+oYzx65Dodf7s71oql7/6DnoqvWEmjMxGGlqAbR0A8jO/yZTZH+h3VouSON+wPzIqUNGGchVSXjmixWPkIGLG9PUU1jSRNjkKBTScHJTuHD9sWr1rJqM4zeWikvnCHNyA9i+QzpG+rVpe6iW4KUBLvh8FHHlU85rBLypETrbg7d/jY8ppybdp0mJVBnU5XST9Ffhcocx+OStFpqeyVlWr30cNlFz7iDRDZa0TQdeDHXesfqUTTGgQ+Ro/OMPvzdsn9GBl4XhNS3p0MGi6Y/uDXn30fZyiO2pgUqg1YnvzJXvBzULedieXp2yz6BHmVmzjzldPtgZM+pvnaQ0TnvA2oFvdTRnakM4+QUnULJ74NaIsrZtFz1krwIB3RPFNneEd26JQ6UrZ+LP2P7fqQhZz+RoN7aMPOsoXmnd63M+Th140pqOUl+0R3y941+EtcN3sneik8MzrMrtW+J/VLLSNusFyNEJQosOc+Kba+VvnE7DpOIuKpMyWY3MPP3Uh245VhzfcywatV4AG/kzXXJO2ZQeJTA0pSdu0Mxgfpd77a9XVmBuKXGiD7lVtTGOPGsKhPSG5TdC+I8MeO2TWQ+9mqltGi5ZISdJbRZI2eMIi8lMS9+kPffCTA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR11MB1953.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(66476007)(91956017)(66946007)(4326008)(64756008)(66446008)(8676002)(76116006)(66556008)(6486002)(7416002)(38100700002)(6512007)(8936002)(71200400001)(38070700005)(2906002)(6506007)(5660300002)(31696002)(26005)(53546011)(86362001)(36756003)(54906003)(316002)(186003)(83380400001)(122000001)(6916009)(508600001)(31686004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Nm1DWnFaSnZhd0pLV09DVWxvZnp0YkNqSFZvSjlnVEliTjZua2tScmZCVCth?= =?utf-8?B?bEZaYXEva2FHZGIyNEdiSG9seDJBSkhrMzFJL0FBakljTU9wSmY0Tm1TcldX?= =?utf-8?B?RDkyQ2dpRXd1bWZxcU82S3RqdFlncjc3WFZvNzBldUV6RVBlSi9weGErQnZh?= =?utf-8?B?UG1VYnI1ZEVzTDRKejZiQmppQlJOMUIxaEpERVB1dlVnbk01Y200WkpRZWNF?= =?utf-8?B?enFrNHR4eDRPSFgwUHArV3I2czNYSG1NMGkxa0hoenJJdjd4K3FYTUROQXZl?= =?utf-8?B?QVZraU9TK2hqbGFLNjF2NENqMDhabFNOdWloNTJvMkxrQmlrM3gxZGZ4WW5Z?= =?utf-8?B?TzRpOFpBcEpSZ25kb2VkK25XeG1mSVpKdTZkdTBjdzVHV05pVlAyUWVTeXRh?= =?utf-8?B?ZlVhTDIwRDZocDF4b1NERFNqc0FoclZrc0FVdE1hRjV2SURnT2h3WnE5b3lP?= =?utf-8?B?aEhxSUlQcER3RS9jcmcrcFdxZmZIeStJUEs2NTNrTXJPS1BKRTlTWEhoVkhq?= =?utf-8?B?QWxkSFFzVEZnTG9PRi8zYVpYSHZPeHZKMnRCSWFLZXcrbGpFWTBpWTY4VnpV?= =?utf-8?B?UURPRC9aZzdUdVlidTRQNnoraE5CeFkrdFliTFBCSyt5Zm9mVzZSTDlxUWZT?= =?utf-8?B?WmM3Yk80dFFhbzhqMkQyUnp6VFJ2cE9aRHZjQ0d4NUNNeHVtZjhxa1ZlczBw?= =?utf-8?B?WTNPVXRmZHhXOHlxdk1kMWV5R0o2QnlndEZYMVk4SXdMWVJKTHBaRkFpN2Z1?= =?utf-8?B?MWVqejdEMWFBSis2YzgvTEhuZnRaQmpmU2tCVWxsUjNtNVFQbFYzdFNXZ0NR?= =?utf-8?B?SklmcEdaNFVtOG9ITXVmVmJXZXdOV3JxbUNiaEF2N3FXTU9FTzdQYlVwUXpO?= =?utf-8?B?ZHdqZGlOYUtzYzdIc1pXVVlpSVRzRGowcWdUZURqaktmSFVLR3JEMFNub1pL?= =?utf-8?B?NUVteXlmd0hSNWpvYmRta3N1Z1l5WjgxUnRMd0xERWQ0ZnhVMGI2RGgvNFNN?= =?utf-8?B?b2dhL1ZkQUFZUHlqVSs1cm12clFGdDI3TElaNmRiTEZyWThoRkJjZjZoVVlZ?= =?utf-8?B?YzBKdGQ3SFl1dVc2Z3VrbmR3cmhaQzdSYTc0aHF2VytCb0pvQVc2K09HSTMw?= =?utf-8?B?OHVNUXdvS3g5ZDZpd2RrODMrQ29JUFB5SnNvNFhvMEc5SjFJSGlGUjgxSTY4?= =?utf-8?B?VGNGUE5ZZE9RdHIyMzYwM2l0cUFSeU81QzFnUTFweTJpWWxvZHFqWEJKQkVC?= =?utf-8?B?ODhmbUJHTDZNZWtrYktOeVlmZWhXSzRZeW92ZnpYRWpORnJxQ2hvems2OUdK?= =?utf-8?B?NHR1d2NhblY0bCswamxuVitIRElQaTU3ODZUdEZUaWlJODVGZGtKWHAwenpR?= =?utf-8?B?OGMvbWZObWtlYWRRdjRDbklOeXF0aHZSTm9XQkdjNy9oZWUySTIvbElCUnpM?= =?utf-8?B?V1VXc2M1RURRYzdDZ0dscml6ZG5lUy9LOUxPWUxFYjJIbS9PYjd3SVFDaWh5?= =?utf-8?B?eExmbkNuZTQxT3IrWEM5cklXZ2NoVDlTemc0MlhpanljR3ljQWdFaUtNZ25k?= =?utf-8?B?WHhaNWV2dVduZFRWV2ZwNWllZmtRRHc1NHdSbHpMYUhIS0pOMG5wUDdUTTE3?= =?utf-8?B?TWZORnE1eU9PeU1mL2hsR08yZkt1UXRlN1ZzaDg2RnFrQ0YzS2xkaTROWWdv?= =?utf-8?B?M0lPSUUxbUFVQVlyckc3UzJxTEtsWEp0MXVzOHdEeWdqQTVQSWorb3JhK3pw?= =?utf-8?B?TUt4L0kxV1JBY3hBMHlaRnR5ZUwwYnZFTmF1UkRLWW1WUjJTeTl4c0pXZ1F6?= =?utf-8?B?M1JvTk15enBkb0F2d0lOZWY2V3pVaEF0aW0zM2MyaTh5aEp2eDBRdE9rMGpN?= =?utf-8?B?MTZiL2dKVGROOEhhU2h1WFZXY00wTk9GWXpsZ1RrSFhyWEJLTk1pSEFDSzVp?= =?utf-8?B?c0V2Vm0xZFRMdklaRkpLdFVyVGtGN2dnL2tyNVQ1V1lRL0xYc2hmbHB0RVdF?= =?utf-8?B?RTE3UXMwc2ZBaHZpejNncnNCY1diZHVkSGRidlZUOUZ3UnFwNHRFeEwyVVFs?= =?utf-8?B?NXdVSFB3YVcyK0I0WTVTQWtsbGR3NnVuQWE3VklJREFWRjF1ejBWNFZpNDNv?= =?utf-8?B?ZGUreWtyeHJvVEEyZmtqUkgvZGR0U0dqaG42NldoZUR3T1NnRVQ3aFp4ZHgy?= =?utf-8?B?N2hlcXpLbXlhOUxWMDBRVnZ0RDdoZjU2QlVDM3ZMOGRNK0lZVHlpSHZSK09Q?= =?utf-8?B?WVd0aUpLeVlaOWFvSXAyd3FuY2tyZEJTc0dZS0pTa2pJcS82NEc1Z3pZQkZQ?= =?utf-8?B?Ui9EMEVYcE9wRjluczJlWEJ4Y0FHNlV5Q0swVm9BVHdKWG1qTkdCblNYTHRh?= =?utf-8?Q?3UCCohTyk0YWNRrc=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1953.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35411821-2c31-4410-0054-08da4de2bc08 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2022 08:49:03.8310 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c/y1TIEwjc2MqiVUlq+DUJBvdlYVn1rFIWAVHserBYB9nvWPtzdcBsmAJjWrQ0lvf7X1vivNOl8FnU10pgZzD+XKZgi2dN+1iCFdotYjHJM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6276 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220614_014913_451181_1A6C6A2A X-CRM114-Status: GOOD ( 30.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, lars@metafoo.de, ludovic.desroches@atmel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Eugen.Hristev@microchip.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.06.2022 20:54, Jonathan Cameron wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Thu, 9 Jun 2022 11:32:04 +0300 > Claudiu Beznea wrote: > >> Simplify a bit the code in at91_adc_read_info_raw() by reducing the >> number of lines of code. >> >> Signed-off-by: Claudiu Beznea > > I'm not convinced this is worth while, but there are some lesser > steps visible in this patch that probably are. > > Given your earlier reorg to move at01_adc_adjust_val_osr() under the locks, > you can now move the locks to the caller, thus not needing to handle them > separately in all the exit paths. OK, I'll give it a try. With this, would you prefer to still keep this patch? > >> --- >> drivers/iio/adc/at91-sama5d2_adc.c | 35 +++++++++--------------------- >> 1 file changed, 10 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c >> index b52f1020feaf..fbb98e216e70 100644 >> --- a/drivers/iio/adc/at91-sama5d2_adc.c >> +++ b/drivers/iio/adc/at91-sama5d2_adc.c >> @@ -1576,6 +1576,7 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev, >> struct iio_chan_spec const *chan, int *val) >> { >> struct at91_adc_state *st = iio_priv(indio_dev); >> + int (*fn)(struct at91_adc_state *, int, u16 *) = NULL; >> u16 tmp_val; >> int ret; >> >> @@ -1583,29 +1584,18 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev, >> * Keep in mind that we cannot use software trigger or touchscreen >> * if external trigger is enabled >> */ >> - if (chan->type == IIO_POSITIONRELATIVE) { >> - ret = iio_device_claim_direct_mode(indio_dev); >> - if (ret) >> - return ret; > > You can drop this out of the if statements as it happens in all paths. > Or even better, move it to the caller.. > >> - mutex_lock(&st->lock); >> - >> - ret = at91_adc_read_position(st, chan->channel, >> - &tmp_val); > > huh? ret not checked? Yep, this should have been missed... > >> - *val = tmp_val; >> - ret = at91_adc_adjust_val_osr(st, val); > Sure this is duplicated, but meh it's only a few lines. > > >> - mutex_unlock(&st->lock); >> - iio_device_release_direct_mode(indio_dev); > > this early release (compared to the long path) is the only bit really > gets duplicated in all paths.. > >> + if (chan->type == IIO_POSITIONRELATIVE) >> + fn = at91_adc_read_position; >> + if (chan->type == IIO_PRESSURE) >> + fn = at91_adc_read_pressure; >> >> + ret = iio_device_claim_direct_mode(indio_dev); >> + if (ret) >> return ret; >> - } >> - if (chan->type == IIO_PRESSURE) { > this should always have been an else if () as the chan->type couldn't be both. > >> - ret = iio_device_claim_direct_mode(indio_dev); >> - if (ret) >> - return ret; >> - mutex_lock(&st->lock); > hence this lot can be shared with the above. To be sure of what I've understood correctly: in the end you prefer to have a patch with the point you suggested rather then the initial patch? Thank you, Claudiu Beznea > >> + mutex_lock(&st->lock); >> >> - ret = at91_adc_read_pressure(st, chan->channel, >> - &tmp_val); >> + if (fn) { >> + ret = fn(st, chan->channel, &tmp_val); >> *val = tmp_val; >> ret = at91_adc_adjust_val_osr(st, val); >> mutex_unlock(&st->lock); >> @@ -1616,11 +1606,6 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev, >> >> /* in this case we have a voltage channel */ >> >> - ret = iio_device_claim_direct_mode(indio_dev); >> - if (ret) >> - return ret; >> - mutex_lock(&st->lock); >> - >> st->chan = chan; >> >> at91_adc_cor(st, chan); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel