linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: anup.patel@broadcom.com (Anup Patel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] vfio: Allow No-IOMMU mode for IOMMUs with bypass capability
Date: Wed, 19 Jul 2017 15:03:57 +0530	[thread overview]
Message-ID: <1500456838-18405-5-git-send-email-anup.patel@broadcom.com> (raw)
In-Reply-To: <1500456838-18405-1-git-send-email-anup.patel@broadcom.com>

Not allowing No-IOMMU mode for devices already having
iommu_ops on their bus is little conservative.

We now have IOMMU (such as ARM SMMU) which can bypass
transcations for which IOMMU domain is not configured
hence No-IOMMU mode should not be allowed when iommu_ops
are available and IOMMU_CAP_BYPASS is not available.

Signed-off-by: Anup Patel <anup.patel@broadcom.com>
---
 drivers/vfio/vfio.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
index 330d505..61f3807 100644
--- a/drivers/vfio/vfio.c
+++ b/drivers/vfio/vfio.c
@@ -124,11 +124,18 @@ struct iommu_group *vfio_iommu_group_get(struct device *dev)
 #ifdef CONFIG_VFIO_NOIOMMU
 	/*
 	 * With noiommu enabled, an IOMMU group will be created for a device
-	 * that doesn't already have one and doesn't have an iommu_ops on their
-	 * bus.  We set iommudata simply to be able to identify these groups
+	 * that:
+	 * 1. Doesn't already have IOMMU group
+	 * 2. Doesn't have an iommu_ops on their bus
+	 * 3. Doesn't have transaction bypass capability if iommu_ops
+	 * is available on their bus
+	 *
+	 * We set iommudata simply to be able to identify these groups
 	 * as special use and for reclamation later.
 	 */
-	if (group || !noiommu || iommu_present(dev->bus))
+	if (group || !noiommu ||
+	    (iommu_present(dev->bus) &&
+	     !iommu_capable(dev->bus, IOMMU_CAP_BYPASS)))
 		return group;
 
 	group = iommu_group_alloc();
-- 
2.7.4

  parent reply	other threads:[~2017-07-19  9:33 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-19  9:33 [PATCH 0/5] FlexRM support in VFIO platform Anup Patel
2017-07-19  9:33 ` [PATCH 1/5] iommu: Add capability IOMMU_CAP_BYPASS Anup Patel
2017-07-19 10:58   ` Robin Murphy
2017-07-19 11:19     ` Anup Patel
2017-07-19 11:23       ` Will Deacon
2017-07-19 11:26         ` Anup Patel
2017-07-19 11:29           ` Robin Murphy
2017-07-19 11:30           ` Will Deacon
2017-07-19 11:33             ` Anup Patel
2017-07-19  9:33 ` [PATCH 2/5] iommu/arm-smmu: add IOMMU_CAP_BYPASS to the ARM SMMU driver Anup Patel
2017-07-19 10:59   ` Robin Murphy
2017-07-19  9:33 ` [PATCH 3/5] iommu/arm-smmu-v3: add IOMMU_CAP_BYPASS to the ARM SMMUv3 driver Anup Patel
2017-07-19 11:00   ` Robin Murphy
2017-07-19 11:23     ` Anup Patel
2017-07-19 11:25       ` Will Deacon
2017-07-19 11:31         ` Anup Patel
2017-07-19 11:33           ` Will Deacon
2017-07-19 11:39             ` Anup Patel
2017-07-19 11:53               ` Will Deacon
2017-07-20  4:02                 ` Anup Patel
2017-07-20  9:10                   ` Will Deacon
2017-07-20 11:08                     ` Anup Patel
2017-07-20 11:17                       ` Will Deacon
2017-07-20 11:17                     ` Robin Murphy
2017-07-24 17:16                       ` Alex Williamson
2017-07-24 17:23                         ` Robin Murphy
2017-07-24 19:06                           ` Alex Williamson
2017-07-25  8:59                             ` Anup Patel
2017-07-19  9:33 ` Anup Patel [this message]
2017-07-19  9:33 ` [PATCH 5/5] vfio: platform: reset: Add Broadcom FlexRM reset module Anup Patel
2017-07-19 16:50   ` Scott Branden
2017-07-20  4:05     ` Anup Patel
2017-07-19 10:57 ` [PATCH 0/5] FlexRM support in VFIO platform Robin Murphy
2017-07-19 11:17   ` Anup Patel
2017-07-19 11:25     ` Robin Murphy
2017-07-19 11:28       ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500456838-18405-5-git-send-email-anup.patel@broadcom.com \
    --to=anup.patel@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).