public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: dts: mt7623: Add SD-card to bananapi-r2
Date: Wed, 2 Aug 2017 15:27:20 +0800	[thread overview]
Message-ID: <1501658840.29348.7.camel@mtkswgap22> (raw)
In-Reply-To: <20170801134009.14349-2-matthias.bgg@gmail.com>

On Tue, 2017-08-01 at 15:40 +0200, Matthias Brugger wrote:
> The bananapi-r2 board has an SD-card controller, enable
> the device in the devicetree.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 9f3e6ddd545f..d457544c3a1d 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -179,6 +179,19 @@
>  	status = "okay";
>  };
>  
> +&mmc1 {
> +	pinctrl-names = "default", "state_uhs";
> +	pinctrl-0 = <&mmc1_pins_default>;
> +	pinctrl-1 = <&mmc1_pins_uhs>;
> +	status = "okay";
> +	bus-width = <4>;
> +	max-frequency = <50000000>;
> +	cap-sd-highspeed;
> +	cd-gpios = <&pio 261 0>;
> +	vmmc-supply = <&mt6323_vmch_reg>;
> +	vqmmc-supply = <&mt6323_vmc_reg>;
> +};
> +
>  &pio {
>  	cir_pins_a:cir at 0 {
>  		pins_cir {

I can base the patch to fixup and add something in the next version 

such as

1) to add property with extra wp-gpios

2) to correct power source from mt6323_vio18_reg instead of
mt6323_vmc_reg based on the schematic

3) to enable mmc0 that is used as emmc


&mmc0 {
        pinctrl-names = "default", "state_uhs";
        pinctrl-0 = <&mmc0_pins_default>;
        pinctrl-1 = <&mmc0_pins_uhs>;
        status = "okay";
        bus-width = <8>;
        max-frequency = <50000000>;
        cap-mmc-highspeed;
        vmmc-supply = <&mt6323_vemc3v3_reg>;
        vqmmc-supply = <&mt6323_vio18_reg>;
        non-removable;
};


&mmc1 {
        pinctrl-names = "default", "state_uhs";
        pinctrl-0 = <&mmc1_pins_default>;
        pinctrl-1 = <&mmc1_pins_uhs>;
        status = "okay";
        bus-width = <4>;
        max-frequency = <50000000>;
        cap-sd-highspeed;
        cd-gpios = <&pio 261 0>;
        wp-gpios = <&pio 29 0>;
        vmmc-supply = <&mt6323_vmch_reg>;
        vqmmc-supply = <&mt6323_vio18_reg>;
};


those upper nodes could make sdhc sd card/emmc workable

      parent reply	other threads:[~2017-08-02  7:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170801134009.14349-1-matthias.bgg@gmail.com>
2017-08-02  7:20 ` [PATCH 1/2] arm: dts: mt7623: fix mmc interrupt assignment Sean Wang
     [not found] ` <20170801134009.14349-2-matthias.bgg@gmail.com>
2017-08-02  7:27   ` Sean Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1501658840.29348.7.camel@mtkswgap22 \
    --to=sean.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox