linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: david.wu@rock-chips.com (David Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/7] pwm: rockchip: Remove the judge from return value of pwm_config
Date: Tue,  8 Aug 2017 23:38:30 +0800	[thread overview]
Message-ID: <1502206715-24174-3-git-send-email-david.wu@rock-chips.com> (raw)
In-Reply-To: <1502206715-24174-1-git-send-email-david.wu@rock-chips.com>

It seems the rockchip_pwm_config always returns the result 0,
so remove the judge.

Signed-off-by: David Wu <david.wu@rock-chips.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
---
 drivers/pwm/pwm-rockchip.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index ac3cd5e..33bbb5a 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -165,7 +165,7 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip,
 	clk_disable(pc->pclk);
 }
 
-static int rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
+static void rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 			       int duty_ns, int period_ns)
 {
 	struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip);
@@ -188,8 +188,6 @@ static int rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
 
 	writel(period, pc->base + pc->data->regs.period);
 	writel(duty, pc->base + pc->data->regs.duty);
-
-	return 0;
 }
 
 static int rockchip_pwm_enable(struct pwm_chip *chip,
@@ -236,13 +234,7 @@ static int rockchip_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 		enabled = false;
 	}
 
-	ret = rockchip_pwm_config(chip, pwm, state->duty_cycle, state->period);
-	if (ret) {
-		if (enabled != curstate.enabled)
-			rockchip_pwm_enable(chip, pwm, !enabled,
-				      state->polarity);
-		goto out;
-	}
+	rockchip_pwm_config(chip, pwm, state->duty_cycle, state->period);
 
 	if (state->enabled != enabled) {
 		ret = rockchip_pwm_enable(chip, pwm, state->enabled,
-- 
1.9.1

  parent reply	other threads:[~2017-08-08 15:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 15:38 [PATCH v3 0/7] Add rk3328 pwm support David Wu
2017-08-08 15:38 ` [PATCH v3 1/7] pwm: rockchip: Add APB and function both clocks support David Wu
2017-08-18 15:31   ` Thierry Reding
2017-08-08 15:38 ` David Wu [this message]
2017-08-18 15:32   ` [PATCH v3 2/7] pwm: rockchip: Remove the judge from return value of pwm_config Thierry Reding
2017-08-18 16:28     ` Brian Norris
2017-08-21 11:29       ` David.Wu
2017-08-08 15:38 ` [PATCH v3 3/7] pwm: rockchip: Use pwm_apply instead of the pwm_enable David Wu
2017-08-18 15:36   ` Thierry Reding
2017-08-08 15:38 ` [PATCH v3 4/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config() David Wu
2017-08-18 15:40   ` Thierry Reding
2017-08-08 15:41 ` [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP David Wu
2017-08-18 15:43   ` Thierry Reding
2017-08-18 15:44   ` Thierry Reding
2017-08-08 15:42 ` [PATCH v3 6/7] pwm: rockchip: Add rk3328 pwm support David Wu
2017-08-18 15:45   ` Thierry Reding
2017-08-08 15:43 ` [PATCH v3 7/7] arm64: dts: rockchip: Add pwm nodes for rk3328 David Wu
2017-08-18 23:06   ` Heiko Stuebner
2017-08-14  2:46 ` [PATCH v3 0/7] Add rk3328 pwm support David.Wu
2017-08-16 10:49 ` David.Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502206715-24174-3-git-send-email-david.wu@rock-chips.com \
    --to=david.wu@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).