From: jlu@pengutronix.de (Jan Lübbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/4] dt-bindings: add "reduced-width" property for Armada XP SDRAM controller
Date: Fri, 11 Aug 2017 11:34:27 +0200 [thread overview]
Message-ID: <1502444067.1333.7.camel@pengutronix.de> (raw)
In-Reply-To: <4935472b6a44447fa764fa811a645b9f@svr-chch-ex1.atlnz.lc>
On Thu, 2017-08-10 at 21:17 +0000, Chris Packham wrote:
> On 11/08/17 08:38, Rob Herring wrote:
> > On Mon, Aug 07, 2017 at 01:46:39PM +1200, Chris Packham wrote:
[...]??
> > > +Optional properties:
> > > + - marvell,reduced-width: some SoCs that use this SDRAM controller have
> > > +???a reduced pin count. On such systems "full" width is 32-bits and
> > > +???"half" width is 16-bits. Set this property to indicate that the SoC
> > > +???used is such a system.
> >
> > Maybe you should just state what the width is.
>
> Specifying a number like 64/32/16 is done in for some other properties I?
> dismissed that because what this is about how we interpret a?
> pin-strapping option. I guess "max-width = <64>;" and "max-width =?
> <32>"; would achieve the same.
>
> > Or your compatible string should just be specific enough to know the
> > width.
>
> I decided against a new compatible sting that because the IP block?
> really is the Armada-XP one and the existing compatible string is used?
> in other places (using multiple compatible strings would solve that).
>
> I'm not too fussed which of the 3 options are used. Is there any?
> particular preference?
I'd prefer a specific compatible string, as it would avoid adding even
more properties if further difference turn up.
Rob, I seem to remember that some drivers match the top-level
compatible against a list of SoC variants to detect SoC-dependent
features in a generic IP block. Is that something you'd prefer instead?
Regards,
Jan
next prev parent reply other threads:[~2017-08-11 9:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 1:46 [RESEND PATCH 0/4] EDAC: support reduce bus width on 98dx3236 Chris Packham
2017-08-07 1:46 ` [RESEND PATCH 1/4] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board Chris Packham
2017-08-07 1:46 ` [RESEND PATCH 2/4] dt-bindings: add "reduced-width" property for Armada XP SDRAM controller Chris Packham
2017-08-10 20:38 ` Rob Herring
2017-08-10 21:17 ` Chris Packham
2017-08-11 9:34 ` Jan Lübbe [this message]
2017-08-07 1:46 ` [RESEND PATCH 3/4] ARM: dts: mvebu: set reduced-width property for SDRAM on 98dx3236 Chris Packham
2017-08-07 1:46 ` [RESEND PATCH 4/4] EDAC: add support for reduced-width Armada-XP SDRAM Chris Packham
2017-08-11 9:14 ` Borislav Petkov
2017-08-13 21:28 ` Chris Packham
2017-09-20 13:04 ` [RESEND PATCH 0/4] EDAC: support reduce bus width on 98dx3236 Gregory CLEMENT
2017-09-20 15:56 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502444067.1333.7.camel@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).