* [PATCH] ste_dma40: make stedma40_chan_cfg const
@ 2017-08-13 13:23 Bhumika Goyal
2017-08-14 12:40 ` Linus Walleij
2017-08-21 16:27 ` Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-08-13 13:23 UTC (permalink / raw)
To: linux-arm-kernel
Make these const as they are only used during a copy operation.
Done using Coccinelle.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/dma/ste_dma40.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
index c3052fb..f4fab41 100644
--- a/drivers/dma/ste_dma40.c
+++ b/drivers/dma/ste_dma40.c
@@ -79,7 +79,7 @@
};
/* Default configuration for physcial memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_phy = {
.mode = STEDMA40_MODE_PHYSICAL,
.dir = DMA_MEM_TO_MEM,
@@ -93,7 +93,7 @@
};
/* Default configuration for logical memcpy */
-static struct stedma40_chan_cfg dma40_memcpy_conf_log = {
+static const struct stedma40_chan_cfg dma40_memcpy_conf_log = {
.mode = STEDMA40_MODE_LOGICAL,
.dir = DMA_MEM_TO_MEM,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ste_dma40: make stedma40_chan_cfg const
2017-08-13 13:23 [PATCH] ste_dma40: make stedma40_chan_cfg const Bhumika Goyal
@ 2017-08-14 12:40 ` Linus Walleij
2017-08-21 16:27 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2017-08-14 12:40 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Aug 13, 2017 at 3:23 PM, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Make these const as they are only used during a copy operation.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ste_dma40: make stedma40_chan_cfg const
2017-08-13 13:23 [PATCH] ste_dma40: make stedma40_chan_cfg const Bhumika Goyal
2017-08-14 12:40 ` Linus Walleij
@ 2017-08-21 16:27 ` Vinod Koul
2017-08-21 16:40 ` Bhumika Goyal
1 sibling, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2017-08-21 16:27 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
> Make these const as they are only used during a copy operation.
> Done using Coccinelle.
Pls make sure you use the right subsystem tags, hint, you cna check git log
on that subsystem/file to find the right ones
Applied after fixing the tags, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ste_dma40: make stedma40_chan_cfg const
2017-08-21 16:27 ` Vinod Koul
@ 2017-08-21 16:40 ` Bhumika Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Bhumika Goyal @ 2017-08-21 16:40 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Aug 21, 2017 at 9:57 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Sun, Aug 13, 2017 at 06:53:04PM +0530, Bhumika Goyal wrote:
>> Make these const as they are only used during a copy operation.
>> Done using Coccinelle.
>
> Pls make sure you use the right subsystem tags, hint, you cna check git log
> on that subsystem/file to find the right ones
>
Thanks for the note. I will be more careful next time.
Thanks,
Bhumika
> Applied after fixing the tags, thanks
>
> --
> ~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-21 16:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-13 13:23 [PATCH] ste_dma40: make stedma40_chan_cfg const Bhumika Goyal
2017-08-14 12:40 ` Linus Walleij
2017-08-21 16:27 ` Vinod Koul
2017-08-21 16:40 ` Bhumika Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).