From: rui.zhang@intel.com (Zhang Rui)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver
Date: Tue, 15 Aug 2017 14:48:41 +0800 [thread overview]
Message-ID: <1502779721.2591.4.camel@intel.com> (raw)
In-Reply-To: <95da51df3cadbb05f721f2e5b8d59f8d@milecki.pl>
On Tue, 2017-08-15 at 08:42 +0200, Rafa? Mi?ecki wrote:
> On 2017-08-15 08:08, Zhang Rui wrote:
> >
> > >
> > > diff --git a/drivers/thermal/broadcom/Kconfig
> > > b/drivers/thermal/broadcom/Kconfig
> > > index 42c098e..c106a15 100644
> > > --- a/drivers/thermal/broadcom/Kconfig
> > > +++ b/drivers/thermal/broadcom/Kconfig
> > > @@ -6,6 +6,13 @@ config BCM2835_THERMAL
> > > ? help
> > > ? ??Support for thermal sensors on Broadcom bcm2835 SoCs.
> > > ?
> > > +config BRCMSTB_THERMAL
> > > + tristate "Broadcom STB AVS TMON thermal driver"
> > > + depends on ARCH_BRCMSTB || COMPILE_TEST
> > > + help
> > > + ??Enable this driver if you have a Broadcom STB SoC and
> > > would like
> > > + ??thermal framework support.
> > > +
> > I don't understand why I got the following checkpatch warning
> >
> > WARNING: please write a paragraph that describes the config symbol
> > fully
> > #73: FILE: drivers/thermal/broadcom/Kconfig:9:
> > +config BRCMSTB_THERMAL
> >
> > I didn't see this for other Kconfig changes.
> It's because your help message is only 2 lines long (instead of 3).
>
> Some (many?) maintainers aren't pedantic about that, a common sense?
> should
> be applied ;)
thanks for explaining.
Patch 1 and 2 queued for next merge window.
-rui
next prev parent reply other threads:[~2017-08-15 6:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 22:02 [PATCH v4 0/4] thermal: add brcmstb AVS TMON driver Markus Mayer
2017-08-09 22:02 ` [PATCH v4 1/4] Documentation: devicetree: add binding for Broadcom STB AVS TMON Markus Mayer
2017-08-17 15:10 ` Rob Herring
2017-08-09 22:02 ` [PATCH v4 2/4] thermal: add brcmstb AVS TMON driver Markus Mayer
2017-08-15 6:08 ` Zhang Rui
2017-08-15 6:42 ` Rafał Miłecki
2017-08-15 6:48 ` Zhang Rui [this message]
2017-09-24 21:11 ` Florian Fainelli
2017-09-26 3:02 ` Zhang, Rui
2017-09-26 4:13 ` Florian Fainelli
2017-09-26 6:17 ` Zhang, Rui
2017-09-26 21:36 ` Markus Mayer
2017-08-09 22:02 ` [PATCH v4 3/4] ARM: multi_v7_defconfig: add CONFIG_BRCMSTB_THERMAL Markus Mayer
2017-08-15 17:23 ` Florian Fainelli
2017-08-09 22:02 ` [PATCH v4 4/4] arm64: defconfig: " Markus Mayer
2017-08-15 17:24 ` Florian Fainelli
2017-08-11 5:35 ` [PATCH v4 0/4] thermal: add brcmstb AVS TMON driver Zhang Rui
2017-08-13 4:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502779721.2591.4.camel@intel.com \
--to=rui.zhang@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).