From: Eugeniy.Paltsev@synopsys.com (Eugeniy Paltsev)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] reset: stm32: use the reset-simple driver
Date: Wed, 16 Aug 2017 12:52:01 +0000 [thread overview]
Message-ID: <1502887920.2586.35.camel@synopsys.com> (raw)
In-Reply-To: <20170816094701.30678-4-p.zabel@pengutronix.de>
Hi Philipp,
On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote:
> The reset-simple driver can be used without changes.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> [snip]
>
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -120,6 +120,7 @@ static const struct reset_simple_devdata
> reset_simple_active_low = {
> ?
> ?static const struct of_device_id reset_simple_dt_ids[] = {
> ? { .compatible = "altr,rst-mgr", .data =
> &reset_simple_socfpga },
> + { .compatible = "st,stm32-rcc", },
> ? { .compatible = "allwinner,sun6i-a31-clock-reset",
> ? .data = &reset_simple_active_low },
> ? { /* sentinel */ },
What about adding generic compatible strings for future use?
I mean next:
--------------------->8---------------------
static const struct of_device_id reset_simple_dt_ids[] = {
{ .compatible = "reset-simple-active-low",
.data = &reset_simple_active_low },
{ .compatible = "reset-simple-active-high",
.data = &reset_simple_active_high },
/* ... */
{ /* sentinel */ },
};
static const struct reset_simple_devdata reset_simple_active_high = {
.active_low = false,
};
static const struct reset_simple_devdata reset_simple_active_low = {
.active_low = true,
};
--------------------->8---------------------
--
?Eugeniy Paltsev
next prev parent reply other threads:[~2017-08-16 12:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 9:46 [PATCH v3 0/5] Unify simple reset drivers Philipp Zabel
2017-08-16 9:46 ` [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Philipp Zabel
2017-08-16 11:30 ` Andre Przywara
2017-08-16 12:12 ` Andreas Färber
2017-08-16 15:11 ` Philipp Zabel
2017-08-16 15:17 ` Andre Przywara
2017-08-16 16:41 ` Andreas Färber
2017-08-16 16:46 ` Andre Przywara
2017-08-16 20:46 ` Alexandru Gagniuc
2017-08-16 9:46 ` [PATCH v3 2/5] reset: socfpga: use the reset-simple driver Philipp Zabel
2017-08-16 20:46 ` Alexandru Gagniuc
2017-08-21 8:45 ` Philipp Zabel
2017-08-16 9:46 ` [PATCH v3 3/5] reset: stm32: " Philipp Zabel
2017-08-16 12:52 ` Eugeniy Paltsev [this message]
2017-08-16 12:55 ` Andreas Färber
2017-08-16 13:03 ` Andre Przywara
2017-08-16 20:50 ` Alexandru Gagniuc
2017-08-16 20:52 ` Andreas Färber
2017-08-16 20:55 ` Alexandru Gagniuc
2017-08-17 9:19 ` Andre Przywara
2017-08-21 8:38 ` Philipp Zabel
2017-08-29 8:39 ` [v3,3/5] " Gabriel FERNANDEZ
2017-08-16 9:47 ` [PATCH v3 4/5] reset: zx2967: " Philipp Zabel
2017-08-16 20:50 ` Alexandru Gagniuc
2017-08-16 9:47 ` [PATCH v3 5/5] reset: simple: read back to make sure changes are applied Philipp Zabel
2017-08-16 21:00 ` Alexandru Gagniuc
2017-08-21 8:21 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502887920.2586.35.camel@synopsys.com \
--to=eugeniy.paltsev@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).