* [PATCH v2 0/2] Add usb3 ctrl node on RK3328 SoCs and enable usb3 host on RK3328 evb @ 2017-08-17 7:54 William Wu 2017-08-17 7:54 ` [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs William Wu 2017-08-17 7:54 ` [PATCH v2 2/2] arm64: dts: rockchip: enable usb3 for RK3328 evaluation board William Wu 0 siblings, 2 replies; 5+ messages in thread From: William Wu @ 2017-08-17 7:54 UTC (permalink / raw) To: linux-arm-kernel This series add support for usb3 controller on RK3328 SoCs. This series don't include usb3 phy patches, and I will try to submit usb3 phy patches individually later. Tested on RK3328 evaluation board. William Wu (2): arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs arm64: dts: rockchip: enable usb3 for RK3328 evaluation board .../devicetree/bindings/usb/rockchip,dwc3.txt | 4 +++- arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 9 ++++++++ arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++ 3 files changed, 39 insertions(+), 1 deletion(-) -- 2.0.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs 2017-08-17 7:54 [PATCH v2 0/2] Add usb3 ctrl node on RK3328 SoCs and enable usb3 host on RK3328 evb William Wu @ 2017-08-17 7:54 ` William Wu 2017-08-18 9:24 ` Heiko Stuebner 2017-08-17 7:54 ` [PATCH v2 2/2] arm64: dts: rockchip: enable usb3 for RK3328 evaluation board William Wu 1 sibling, 1 reply; 5+ messages in thread From: William Wu @ 2017-08-17 7:54 UTC (permalink / raw) To: linux-arm-kernel RK3328 has one USB 3.0 OTG controller which uses DWC_USB3 core's general architecture. It can act as static xHCI host controller, static device controller, USB 3.0/2.0 OTG basing on ID of USB3.0 PHY. Signed-off-by: William Wu <william.wu@rock-chips.com> --- Changes in v2: - Modify the dwc3 quirk "snps,tx-ipgap-linecheck-dis-quirk" to "snps,dis-tx-ipgap-linecheck-quirk" .../devicetree/bindings/usb/rockchip,dwc3.txt | 4 +++- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt index 0536a93..d6b2e47 100644 --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt @@ -1,7 +1,9 @@ Rockchip SuperSpeed DWC3 USB SoC controller Required properties: -- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC +- compatible: should be one of the following: + - "rockchip,rk3399-dwc3": for rk3399 SoC + - "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3": for rk3328 SoC - clocks: A list of phandle + clock-specifier pairs for the clocks listed in clock-names - clock-names: Should contain the following: diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index e6da0ce..14bd8f4 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -655,6 +655,33 @@ status = "disabled"; }; + usbdrd3: usb at ff600000 { + compatible = "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3"; + clocks = <&cru SCLK_USB3OTG_REF>, <&cru SCLK_USB3OTG_SUSPEND>, + <&cru ACLK_USB3OTG>; + clock-names = "ref_clk", "suspend_clk", + "bus_clk"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + status = "disabled"; + + usbdrd_dwc3: dwc3 at ff600000 { + compatible = "snps,dwc3"; + reg = <0x0 0xff600000 0x0 0x100000>; + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>; + dr_mode = "otg"; + phy_type = "utmi_wide"; + snps,dis_enblslpm_quirk; + snps,dis-u2-freeclk-exists-quirk; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + snps,dis-del-phy-power-chg-quirk; + snps,dis-tx-ipgap-linecheck-quirk; + status = "disabled"; + }; + }; + gic: interrupt-controller at ff811000 { compatible = "arm,gic-400"; #interrupt-cells = <3>; -- 2.0.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs 2017-08-17 7:54 ` [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs William Wu @ 2017-08-18 9:24 ` Heiko Stuebner 2017-08-21 11:35 ` wlf 0 siblings, 1 reply; 5+ messages in thread From: Heiko Stuebner @ 2017-08-18 9:24 UTC (permalink / raw) To: linux-arm-kernel Hi William, Am Donnerstag, 17. August 2017, 15:54:49 CEST schrieb William Wu: > RK3328 has one USB 3.0 OTG controller which uses DWC_USB3 > core's general architecture. It can act as static xHCI host > controller, static device controller, USB 3.0/2.0 OTG basing > on ID of USB3.0 PHY. > > Signed-off-by: William Wu <william.wu@rock-chips.com> > --- > Changes in v2: > - Modify the dwc3 quirk "snps,tx-ipgap-linecheck-dis-quirk" to > "snps,dis-tx-ipgap-linecheck-quirk" > > .../devicetree/bindings/usb/rockchip,dwc3.txt | 4 +++- > arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++ > 2 files changed, 30 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt > index 0536a93..d6b2e47 100644 > --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt > @@ -1,7 +1,9 @@ > Rockchip SuperSpeed DWC3 USB SoC controller > > Required properties: > -- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC > +- compatible: should be one of the following: > + - "rockchip,rk3399-dwc3": for rk3399 SoC > + - "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3": for rk3328 SoC > - clocks: A list of phandle + clock-specifier pairs for the > clocks listed in clock-names > - clock-names: Should contain the following: This probably shouldn't be part of the patch adding the dts node, but instead should be a separate patch and should either go through some usb tree or at least get an Ack from usb maintainers (Felipe Balbi and/or Greg Kroah Hartman), so you should definitly include them into your recipient list. Heiko ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs 2017-08-18 9:24 ` Heiko Stuebner @ 2017-08-21 11:35 ` wlf 0 siblings, 0 replies; 5+ messages in thread From: wlf @ 2017-08-21 11:35 UTC (permalink / raw) To: linux-arm-kernel Dear Heiko, ? 2017?08?18? 17:24, Heiko Stuebner ??: > Hi William, > > Am Donnerstag, 17. August 2017, 15:54:49 CEST schrieb William Wu: >> RK3328 has one USB 3.0 OTG controller which uses DWC_USB3 >> core's general architecture. It can act as static xHCI host >> controller, static device controller, USB 3.0/2.0 OTG basing >> on ID of USB3.0 PHY. >> >> Signed-off-by: William Wu <william.wu@rock-chips.com> >> --- >> Changes in v2: >> - Modify the dwc3 quirk "snps,tx-ipgap-linecheck-dis-quirk" to >> "snps,dis-tx-ipgap-linecheck-quirk" >> >> .../devicetree/bindings/usb/rockchip,dwc3.txt | 4 +++- >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 27 ++++++++++++++++++++++ >> 2 files changed, 30 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt >> index 0536a93..d6b2e47 100644 >> --- a/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt >> +++ b/Documentation/devicetree/bindings/usb/rockchip,dwc3.txt >> @@ -1,7 +1,9 @@ >> Rockchip SuperSpeed DWC3 USB SoC controller >> >> Required properties: >> -- compatible: should contain "rockchip,rk3399-dwc3" for rk3399 SoC >> +- compatible: should be one of the following: >> + - "rockchip,rk3399-dwc3": for rk3399 SoC >> + - "rockchip,rk3328-dwc3", "rockchip,rk3399-dwc3": for rk3328 SoC >> - clocks: A list of phandle + clock-specifier pairs for the >> clocks listed in clock-names >> - clock-names: Should contain the following: > This probably shouldn't be part of the patch adding the dts node, but > instead should be a separate patch and should either go through some > usb tree or at least get an Ack from usb maintainers (Felipe Balbi and/or > Greg Kroah Hartman), so you should definitly include them into your > recipient list. Thanks for your suggestion. I will submit two patches separately, and add usb maintainers in the recipient list. > > > Heiko > > > > -- ??? William.Wu ?????????????89????A?21?? No.21 Building, A District, No.89,software Boulevard Fuzhou,Fujian, PRC ??: 13685012275 ??: 0591-83991906-8520 ??:wulf at rock-chips.com ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] arm64: dts: rockchip: enable usb3 for RK3328 evaluation board 2017-08-17 7:54 [PATCH v2 0/2] Add usb3 ctrl node on RK3328 SoCs and enable usb3 host on RK3328 evb William Wu 2017-08-17 7:54 ` [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs William Wu @ 2017-08-17 7:54 ` William Wu 1 sibling, 0 replies; 5+ messages in thread From: William Wu @ 2017-08-17 7:54 UTC (permalink / raw) To: linux-arm-kernel Rockchip's RK3328 evaluation board has one USB 3.0 OTG controller, we enable it and set it act as static xHCI host controller to support USB 3.0 HOST on RK3328 evaluation board. Signed-off-by: William Wu <william.wu@rock-chips.com> --- Changes in v2: - None arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts index e7db0dc..fedea73 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts @@ -83,3 +83,12 @@ &usb_host0_ohci { status = "okay"; }; + +&usbdrd3 { + status = "okay"; +}; + +&usbdrd_dwc3 { + dr_mode = "host"; + status = "okay"; +}; -- 2.0.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-21 11:35 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-08-17 7:54 [PATCH v2 0/2] Add usb3 ctrl node on RK3328 SoCs and enable usb3 host on RK3328 evb William Wu 2017-08-17 7:54 ` [PATCH v2 1/2] arm64: dts: rockchip: add usb3 controller node for RK3328 SoCs William Wu 2017-08-18 9:24 ` Heiko Stuebner 2017-08-21 11:35 ` wlf 2017-08-17 7:54 ` [PATCH v2 2/2] arm64: dts: rockchip: enable usb3 for RK3328 evaluation board William Wu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox