From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/14] mmc: meson-gx: clean up some constants
Date: Mon, 21 Aug 2017 13:54:57 +0200 [thread overview]
Message-ID: <1503316497.7032.1.camel@baylibre.com> (raw)
In-Reply-To: <7ha83bozoz.fsf@baylibre.com>
On Mon, 2017-08-07 at 14:06 -0700, Kevin Hilman wrote:
> Jerome Brunet <jbrunet@baylibre.com> writes:
>
> > Remove useless clock rate defines. These should not be defined but
>
> To be more precise, they're also unused, so maybe s/useless/unused/ ?
>
> > equested from the clock framework.
>
> s/equested/requested/
>
Thx Kevin !
> > Also correct typo on the DELAY register
> >
> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Otherwise,
>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
>
> > ---
> > ?drivers/mmc/host/meson-gx-mmc.c | 4 +---
> > ?1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-
> > mmc.c
> > index d480a8052a06..8a74a048db88 100644
> > --- a/drivers/mmc/host/meson-gx-mmc.c
> > +++ b/drivers/mmc/host/meson-gx-mmc.c
> > @@ -45,9 +45,7 @@
> > ?#define???CLK_DIV_MAX 63
> > ?#define???CLK_SRC_MASK GENMASK(7, 6)
> > ?#define???CLK_SRC_XTAL 0???/* external crystal */
> > -#define???CLK_SRC_XTAL_RATE 24000000
> > ?#define???CLK_SRC_PLL 1????/* FCLK_DIV2 */
> > -#define???CLK_SRC_PLL_RATE 1000000000
> > ?#define???CLK_CORE_PHASE_MASK GENMASK(9, 8)
> > ?#define???CLK_TX_PHASE_MASK GENMASK(11, 10)
> > ?#define???CLK_RX_PHASE_MASK GENMASK(13, 12)
> > @@ -57,7 +55,7 @@
> > ?#define???CLK_PHASE_270 3
> > ?#define???CLK_ALWAYS_ON BIT(24)
> > ?
> > -#define SD_EMMC_DElAY 0x4
> > +#define SD_EMMC_DELAY 0x4
> > ?#define SD_EMMC_ADJUST 0x8
> > ?#define SD_EMMC_CALOUT 0x10
> > ?#define SD_EMMC_START 0x40
next prev parent reply other threads:[~2017-08-21 11:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 17:43 [PATCH 00/14] mmc: meson-gx: driver fixups and upgrade Jerome Brunet
2017-08-04 17:43 ` [PATCH 01/14] mmc: meson-gx: fix mux mask definition Jerome Brunet
2017-08-04 17:43 ` [PATCH 02/14] mmc: meson-gx: remove CLK_DIVIDER_ALLOW_ZERO clock flag Jerome Brunet
2017-08-04 17:43 ` [PATCH 03/14] mmc: meson-gx: clean up some constants Jerome Brunet
2017-08-07 21:06 ` Kevin Hilman
2017-08-21 11:54 ` Jerome Brunet [this message]
2017-08-04 17:43 ` [PATCH 04/14] mmc: meson-gx: use _irqsave variant of spinlock Jerome Brunet
2017-08-04 17:43 ` [PATCH 05/14] mmc: meson-gx: cfg init overwrite values Jerome Brunet
2017-08-04 17:43 ` [PATCH 06/14] mmc: meson-gx: rework set_ios function Jerome Brunet
2017-08-04 17:43 ` [PATCH 07/14] mmc: meson-gx: rework clk_set function Jerome Brunet
2017-08-04 17:43 ` [PATCH 08/14] mmc: meson-gx: rework clock init function Jerome Brunet
2017-08-07 21:34 ` Kevin Hilman
2017-08-21 12:05 ` Jerome Brunet
2017-08-04 17:43 ` [PATCH 09/14] mmc: meson-gx: simplify interrupt handler Jerome Brunet
2017-08-04 17:43 ` [PATCH 10/14] mmc: meson-gx: implement card_busy callback Jerome Brunet
2017-08-04 17:43 ` [PATCH 11/14] mmc: meson-gx: rework tuning function Jerome Brunet
2017-08-04 17:43 ` [PATCH 12/14] mmc: meson-gx: fix dual data rate mode frequencies Jerome Brunet
2017-08-04 17:43 ` [PATCH 13/14] mmc: meson-gx: work around clk-stop issue Jerome Brunet
2017-08-07 21:41 ` Kevin Hilman
2017-08-04 17:43 ` [PATCH 14/14] mmc: meson-gx: implement voltage switch callback Jerome Brunet
2017-08-07 16:48 ` [PATCH 00/14] mmc: meson-gx: driver fixups and upgrade Jerome Brunet
2017-08-07 21:44 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503316497.7032.1.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).