From: anup.patel@broadcom.com (Anup Patel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 01/17] dmaengine: bcm-sba-raid: Minor improvments in comments
Date: Tue, 22 Aug 2017 15:26:50 +0530 [thread overview]
Message-ID: <1503395827-19428-2-git-send-email-anup.patel@broadcom.com> (raw)
In-Reply-To: <1503395827-19428-1-git-send-email-anup.patel@broadcom.com>
This patch does following improvments to comments:
1. Make section comments consistent across the driver by
avoiding " SBA " in some of the comments
2. Add/update few more section comments
Signed-off-by: Anup Patel <anup.patel@broadcom.com>
---
drivers/dma/bcm-sba-raid.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index e41bbc7..76999b7 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -48,7 +48,8 @@
#include "dmaengine.h"
-/* SBA command related defines */
+/* ====== Driver macros and defines ===== */
+
#define SBA_TYPE_SHIFT 48
#define SBA_TYPE_MASK GENMASK(1, 0)
#define SBA_TYPE_A 0x0
@@ -88,6 +89,8 @@
#define to_sba_device(dchan) \
container_of(dchan, struct sba_device, dma_chan)
+/* ===== Driver data structures ===== */
+
enum sba_request_state {
SBA_REQUEST_STATE_FREE = 1,
SBA_REQUEST_STATE_ALLOCED = 2,
@@ -164,7 +167,7 @@ struct sba_device {
int reqs_free_count;
};
-/* ====== SBA command helper routines ===== */
+/* ====== Command helper routines ===== */
static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
{
@@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 b1, u32 b0)
((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
}
-/* ====== Channel resource management routines ===== */
+/* ====== General helper routines ===== */
static struct sba_request *sba_alloc_request(struct sba_device *sba)
{
--
2.7.4
next prev parent reply other threads:[~2017-08-22 9:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 9:56 [PATCH v3 00/17] Broadcom SBA-RAID driver improvements Anup Patel
2017-08-22 9:56 ` Anup Patel [this message]
2017-08-22 9:56 ` [PATCH v3 02/17] dmaengine: bcm-sba-raid: Reduce locking context in sba_alloc_request() Anup Patel
2017-08-22 9:56 ` [PATCH v3 03/17] dmaengine: bcm-sba-raid: Common flags for sba_request state and fence Anup Patel
2017-08-22 9:56 ` [PATCH v3 04/17] dmaengine: bcm-sba-raid: Remove redundant next_count from sba_request Anup Patel
2017-08-22 9:56 ` [PATCH v3 05/17] dmaengine: bcm-sba-raid: Remove redundant resp_dma " Anup Patel
2017-08-22 9:56 ` [PATCH v3 06/17] dmaengine: bcm-sba-raid: Remove reqs_free_count from sba_device Anup Patel
2017-08-22 9:56 ` [PATCH v3 07/17] dmaengine: bcm-sba-raid: Allow arbitrary number free sba_request Anup Patel
2017-08-22 9:56 ` [PATCH v3 08/17] dmaengine: bcm-sba-raid: Increase number of " Anup Patel
2017-08-22 9:56 ` [PATCH v3 09/17] dmaengine: bcm-sba-raid: Improve sba_issue_pending() run duration Anup Patel
2017-08-22 9:56 ` [PATCH v3 10/17] dmaengine: bcm-sba-raid: Alloc resources before registering DMA device Anup Patel
2017-08-22 9:57 ` [PATCH v3 11/17] dmaengine: bcm-sba-raid: Peek mbox when we have no free requests Anup Patel
2017-08-22 9:57 ` [PATCH v3 12/17] dmaengine: bcm-sba-raid: Pre-ack async tx descriptor Anup Patel
2017-08-22 9:57 ` [PATCH v3 13/17] dmaengine: bcm-sba-raid: Re-factor sba_process_deferred_requests() Anup Patel
2017-08-22 9:57 ` [PATCH v3 14/17] dmaengine: bcm-sba-raid: Remove redundant SBA_REQUEST_STATE_RECEIVED Anup Patel
2017-08-22 9:57 ` [PATCH v3 15/17] dmaengine: bcm-sba-raid: Add debugfs support Anup Patel
2017-08-22 9:57 ` [PATCH v3 16/17] dmaengine: bcm-sba-raid: Explicitly ACK mailbox message after sending Anup Patel
2017-08-22 9:57 ` [PATCH v3 17/17] dmaengine: bcm-sba-raid: Remove redundant SBA_REQUEST_STATE_COMPLETED Anup Patel
2017-08-28 11:14 ` [PATCH v3 00/17] Broadcom SBA-RAID driver improvements Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503395827-19428-2-git-send-email-anup.patel@broadcom.com \
--to=anup.patel@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).