* [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO
@ 2017-08-27 6:31 Himanshu Jha
2017-08-27 18:49 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Himanshu Jha @ 2017-08-27 6:31 UTC (permalink / raw)
To: linux-arm-kernel
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/tty/serial/8250/8250_mtk.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
index ce0cc47..fb45770 100644
--- a/drivers/tty/serial/8250/8250_mtk.c
+++ b/drivers/tty/serial/8250/8250_mtk.c
@@ -171,10 +171,7 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,
}
data->bus_clk = devm_clk_get(&pdev->dev, "bus");
- if (IS_ERR(data->bus_clk))
- return PTR_ERR(data->bus_clk);
-
- return 0;
+ return PTR_ERR_OR_ZERO(data->bus_clk);
}
static int mtk8250_probe(struct platform_device *pdev)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO
2017-08-27 6:31 [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO Himanshu Jha
@ 2017-08-27 18:49 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2017-08-27 18:49 UTC (permalink / raw)
To: linux-arm-kernel
On 08/27/2017 09:31 AM, Himanshu Jha wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/tty/serial/8250/8250_mtk.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index ce0cc47..fb45770 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -171,10 +171,7 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,
> }
>
> data->bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(data->bus_clk))
> - return PTR_ERR(data->bus_clk);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(data->bus_clk);
> }
>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-27 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-27 6:31 [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO Himanshu Jha
2017-08-27 18:49 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).