public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: sean.wang@mediatek.com (Sean Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 RESEND 1/2] dt-bindings: serial: 8250: Add MediaTek BTIF controller bindings
Date: Mon, 28 Aug 2017 03:39:45 +0800	[thread overview]
Message-ID: <1503862785.19230.76.camel@mtkswgap22> (raw)
In-Reply-To: <8548a72a-4bf3-d44a-6d26-d64721cffe85@gmail.com>

On Sun, 2017-08-27 at 22:00 +0300, Matthias Brugger wrote:
> 
> On 08/19/2017 09:06 PM, sean.wang at mediatek.com wrote:
> > From: Sean Wang <sean.wang@mediatek.com>
> > 
> > Document the devicetree bindings in 8250.txt for MediaTek BTIF
> > controller which could be found on MT7622 and MT7623 SoC.
> > 
> > Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> > ---
> >   Documentation/devicetree/bindings/serial/8250.txt | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/8250.txt b/Documentation/devicetree/bindings/serial/8250.txt
> > index 419ff6c..7528d90 100644
> > --- a/Documentation/devicetree/bindings/serial/8250.txt
> > +++ b/Documentation/devicetree/bindings/serial/8250.txt
> > @@ -14,6 +14,9 @@ Required properties:
> >   	  tegra132, or tegra210.
> >   	- "nxp,lpc3220-uart"
> >   	- "ralink,rt2880-uart"
> > +	- For MediaTek MT7623, must contain "mediatek,mt7623-btif"
> > +	- For other MediaTek SoCs , must contain "mediatek,<chip>-btif",
> > +	  "mediatek,mt7623-btif" where <chip> is mt7622.
> 
> Hm, to me that's confusing. What about:
> "mediatek,mt7623-btif": for MediaTek MT7623
> "mediatek,mt7622-btif", "mediatek,mt7623-btif": for MediaTek MT7622
> 
> If in the future we have more SoCs that support the BTIF, we should add them 
> like the mt7622 case.
> 

I had v3, but it should have similar logic and also got ack from Rob

I knew all your logic of adding binding document for all MediaTek
devices, even I alway added MediaTek device in dt-bindings as the way
you mentioned here, but I felt this way is fine for this kind of
dedicated document.

The reason i don't add it as usual is the following. 8250.txt is common
and shared among all uart like devices, so i don't want btif device
occupies too much section and bloat the document when every new MediaTek
SoC is introduced. 

So instead I refer to existing Nvidia device added in 8250.txt  which I
thought its way is simple, elegant and also using pattern I can use to
add btif devices.

	Sean

> Make sense?
> 
> Regards,
> Matthias

  reply	other threads:[~2017-08-27 19:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-19 18:03 [PATCH v2 0/2] sean.wang at mediatek.com
2017-08-19 18:03 ` [PATCH v2 1/2] dt-bindings: serial: 8250: Add MediaTek BTIF controller bindings sean.wang at mediatek.com
2017-08-27 19:00   ` [PATCH v2 RESEND " Matthias Brugger
2017-08-27 19:39     ` Sean Wang [this message]
2017-08-28  5:21       ` Matthias Brugger
2017-08-19 18:03 ` [PATCH v2 2/2] serial: 8250: of: Add new port type for MediaTek BTIF controller on MT7622/23 SoC sean.wang at mediatek.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1503862785.19230.76.camel@mtkswgap22 \
    --to=sean.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox