From: nouveau@karolherbst.de (Karol Herbst)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
Date: Wed, 13 Jan 2016 14:55:47 +0100 (CET) [thread overview]
Message-ID: <1503925101.39877.1452693347204.JavaMail.open-xchange@www.ud-mail.de> (raw)
In-Reply-To: <3968390.Pvmnq3v7oC@wuerfel>
> Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48 geschrieben:
>
> The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
> is disabled:
>
> In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
> drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
> drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
> nouveau_debugfs_init(struct nouveau_drm *)
>
> This fixes the prototypes so we can build it again.
>
thanks for this. I already send a patch to the nouveau ML here:
http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
but I guess I should mail to the kernel list directly next time.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debugfs")
> ---
> This broke when the nouveau patches got merged into drm-next on Monday.
> Found on ARM randconfig builds.
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> index 52c7161297d7..b8c03ff5bf05 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.h
> @@ -34,13 +34,13 @@ nouveau_drm_debugfs_cleanup(struct drm_minor *minor)
> }
>
> static inline int
> -nouveau_debugfs_init(struct nouveau_drm *)
> +nouveau_debugfs_init(struct nouveau_drm *drm)
> {
> return 0;
> }
>
> static inline void
> -nouveau_debugfs_fini(struct nouveau_drm *)
> +nouveau_debugfs_fini(struct nouveau_drm *drm)
> {
> }
>
next prev parent reply other threads:[~2016-01-13 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 13:48 [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann
2016-01-13 13:55 ` Karol Herbst [this message]
2016-01-13 14:00 ` Arnd Bergmann
2016-01-15 11:06 ` Emil Velikov
2016-01-15 12:07 ` Karol Herbst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1503925101.39877.1452693347204.JavaMail.open-xchange@www.ud-mail.de \
--to=nouveau@karolherbst.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).