From: ulf.hansson@linaro.org (Ulf Hansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/8] PM / ACPI: Split acpi_lpss_suspend_late|resume_early()
Date: Tue, 29 Aug 2017 16:56:47 +0200 [thread overview]
Message-ID: <1504018610-10822-6-git-send-email-ulf.hansson@linaro.org> (raw)
In-Reply-To: <1504018610-10822-1-git-send-email-ulf.hansson@linaro.org>
Move the code which is special to ACPI LPSS into separate functions. This
may clarify the code a bit, but the main purpose of this change, is instead
to prepare for additional changes on top. Ideally the following changes
should then become easier to review.
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
Changes in v3:
- None.
---
drivers/acpi/acpi_lpss.c | 29 +++++++++++++++++++++++------
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 0c84d15..e726173 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -717,22 +717,28 @@ static void acpi_lpss_dismiss(struct device *dev)
}
#ifdef CONFIG_PM_SLEEP
-static int acpi_lpss_suspend_late(struct device *dev)
+static int lpss_suspend_late(struct device *dev)
{
struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
+
+ if (pdata->dev_desc->flags & LPSS_SAVE_CTX)
+ acpi_lpss_save_ctx(dev, pdata);
+
+ return acpi_dev_suspend_late(dev);
+}
+
+static int acpi_lpss_suspend_late(struct device *dev)
+{
int ret;
ret = pm_generic_suspend_late(dev);
if (ret)
return ret;
- if (pdata->dev_desc->flags & LPSS_SAVE_CTX)
- acpi_lpss_save_ctx(dev, pdata);
-
- return acpi_dev_suspend_late(dev);
+ return lpss_suspend_late(dev);
}
-static int acpi_lpss_resume_early(struct device *dev)
+static int lpss_resume_early(struct device *dev)
{
struct lpss_private_data *pdata = acpi_driver_data(ACPI_COMPANION(dev));
int ret;
@@ -746,6 +752,17 @@ static int acpi_lpss_resume_early(struct device *dev)
if (pdata->dev_desc->flags & LPSS_SAVE_CTX)
acpi_lpss_restore_ctx(dev, pdata);
+ return 0;
+}
+
+static int acpi_lpss_resume_early(struct device *dev)
+{
+ int ret;
+
+ ret = lpss_resume_early(dev);
+ if (ret)
+ return ret;
+
return pm_generic_resume_early(dev);
}
#endif /* CONFIG_PM_SLEEP */
--
2.7.4
next prev parent reply other threads:[~2017-08-29 14:56 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 14:56 [PATCH v3 0/8] PM / ACPI / i2c: Deploy runtime PM centric path for system sleep Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 1/8] PM / Sleep: Make the runtime PM centric path known to the PM core Ulf Hansson
2017-08-29 15:15 ` Rafael J. Wysocki
2017-08-30 7:13 ` Ulf Hansson
2017-08-30 13:37 ` Rafael J. Wysocki
2017-08-31 9:06 ` Ulf Hansson
2017-09-02 14:48 ` Rafael J. Wysocki
2017-08-29 14:56 ` [PATCH v3 2/8] PM / ACPI: Restore acpi_subsys_complete() Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 3/8] PM / Sleep: Remove pm_complete_with_resume_check() Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 4/8] PM / ACPI: Split code validating need for runtime resume in ->prepare() Ulf Hansson
2017-08-29 14:56 ` Ulf Hansson [this message]
2017-08-29 14:56 ` [PATCH v3 6/8] PM / ACPI: Enable the runtime PM centric approach for system sleep Ulf Hansson
2017-08-29 15:27 ` Rafael J. Wysocki
2017-09-01 8:27 ` Ulf Hansson
2017-09-02 15:38 ` Rafael J. Wysocki
2017-09-04 13:21 ` Ulf Hansson
2017-09-06 0:02 ` Rafael J. Wysocki
2017-08-29 14:56 ` [PATCH v3 7/8] i2c: designware: Don't resume device in the ->complete() callback Ulf Hansson
2017-08-29 14:56 ` [PATCH v3 8/8] i2c: designware: Deploy the runtime PM centric path for system sleep Ulf Hansson
2017-08-29 20:19 ` [PATCH v3 0/8] PM / ACPI / i2c: Deploy " Rafael J. Wysocki
2017-08-30 9:57 ` Ulf Hansson
2017-08-31 0:17 ` Rafael J. Wysocki
2017-09-01 10:42 ` Ulf Hansson
2017-09-04 0:17 ` Rafael J. Wysocki
2017-09-04 5:46 ` Lukas Wunner
2017-09-04 10:04 ` Rafael J. Wysocki
2017-09-04 12:55 ` Ulf Hansson
2017-09-06 0:52 ` Rafael J. Wysocki
2017-09-06 10:46 ` Rafael J. Wysocki
2017-09-06 13:59 ` Ulf Hansson
2017-09-06 21:39 ` Rafael J. Wysocki
2017-09-06 13:54 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504018610-10822-6-git-send-email-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).