linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vviswana@codeaurora.org (Vijay Viswanath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 0/5] mmc: sdhci-msm: Corrections to implementation of power irq
Date: Wed, 30 Aug 2017 18:21:44 +0530	[thread overview]
Message-ID: <1504097509-58983-1-git-send-email-vviswana@codeaurora.org> (raw)

Register writes which change voltage of IO lines or turn the IO bus on/off
require sdhc controller to be ready before progressing further. Once a
register write which affects IO lines is done, the driver should wait for
power irq from controller. Once the irq comes, the driver should acknowledge
the irq by writing to power control register. If the acknowledgement is not
given to controller, the controller may not complete the corresponding
register write action and this can mess up the controller if drivers proceeds
without power irq completing.

Changes since RFC:
	wait_for_completion_timeout replaced with wait_event_timeout when
	waiting for power irq.
	Removed the spinlock within power irq handler and API which waits
	for power irq.
	Added comments to sdhci msm register write functions, warning that they
	can sleep.
	Sdhci msm register write functions will do a memory barrier before
	writing to the register if the particular register can trigger
	power irq.
	Instead of enabling SDHCI IO ACCESSORS config in arm64/defconfig, it
	will be selected in mmc/host/Kconfig if the platform is MMC_SDHCI_MSM.


Sahitya Tummala (2):
  mmc: sdhci-msm: Fix HW issue with power IRQ handling during reset
  mmc: sdhci-msm: Add support to wait for power irq

Subhash Jadavani (1):
  mmc: sdhci-msm: fix issue with power irq

Vijay Viswanath (2):
  mmc: sdhci-msm: Add ops to do sdhc register write
  mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS

 drivers/mmc/host/Kconfig     |   1 +
 drivers/mmc/host/sdhci-msm.c | 253 ++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 249 insertions(+), 5 deletions(-)

-- 
 Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

             reply	other threads:[~2017-08-30 12:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 12:51 Vijay Viswanath [this message]
2017-08-30 12:51 ` [PATCH v1 1/5] mmc: sdhci-msm: fix issue with power irq Vijay Viswanath
2017-09-14  6:20   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 2/5] mmc: sdhci-msm: Fix HW issue with power IRQ handling during reset Vijay Viswanath
2017-09-14  6:20   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 3/5] mmc: sdhci-msm: Add support to wait for power irq Vijay Viswanath
2017-09-14  6:34   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 4/5] mmc: sdhci-msm: Add ops to do sdhc register write Vijay Viswanath
2017-09-14  6:34   ` Adrian Hunter
2017-08-30 12:51 ` [PATCH v1 5/5] mmc: Kconfig: Enable CONFIG_MMC_SDHCI_IO_ACCESSORS Vijay Viswanath
2017-09-14  6:34   ` Adrian Hunter
2017-09-19  4:03     ` Vijay Viswanath
2017-09-19  5:44       ` Adrian Hunter
2017-09-12  9:27 ` [PATCH v1 0/5] mmc: sdhci-msm: Corrections to implementation of power irq Vijay Viswanath
2017-09-12 10:41   ` Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504097509-58983-1-git-send-email-vviswana@codeaurora.org \
    --to=vviswana@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).