From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Enforce endianness build flags for LD and AS
Date: Tue, 3 Oct 2017 13:58:22 -0700 [thread overview]
Message-ID: <1507064302-3972-1-git-send-email-linux@roeck-us.net> (raw)
If LD or AS is specified on the command line using "make LD=<my-ld>",
the endianness flag will not be added. Depending on the toolchain used,
this can result in endianness mismatch errors, such as
aarch64-cros-linux-gnu/binutils-bin/2.27.0/ld.bfd.real:
arch/arm64/crypto/.tmp_aes-ce-cipher.o:
compiled for a big endian system and target is little endian
The problem was observed when using the Chrome OS build system (which sets
LD on the command line) for an arm64:allmodconfig build.
Use the override flag for both LD and AS to ensure that the endianness
flag is always set.
Cc: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/arm64/Makefile | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 939b310913cf..d780d00bea9c 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -56,15 +56,15 @@ KBUILD_AFLAGS += $(call cc-option,-mabi=lp64)
ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
KBUILD_CPPFLAGS += -mbig-endian
CHECKFLAGS += -D__AARCH64EB__
-AS += -EB
-LD += -EB
+override AS += -EB
+override LD += -EB
LDFLAGS += -maarch64linuxb
UTS_MACHINE := aarch64_be
else
KBUILD_CPPFLAGS += -mlittle-endian
CHECKFLAGS += -D__AARCH64EL__
-AS += -EL
-LD += -EL
+override AS += -EL
+override LD += -EL
LDFLAGS += -maarch64linux
UTS_MACHINE := aarch64
endif
--
2.7.4
next reply other threads:[~2017-10-03 20:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 20:58 Guenter Roeck [this message]
2017-10-03 21:04 ` [PATCH] arm64: Enforce endianness build flags for LD and AS Doug Anderson
2017-10-04 18:31 ` Guenter Roeck
2017-10-04 18:41 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507064302-3972-1-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).