From: chunfeng.yun@mediatek.com (Chunfeng Yun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] dt-bindings: usb: mtk-xhci: add a optional property to disable u3ports
Date: Wed, 11 Oct 2017 14:37:34 +0800 [thread overview]
Message-ID: <1507703854.17567.77.camel@mhfsdcap03> (raw)
In-Reply-To: <20171005221650.yfyh72op6azm2nri@rob-hp-laptop>
On Thu, 2017-10-05 at 17:16 -0500, Rob Herring wrote:
Hi,
> On Wed, Sep 27, 2017 at 05:23:04PM +0800, Chunfeng Yun wrote:
> > Add a new optional property to disable u3ports
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> > index 5611a2e..2d9b459 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> > @@ -38,6 +38,8 @@ Optional properties:
> > mode;
> > - mediatek,syscon-wakeup : phandle to syscon used to access USB wakeup
> > control register, it depends on "mediatek,wakeup-src".
> > + - mediatek,u3p-dis-msk : mask to disable u3ports, bit0 for u3port0,
> > + bit1 for u3port1, ... etc;
>
> I think you should have child nodes for ports and use "status" to
> disable them (or omit them). IIRC, the common USB bus binding already
> defines ports.
I find only one common binding document about USB bus, that is
bindings/usb/usb-device.txt, but it can't be used to disable some ports,
because in hub_probe() function, hub driver enables all downstream
ports, but doesn't get any property info from DTS.
>
> > - vbus-supply : reference to the VBUS regulator;
> > - usb3-lpm-capable : supports USB3.0 LPM
> > - pinctrl-names : a pinctrl state named "default" must be defined
> > --
> > 1.7.9.5
> >
next prev parent reply other threads:[~2017-10-11 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 9:22 [PATCH 1/9] usb: xhci-mtk: use dma_set_mask_and_coherent() in probe function Chunfeng Yun
2017-09-27 9:22 ` [PATCH 2/9] usb: xhci-mtk: use ports count from xhci in xhci_mtk_sch_init() Chunfeng Yun
2017-09-27 9:22 ` [PATCH 3/9] usb: xhci-mtk: check clock stability of U3_MAC Chunfeng Yun
2017-09-27 9:23 ` [PATCH 4/9] usb: xhci-mtk: support option to disable usb3 ports Chunfeng Yun
2017-09-27 9:23 ` [PATCH 5/9] usb: xhci-mtk: remove dummy wakeup debounce clocks Chunfeng Yun
2017-09-27 9:23 ` [PATCH 6/9] usb: xhci-mtk: add optional mcu and dma bus clocks Chunfeng Yun
2017-09-27 9:23 ` [PATCH 7/9] usb: host: modify description for MTK xHCI config Chunfeng Yun
2017-09-27 9:23 ` [PATCH 8/9] dt-bindings: usb: mtk-xhci: add a optional property to disable u3ports Chunfeng Yun
2017-10-05 22:16 ` Rob Herring
2017-10-09 2:15 ` Chunfeng Yun
2017-10-11 6:37 ` Chunfeng Yun [this message]
2017-09-27 9:23 ` [PATCH 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks and add optional ones Chunfeng Yun
2017-10-05 22:20 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507703854.17567.77.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox