linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: imx: Enable cpuidle for i.MX6DL starting at 1.1
Date: Wed, 11 Oct 2017 14:09:57 +0200	[thread overview]
Message-ID: <1507723797.2398.8.camel@pengutronix.de> (raw)
In-Reply-To: <800ef25ed868f303bb2aece5dba59d395340f25d.1507722933.git.leonard.crestez@nxp.com>

Am Mittwoch, den 11.10.2017, 15:08 +0300 schrieb Leonard Crestez:
> Enable cpuidle support on i.MX6DL starting from
> IMX_CHIP_REVISION_1_1.
> 
> This also makes the code cleaner because 6q and 6dl actually have
> different revision histories.
> 
> Signed-off-by: Bai Ping <ping.bai@nxp.com>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>

> ---
> 
> Changes since v1: https://www.spinics.net/lists/arm-kernel/msg610461.
> html
> * Clarified comment but kept > instead of >= because that's what the
> old code used. Would be OK to change with further feedback.
> 
> ?arch/arm/mach-imx/mach-imx6q.c | 9 ++++++---
> ?1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-
> imx6q.c
> index 45801b2..5707113 100644
> --- a/arch/arm/mach-imx/mach-imx6q.c
> +++ b/arch/arm/mach-imx/mach-imx6q.c
> @@ -371,10 +371,13 @@ static struct platform_device
> imx6q_cpufreq_pdev = {
> ?static void __init imx6q_init_late(void)
> ?{
> ?	/*
> -	?* WAIT mode is broken on TO 1.0 and 1.1, so there is no
> point
> -	?* to run cpuidle on them.
> +	?* WAIT mode is broken on imx6 Dual/Quad revision 1.0 and
> 1.1 so
> +	?* there is no point to run cpuidle on them.
> +	?*
> +	?* It does work on imx6 Solo/DualLite starting from 1.1
> ?	?*/
> -	if (imx_get_soc_revision() > IMX_CHIP_REVISION_1_1)
> +	if ((cpu_is_imx6q() && imx_get_soc_revision() >
> IMX_CHIP_REVISION_1_1) ||
> +	????(cpu_is_imx6dl() && imx_get_soc_revision() >
> IMX_CHIP_REVISION_1_0))
> ?		imx6q_cpuidle_init();
> ?
> ?	if (IS_ENABLED(CONFIG_ARM_IMX6Q_CPUFREQ)) {

  reply	other threads:[~2017-10-11 12:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 12:08 [PATCH v2] ARM: imx: Enable cpuidle for i.MX6DL starting at 1.1 Leonard Crestez
2017-10-11 12:09 ` Lucas Stach [this message]
2017-10-14 15:05 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507723797.2398.8.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).