linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: julien.thierry@arm.com (Julien Thierry)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 0/2] Distinguish percpu irq and percpu_devid irq
Date: Fri, 13 Oct 2017 12:26:43 +0100	[thread overview]
Message-ID: <1507894005-53778-1-git-send-email-julien.thierry@arm.com> (raw)

[Resending with cover letter + better commit message for patch 1]

Hi,

Looking at the arm_pmu driver, it seems we are using irq_is_percpu when we
want to know if an irq must be configured individually on each cpu. But
this is not what irq_is_percpu does. The arm_pmu marking all its irqs as
PERCPU, driver attempts to enable the irq on each CPU even when it is not
needed.

This has not caused issue so far because enable_percpu_irq returns
immediatly if the provided irq is not PERCPU_DEVID.

* Patch 1 adds the function to identify PERCPU_DEVID irqs.
* Patch 2 replaces the irq_is_percpu calls with the new function

Cheers,

Julien

Julien Thierry (2):
  irqdesc: Add function to identify percpu_devid irqs
  arm/arm64: pmu: Distinguish percpu irq and percpu_devid irq

 drivers/perf/arm_pmu.c          | 10 +++++-----
 drivers/perf/arm_pmu_platform.c |  4 ++--
 include/linux/irqdesc.h         |  8 ++++++++
 3 files changed, 15 insertions(+), 7 deletions(-)

--
1.9.1

             reply	other threads:[~2017-10-13 11:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-13 11:26 Julien Thierry [this message]
2017-10-13 11:26 ` [RESEND PATCH 1/2] irqdesc: Add function to identify percpu_devid irqs Julien Thierry
2017-10-13 16:53   ` Marc Zyngier
2017-10-13 17:44   ` Mark Rutland
2017-10-24 14:46     ` Will Deacon
2017-10-24 14:50       ` Thomas Gleixner
2017-10-24 14:52         ` Will Deacon
2017-10-13 11:26 ` [RESEND PATCH 2/2] arm/arm64: pmu: Distinguish percpu irq and percpu_devid irq Julien Thierry
2017-10-13 16:47   ` Mark Rutland
2017-10-16  8:19     ` Julien Thierry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507894005-53778-1-git-send-email-julien.thierry@arm.com \
    --to=julien.thierry@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).