From: rsahu@apm.com (Rameshwar Prasad Sahu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event
Date: Wed, 25 Oct 2017 15:52:56 +0530 [thread overview]
Message-ID: <1508926976-11467-1-git-send-email-rsahu@apm.com> (raw)
When tracing ata link error event, the kernel crashes when the disk is
removed due to NULL pointer access by trace_ata_eh_link_autopsy API.
This occurs as the dev is NULL when the disk disappeared. Given that
the trace routine requires only the link info, pass the link info instead
of passing dev pointer to fix this kernel crash.
Signed-off-by: Rameshwar Prasad Sahu <rsahu@apm.com>
---
drivers/ata/libata-eh.c | 2 +-
include/trace/events/libata.h | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index e4effef..ab50e7d 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2265,7 +2265,7 @@ static void ata_eh_link_autopsy(struct ata_link *link)
eflags |= ATA_EFLAG_DUBIOUS_XFER;
ehc->i.action |= ata_eh_speed_down(dev, eflags, all_err_mask);
}
- trace_ata_eh_link_autopsy(dev, ehc->i.action, all_err_mask);
+ trace_ata_eh_link_autopsy(link, ehc->i.action, all_err_mask);
DPRINTK("EXIT\n");
}
diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
index 2fbbf99..eff035e 100644
--- a/include/trace/events/libata.h
+++ b/include/trace/events/libata.h
@@ -276,9 +276,10 @@
TRACE_EVENT(ata_eh_link_autopsy,
- TP_PROTO(struct ata_device *dev, unsigned int eh_action, unsigned int eh_err_mask),
+ TP_PROTO(struct ata_link *link, unsigned int eh_action,
+ unsigned int eh_err_mask),
- TP_ARGS(dev, eh_action, eh_err_mask),
+ TP_ARGS(link, eh_action, eh_err_mask),
TP_STRUCT__entry(
__field( unsigned int, ata_port )
@@ -288,8 +289,8 @@
),
TP_fast_assign(
- __entry->ata_port = dev->link->ap->print_id;
- __entry->ata_dev = dev->link->pmp + dev->devno;
+ __entry->ata_port = link->ap->print_id;
+ __entry->ata_dev = link->pmp + link->device->devno;
__entry->eh_action = eh_action;
__entry->eh_err_mask = eh_err_mask;
),
--
1.7.1
next reply other threads:[~2017-10-25 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 10:22 Rameshwar Prasad Sahu [this message]
2017-10-25 14:54 ` [PATCH] ata: fixes kernel crash while tracing ata_eh_link_autopsy event Tejun Heo
[not found] ` <CAFd313w9W2hHFPJ47y0jeNb1u7=0deLtwcRF=+HXGBYft-QaLw@mail.gmail.com>
2017-11-01 14:30 ` Tejun Heo
2017-11-02 9:57 ` Rameshwar Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508926976-11467-1-git-send-email-rsahu@apm.com \
--to=rsahu@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).